Re: [PATCH] virtio_net: fix use after free

2014-10-30 Thread Jason Wang
On 10/31/2014 11:36 AM, Eric Dumazet wrote: > On Wed, 2014-10-15 at 16:23 +0300, Michael S. Tsirkin wrote: >> commit 0b725a2ca61bedc33a2a63d0451d528b268cf975 >> net: Remove ndo_xmit_flush netdev operation, use signalling instead. >> >> added code that looks at skb->xmit_more after the skb has >

Re: Re: kernel BUG at drivers/block/virtio_blk.c:172

2014-10-30 Thread Ming Lei
On Thu, Oct 30, 2014 at 10:38 PM, Jens Axboe wrote: > Forgot to CC you... > > > Forwarded Message > Subject: Re: kernel BUG at drivers/block/virtio_blk.c:172 > Date: Thu, 30 Oct 2014 08:38:08 -0600 > From: Jens Axboe > To: Lukáš Czerner , > virtualization@lists.linux-foundation.

Re: [PATCH] virtio_net: fix use after free

2014-10-30 Thread Eric Dumazet
On Wed, 2014-10-15 at 16:23 +0300, Michael S. Tsirkin wrote: > commit 0b725a2ca61bedc33a2a63d0451d528b268cf975 > net: Remove ndo_xmit_flush netdev operation, use signalling instead. > > added code that looks at skb->xmit_more after the skb has > been put in TX VQ. Since some paths process the

Re: [PATCH v2 4/6] hw_random: fix unregister race.

2014-10-30 Thread Rusty Russell
Herbert Xu writes: > On Thu, Sep 18, 2014 at 08:37:45PM +0800, Amos Kong wrote: >> From: Rusty Russell >> >> The previous patch added one potential problem: we can still be >> reading from a hwrng when it's unregistered. Add a wait for zero >> in the hwrng_unregister path. >> >> Signed-off-by:

Re: [PATCH] virtio_ccw: remove unsued variable

2014-10-30 Thread Rusty Russell
Cornelia Huck writes: > On Tue, 28 Oct 2014 19:37:58 +0200 > "Michael S. Tsirkin" wrote: > >> On Tue, Oct 28, 2014 at 04:39:12PM +0100, Sebastian Ott wrote: > >> > virtio_ccw: remove unused variable >> > >> > Fix this warning: >> > drivers/s390/kvm/virtio_ccw.c: In function ‘virtio_ccw_int_handl

Re: [PATCH v2 net 0/2] drivers/net,ipv6: Fix IPv6 fragment ID selection for virtio

2014-10-30 Thread David Miller
From: Ben Hutchings Date: Thu, 30 Oct 2014 18:26:32 + > The virtio net protocol supports UFO but does not provide for passing a > fragment ID for fragmentation of IPv6 packets. We used to generate a > fragment ID wherever such a packet was fragmented, but currently we > always use ID=0! > >

Re: [PATCH v2 net 1/2] drivers/net: Disable UFO through virtio

2014-10-30 Thread Eric Dumazet
On Thu, 2014-10-30 at 22:20 +, Ben Hutchings wrote: > Could do. I'm trying to make small fixes that are suitable for stable. Oh right, makes sense ;) ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfou

Re: [Qemu-devel] [PATCH RFC 05/11] virtio: introduce legacy virtio devices

2014-10-30 Thread Greg Kurz
On Thu, 30 Oct 2014 19:02:01 +0100 Cornelia Huck wrote: > On Tue, 28 Oct 2014 16:40:18 +0100 > Greg Kurz wrote: > > > On Tue, 7 Oct 2014 16:40:01 +0200 > > Cornelia Huck wrote: > > > > > Introduce a helper function to indicate whether a virtio device is > > > operating in legacy or virtio s

Re: [PATCH v2 net 1/2] drivers/net: Disable UFO through virtio

2014-10-30 Thread Ben Hutchings
On Thu, 2014-10-30 at 11:47 -0700, Eric Dumazet wrote: > On Thu, 2014-10-30 at 18:27 +, Ben Hutchings wrote: > > > > + { > > + static bool warned; > > + > > + if (!warned) { > > + warned = true; > > +

Re: [PATCH v2 net 1/2] drivers/net: Disable UFO through virtio

2014-10-30 Thread Eric Dumazet
On Thu, 2014-10-30 at 18:27 +, Ben Hutchings wrote: > + { > + static bool warned; > + > + if (!warned) { > + warned = true; > + netdev_warn(tun->dev, > +

[PATCH v2 net 2/2] drivers/net,ipv6: Select IPv6 fragment idents for virtio UFO packets

2014-10-30 Thread Ben Hutchings
UFO is now disabled on all drivers that work with virtio net headers, but userland may try to send UFO/IPv6 packets anyway. Instead of sending with ID=0, we should select identifiers on their behalf (as we used to). Signed-off-by: Ben Hutchings Fixes: 916e4cf46d02 ("ipv6: reuse ip6_frag_id from

[PATCH v2 net 1/2] drivers/net: Disable UFO through virtio

2014-10-30 Thread Ben Hutchings
IPv6 does not allow fragmentation by routers, so there is no fragmentation ID in the fixed header. UFO for IPv6 requires the ID to be passed separately, but there is no provision for this in the virtio net protocol. Until recently our software implementation of UFO/IPv6 generated a new ID, but th

[PATCH v2 net 0/2] drivers/net,ipv6: Fix IPv6 fragment ID selection for virtio

2014-10-30 Thread Ben Hutchings
The virtio net protocol supports UFO but does not provide for passing a fragment ID for fragmentation of IPv6 packets. We used to generate a fragment ID wherever such a packet was fragmented, but currently we always use ID=0! v2: Add blank lines after declarations Ben. Ben Hutchings (2): driv

Re: [Qemu-devel] [PATCH RFC 05/11] virtio: introduce legacy virtio devices

2014-10-30 Thread Cornelia Huck
On Tue, 28 Oct 2014 16:40:18 +0100 Greg Kurz wrote: > On Tue, 7 Oct 2014 16:40:01 +0200 > Cornelia Huck wrote: > > > Introduce a helper function to indicate whether a virtio device is > > operating in legacy or virtio standard mode. > > > > It may be used to make decisions about the endianes

Re: [PATCH] virtio_ccw: remove unsued variable

2014-10-30 Thread Cornelia Huck
On Tue, 28 Oct 2014 19:37:58 +0200 "Michael S. Tsirkin" wrote: > On Tue, Oct 28, 2014 at 04:39:12PM +0100, Sebastian Ott wrote: > > virtio_ccw: remove unused variable > > > > Fix this warning: > > drivers/s390/kvm/virtio_ccw.c: In function ‘virtio_ccw_int_handler’: > > drivers/s390/kvm/virtio_c

Re: [PATCH RFC 00/11] qemu: towards virtio-1 host support

2014-10-30 Thread Cornelia Huck
On Tue, 28 Oct 2014 06:43:29 +0200 "Michael S. Tsirkin" wrote: > On Fri, Oct 24, 2014 at 10:38:39AM +0200, Cornelia Huck wrote: > > On Fri, 24 Oct 2014 00:42:20 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, Oct 07, 2014 at 04:39:56PM +0200, Cornelia Huck wrote: > > > > This patchset a

Re: [Xen-devel] [RFC] Hypervisor RNG and enumeration

2014-10-30 Thread Ian Campbell
On Thu, 2014-10-30 at 07:45 -0700, Andy Lutomirski wrote: > > Xen does not have a continual source of entropy and the only feasible > > way is for the toolstack to provide each guest with a fixed size pool of > > random data during guest creation. > > > > Xen could seed a very simple per-guest DRB

Re: [Xen-devel] [RFC] Hypervisor RNG and enumeration

2014-10-30 Thread Roger Pau Monné
Adding the bhyve guys. El 29/10/14 a les 6.19, Andy Lutomirski ha escrit: > Here's a draft CommonHV spec. It's also on github: > > https://github.com/amluto/CommonHV > > So far, this provides a two-way RNG interface, a way to detect it, and > a way to detect other hypervisor leaves. The latter

kernel BUG at drivers/block/virtio_blk.c:172

2014-10-30 Thread Lukáš Czerner
Hi, I've just hit this BUG at drivers/block/virtio_blk.c when updated to the kernel from the top of the Linus git tree. commit a7ca10f263d7e673c74d8e0946d6b9993405cc9c This is my virtual machine running on RHEL7 guest qemu-kvm-1.5.3-60.el7.x86_64 The last upstream kernel (3.17.0-rc4) worked we

Re: [Xen-devel] [RFC] Hypervisor RNG and enumeration

2014-10-30 Thread Andy Lutomirski
On Thu, Oct 30, 2014 at 5:21 AM, David Vrabel wrote: > On 29/10/14 05:19, Andy Lutomirski wrote: >> CPUID leaf 4F02H: miscellaneous features >> >> > [...] >> ### CommonHV RNG >> >> If CPUID.4F02H.EAX is nonzero, then it contains an MSR index use

Re: kernel BUG at drivers/block/virtio_blk.c:172

2014-10-30 Thread Jens Axboe
On 2014-10-30 08:33, Lukáš Czerner wrote: Hi, I've just hit this BUG at drivers/block/virtio_blk.c when updated to the kernel from the top of the Linus git tree. commit a7ca10f263d7e673c74d8e0946d6b9993405cc9c This is my virtual machine running on RHEL7 guest qemu-kvm-1.5.3-60.el7.x86_64 The

Call for Papers - WorldCIST'15 - Azores, Deadline: November 23

2014-10-30 Thread ML
-- WorldCIST'15 - 3rd World Conference on Information Systems and Technologies Ponta Delgada, Azores *, Portugal 1 - 3 April 2015 http://www.aisti.eu/worldcist15/ -- * Azores is ranked as the second most beautiful archipelago in the world by National Geographic. SCOPE The

Re: [Xen-devel] [RFC] Hypervisor RNG and enumeration

2014-10-30 Thread Paolo Bonzini
On 10/30/2014 01:21 PM, David Vrabel wrote: > I would add: > > If the hypervisor's pool of random data is exhausted, it MAY > return 0. The hypervisor MUST provide at least 4 (?) non-zero > numbers to each guest. Mandating "non-zero numbers" sounds like a bad idea. Just use the RNG for wh

Re: [Xen-devel] [RFC] Hypervisor RNG and enumeration

2014-10-30 Thread David Vrabel
On 29/10/14 05:19, Andy Lutomirski wrote: > CPUID leaf 4F02H: miscellaneous features > > [...] > ### CommonHV RNG > > If CPUID.4F02H.EAX is nonzero, then it contains an MSR index used to > communicate with a hypervisor random number generator.

Re: [Qemu-devel] [PATCH RFC 07/11] dataplane: allow virtio-1 devices

2014-10-30 Thread Cornelia Huck
On Tue, 28 Oct 2014 16:22:54 +0100 Greg Kurz wrote: > On Tue, 7 Oct 2014 16:40:03 +0200 > Cornelia Huck wrote: > > > Handle endianness conversion for virtio-1 virtqueues correctly. > > > > Note that dataplane now needs to be built per-target. > > > > It also affects hw/virtio/virtio-pci.c: