Re: [RFC PATCH] virtio-mmio: support for multiple irqs

2014-11-12 Thread Shannon Zhao
On 2014/11/11 23:11, Pawel Moll wrote: On Tue, 2014-11-04 at 09:35 +, Shannon Zhao wrote: As the current virtio-mmio only support single irq, so some advanced features such as vhost-net with irqfd are not supported. And the net performance is not the best without vhost-net and irqfd

[PATCH v2] virtio_balloon: Convert vballon kthread into a workqueue

2014-11-12 Thread Petr Mladek
Workqueues have clean and rich API for all basic operations. The code is usually easier and better readable. It can be easily tuned for the given purpose. In many cases, it allows to avoid an extra kernel thread. It helps to stop the growing number of them. Also there will be less

Re: [PATCH v2] virtio_balloon: Convert vballon kthread into a workqueue

2014-11-12 Thread Michael S. Tsirkin
On Wed, Nov 12, 2014 at 02:02:48PM +0100, Petr Mladek wrote: Workqueues have clean and rich API for all basic operations. The code is usually easier and better readable. It can be easily tuned for the given purpose. In many cases, it allows to avoid an extra kernel thread. It helps to stop

Re: kernel BUG at drivers/block/virtio_blk.c:172!

2014-11-12 Thread Jens Axboe
On 11/11/2014 09:42 AM, Ming Lei wrote: The attached patch should fix the problem, and hope it is the last one, :-) Dongsu and Jeff, any of you test this variant? I think this is the last one, at least I hope so as well... -- Jens Axboe ___

Re: [RFC PATCH] virtio-mmio: support for multiple irqs

2014-11-12 Thread Pawel Moll
On Wed, 2014-11-12 at 08:32 +, Shannon Zhao wrote: On 2014/11/11 23:11, Pawel Moll wrote: On Tue, 2014-11-04 at 09:35 +, Shannon Zhao wrote: As the current virtio-mmio only support single irq, so some advanced features such as vhost-net with irqfd are not supported. And the net

Re: [PATCH v2] virtio_balloon: Convert vballon kthread into a workqueue

2014-11-12 Thread Jeff Epler
Trivial typo vballon should be vballoon in subject (and in changelog, leak_ballon should be leak_balloon) Jeff ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: kernel BUG at drivers/block/virtio_blk.c:172!

2014-11-12 Thread Jeff Layton
On Wed, 12 Nov 2014 11:18:32 -0700 Jens Axboe ax...@kernel.dk wrote: On 11/11/2014 09:42 AM, Ming Lei wrote: The attached patch should fix the problem, and hope it is the last one, :-) Dongsu and Jeff, any of you test this variant? I think this is the last one, at least I hope so as

Re: [PATCH net] Revert drivers/net: Disable UFO through virtio in macvtap and tun

2014-11-12 Thread Stefan Hajnoczi
On Tue, Nov 11, 2014 at 05:12:58PM +, Ben Hutchings wrote: This reverts commit 88e0e0e5aa722b193c8758c8b45d041de5316924 for the tap drivers, but leaves UFO disabled in virtio_net. libvirt at least assumes that tap features will never be dropped in new kernel versions, and doing so

Re: [PATCH 2/2] virtio-net: fix buggy features advertised by host

2014-11-12 Thread Jason Wang
On 11/13/2014 01:24 PM, Jason Wang wrote: This patch tries to detect the possible buggy features advertised by host and fix them. One example is current booting virtio-net with only ctrl_vq disabled, qemu may still advertise many features which depends it. This will trigger several BUG()s in

[PATCH 2/2] virtio-net: fix buggy features advertised by host

2014-11-12 Thread Jason Wang
This patch tries to detect the possible buggy features advertised by host and fix them. One example is booting virtio-net with only ctrl_vq disabled, qemu may still advertise many features which depends on it. This will trigger several BUG()s in virtnet_send_command(). This patch utilizes the

[PATCH 1/2] virito: introduce methods of fixing device features

2014-11-12 Thread Jason Wang
Buggy host may advertised buggy host features (a usual case is that host advertise a feature whose dependencies were missed). In this case, driver should detect and disable the buggy features by itself. This patch introduces driver specific fix_features() method which is called just before

Re: [PATCH 2/2] virtio-net: fix buggy features advertised by host

2014-11-12 Thread Wanlong Gao
On 11/13/2014 01:52 PM, Jason Wang wrote: This patch tries to detect the possible buggy features advertised by host and fix them. One example is booting virtio-net with only ctrl_vq disabled, qemu may still advertise many features which depends on it. This will trigger several BUG()s in

Re: [PATCH 2/2] virtio-net: fix buggy features advertised by host

2014-11-12 Thread Jason Wang
On 11/13/2014 02:06 PM, Wanlong Gao wrote: On 11/13/2014 01:52 PM, Jason Wang wrote: This patch tries to detect the possible buggy features advertised by host and fix them. One example is booting virtio-net with only ctrl_vq disabled, qemu may still advertise many features which depends on it.