Re: [Xen-devel] kasan_map_early_shadow() on Xen

2015-03-03 Thread David Vrabel
On 03/03/15 09:40, Luis R. Rodriguez wrote: Andrey, I believe that on Xen we should disable kasan, would like confirmation Why? This is the first of heard of this. from someone on xen-devel though. Here's the thing though -- if true -- I'd like to do it *properly*, where *properly* means

Re: [Xen-devel] kasan_map_early_shadow() on Xen

2015-03-03 Thread Konrad Rzeszutek Wilk
On Tue, Mar 03, 2015 at 06:38:20PM +0300, Andrey Ryabinin wrote: On 03/03/2015 05:16 PM, Konrad Rzeszutek Wilk wrote: On Tue, Mar 03, 2015 at 04:15:06PM +0300, Andrey Ryabinin wrote: On 03/03/2015 12:40 PM, Luis R. Rodriguez wrote: Andrey, I believe that on Xen we should disable kasan,

Re: [Xen-devel] kasan_map_early_shadow() on Xen

2015-03-03 Thread Luis R. Rodriguez
On Tue, Mar 3, 2015 at 2:06 AM, David Vrabel david.vra...@citrix.com wrote: On 03/03/15 09:40, Luis R. Rodriguez wrote: Andrey, I believe that on Xen we should disable kasan, would like confirmation Why? This is the first of heard of this. Andrey chimed in here confirming this. from

Re: [Xen-devel] kasan_map_early_shadow() on Xen

2015-03-03 Thread Andrey Ryabinin
On 03/03/2015 05:16 PM, Konrad Rzeszutek Wilk wrote: On Tue, Mar 03, 2015 at 04:15:06PM +0300, Andrey Ryabinin wrote: On 03/03/2015 12:40 PM, Luis R. Rodriguez wrote: Andrey, I believe that on Xen we should disable kasan, would like confirmation I guess Xen guests won't work with kasan

Re: kasan_map_early_shadow() on Xen

2015-03-03 Thread Andrey Ryabinin
On 03/03/2015 12:40 PM, Luis R. Rodriguez wrote: Andrey, I believe that on Xen we should disable kasan, would like confirmation I guess Xen guests won't work with kasan because Xen guests doesn't setup shadow (kasan_map_early_shadow() is not called in xen guests). Disabling kasan for Xen in

Re: virtio balloon: do not call blocking ops when !TASK_RUNNING

2015-03-03 Thread Rusty Russell
Michael S. Tsirkin m...@redhat.com writes: On Mon, Mar 02, 2015 at 10:37:26AM +1030, Rusty Russell wrote: Thomas Huth th...@linux.vnet.ibm.com writes: On Thu, 26 Feb 2015 11:50:42 +1030 Rusty Russell ru...@rustcorp.com.au wrote: Thomas Huth th...@linux.vnet.ibm.com writes: Hi all,

Re: [PATCH 2/2] virtio-pci: switch to modern accessors for 1.0

2015-03-03 Thread Rusty Russell
Michael S. Tsirkin m...@redhat.com writes: virtio 1.0 config space is in LE format for all devices, use modern wrappers when accessed through the 1.0 BAR. Hmm, I'm not so sure about these patches. It's easy to miss the existence of the _modern variants, and they're 90% the same as the legacy

Re: [PATCH] virtio_console: avoid config access from irq

2015-03-03 Thread Rusty Russell
Amit Shah amit.s...@redhat.com writes: On (Sat) 28 Feb 2015 [18:42:25], Michael S. Tsirkin wrote: when multiport is off, virtio console invokes config access from irq context, config access is blocking on s390. Fix this up by scheduling work from config irq - similar to what we do for

Re: [PATCH] virtio_console: init work unconditionally

2015-03-03 Thread Rusty Russell
Amit Shah amit.s...@redhat.com writes: On (Sat) 28 Feb 2015 [18:41:34], Michael S. Tsirkin wrote: when multiport is off, we don't initialize config work, but we then cancel uninitialized control_work on freeze. Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Amit Shah

Re: [Xen-devel] kasan_map_early_shadow() on Xen

2015-03-03 Thread Konrad Rzeszutek Wilk
On Tue, Mar 03, 2015 at 04:15:06PM +0300, Andrey Ryabinin wrote: On 03/03/2015 12:40 PM, Luis R. Rodriguez wrote: Andrey, I believe that on Xen we should disable kasan, would like confirmation I guess Xen guests won't work with kasan because Xen guests doesn't setup shadow

Re: [Xen-devel] kasan_map_early_shadow() on Xen

2015-03-03 Thread Jan Beulich
On 03.03.15 at 10:40, mcg...@suse.com wrote: Let's go down the rabbit hole for a bit. HAVE_ARCH_KASAN will be selected on x86 when: if X86_64 SPARSEMEM_VMEMMAP Now Xen should not have SPARSEMEM_VMEMMAP Why would that be? Jan ___

kasan_map_early_shadow() on Xen

2015-03-03 Thread Luis R. Rodriguez
Andrey, I believe that on Xen we should disable kasan, would like confirmation from someone on xen-devel though. Here's the thing though -- if true -- I'd like to do it *properly*, where *properly* means addressing a bit of architecture. A simple Kconfig slap seems rather reactive. I'd like to