Re: [Xen-devel] kasan_map_early_shadow() on Xen

2015-03-04 Thread Andrey Ryabinin
On 03/03/2015 07:02 PM, Konrad Rzeszutek Wilk wrote: On Tue, Mar 03, 2015 at 06:38:20PM +0300, Andrey Ryabinin wrote: On 03/03/2015 05:16 PM, Konrad Rzeszutek Wilk wrote: On Tue, Mar 03, 2015 at 04:15:06PM +0300, Andrey Ryabinin wrote: On 03/03/2015 12:40 PM, Luis R. Rodriguez wrote: Andrey,

Re: [Xen-devel] kasan_map_early_shadow() on Xen

2015-03-04 Thread Juergen Gross
On 03/03/2015 08:20 PM, Luis R. Rodriguez wrote: On Tue, Mar 3, 2015 at 2:06 AM, David Vrabel david.vra...@citrix.com wrote: On 03/03/15 09:40, Luis R. Rodriguez wrote: Andrey, I believe that on Xen we should disable kasan, would like confirmation Why? This is the first of heard of this.

Re: [PATCH] virtio_balloon: set DRIVER_OK before using device

2015-03-04 Thread Rusty Russell
Michael S. Tsirkin m...@redhat.com writes: virtio spec requires that all drivers set DRIVER_OK before using devices. While balloon isn't yet included in the virtio 1 spec, previous spec versions also required this. virtio balloon might violate this rule: probe calls kthread_run before

Re: [PATCH 2/2] virtio-pci: switch to modern accessors for 1.0

2015-03-04 Thread Rusty Russell
Michael S. Tsirkin m...@redhat.com writes: On Wed, Mar 04, 2015 at 11:06:08AM +1030, Rusty Russell wrote: Michael S. Tsirkin m...@redhat.com writes: virtio 1.0 config space is in LE format for all devices, use modern wrappers when accessed through the 1.0 BAR. Hmm, I'm not so sure about

Re: [Xen-devel] kasan_map_early_shadow() on Xen

2015-03-04 Thread Luis R. Rodriguez
On Wed, Mar 4, 2015 at 6:36 AM, Andrey Ryabinin a.ryabi...@samsung.com wrote: On 03/03/2015 07:02 PM, Konrad Rzeszutek Wilk wrote: If it is like that - then just using what had to be implemented for the stack protection as a template ought to pave most of the work? Probably. I think I could

Re: [PATCH 2/2] virtio-pci: switch to modern accessors for 1.0

2015-03-04 Thread Michael S. Tsirkin
On Wed, Mar 04, 2015 at 11:06:08AM +1030, Rusty Russell wrote: Michael S. Tsirkin m...@redhat.com writes: virtio 1.0 config space is in LE format for all devices, use modern wrappers when accessed through the 1.0 BAR. Hmm, I'm not so sure about these patches. It's easy to miss the

Re: [PATCH] virtio_console: avoid config access from irq

2015-03-04 Thread Michael S. Tsirkin
On Wed, Mar 04, 2015 at 11:08:18AM +1030, Rusty Russell wrote: Amit Shah amit.s...@redhat.com writes: On (Sat) 28 Feb 2015 [18:42:25], Michael S. Tsirkin wrote: when multiport is off, virtio console invokes config access from irq context, config access is blocking on s390. Fix this up by

Re: virtio balloon: do not call blocking ops when !TASK_RUNNING

2015-03-04 Thread Michael S. Tsirkin
On Wed, Mar 04, 2015 at 04:44:54PM +1030, Rusty Russell wrote: Michael S. Tsirkin m...@redhat.com writes: On Mon, Mar 02, 2015 at 10:37:26AM +1030, Rusty Russell wrote: Thomas Huth th...@linux.vnet.ibm.com writes: On Thu, 26 Feb 2015 11:50:42 +1030 Rusty Russell ru...@rustcorp.com.au

[PATCH] virtio_balloon: set DRIVER_OK before using device

2015-03-04 Thread Michael S. Tsirkin
virtio spec requires that all drivers set DRIVER_OK before using devices. While balloon isn't yet included in the virtio 1 spec, previous spec versions also required this. virtio balloon might violate this rule: probe calls kthread_run before setting DRIVER_OK, which might run immediately and