Re: [PATCH 0/6] virtio_balloon: virtio 1 support

2015-03-31 Thread Cornelia Huck
On Mon, 30 Mar 2015 19:37:08 +0200 "Michael S. Tsirkin" wrote: > Virtio 1.0 doesn't include a modern balloon device. > At some point we'll likely define an incompatible interface with a different > ID. But for now, it's not a big change to support a transitional balloon > device: this has the ad

Re: [PATCH 0/6] virtio_balloon: virtio 1 support

2015-03-31 Thread Michael S. Tsirkin
On Tue, Mar 31, 2015 at 10:46:18AM +0200, Cornelia Huck wrote: > On Mon, 30 Mar 2015 19:37:08 +0200 > "Michael S. Tsirkin" wrote: > > > Virtio 1.0 doesn't include a modern balloon device. > > At some point we'll likely define an incompatible interface with a different > > ID. But for now, it's n

[PATCH] virtio: drop a useless config read

2015-03-31 Thread Michael S. Tsirkin
commit d71de9ec6ba806104439d3a669befda84757b5af "virtio: core support for config generation" fixed reading up 64 bit values, adding generation checks for such reads. By mistake, it left an explicit get call in place as well. the result is that the value is read twice, the first result is disca

Re: [PATCH 4/6] virtio_mmio: support non-legacy balloon devices

2015-03-31 Thread Pawel Moll
On Mon, 2015-03-30 at 18:37 +0100, Michael S. Tsirkin wrote: > virtio_device_is_legacy_only is always false now, > drop the test from virtio mmio. > > Signed-off-by: Michael S. Tsirkin Slightly ironic ack ;-) after all the battle you fought for this: Acked-by: Pawel Moll Thanks! Pawel _

Re: [PATCH] virtio: drop a useless config read

2015-03-31 Thread Cornelia Huck
On Tue, 31 Mar 2015 13:55:42 +0200 "Michael S. Tsirkin" wrote: > commit d71de9ec6ba806104439d3a669befda84757b5af > "virtio: core support for config generation" > fixed reading up 64 bit values, adding generation > checks for such reads. > > By mistake, it left an explicit get call in place >

[PATCH] virtio_config: reorder functions

2015-03-31 Thread Michael S. Tsirkin
This simply reorders functions in virtio_config so width access wrapper helpers are all together. Drops an extra empty line while we are at it. Signed-off-by: Michael S. Tsirkin --- include/linux/virtio_config.h | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/

Re: [PATCH 4/6] virtio_mmio: support non-legacy balloon devices

2015-03-31 Thread Michael S. Tsirkin
On Tue, Mar 31, 2015 at 01:31:35PM +0100, Pawel Moll wrote: > On Mon, 2015-03-30 at 18:37 +0100, Michael S. Tsirkin wrote: > > virtio_device_is_legacy_only is always false now, > > drop the test from virtio mmio. > > > > Signed-off-by: Michael S. Tsirkin > > Slightly ironic ack ;-) after all the

[PATCH v2 1/6] virtio_balloon: transitional interface

2015-03-31 Thread Michael S. Tsirkin
Virtio 1.0 doesn't include a modern balloon device. But it's not a big change to support a transitional balloon device: this has the advantage of supporting existing drivers, transparently. Signed-off-by: Michael S. Tsirkin --- include/uapi/linux/virtio_balloon.h | 11 +-- drivers/virtio

[PATCH v2 2/6] virtio: balloon might not be a legacy device

2015-03-31 Thread Michael S. Tsirkin
We added transitional device support to balloon driver, so we don't need to black-list it in core anymore. Signed-off-by: Michael S. Tsirkin --- drivers/virtio/virtio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c index 5ce

[PATCH v2 5/6] virtio_pci: support non-legacy balloon devices

2015-03-31 Thread Michael S. Tsirkin
virtio_device_is_legacy_only is always false now, drop the test from virtio pci. Signed-off-by: Michael S. Tsirkin --- drivers/virtio/virtio_pci_modern.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/virtio/virtio_pci_modern.c b/drivers/virtio/virtio_pci_modern.c index 2aa38e5..

[PATCH v2 6/6] virtio: drop virtio_device_is_legacy_only

2015-03-31 Thread Michael S. Tsirkin
virtio_device_is_legacy_only is now unused, drop it from core. Signed-off-by: Michael S. Tsirkin --- include/linux/virtio.h | 2 -- drivers/virtio/virtio.c | 6 -- 2 files changed, 8 deletions(-) diff --git a/include/linux/virtio.h b/include/linux/virtio.h index 28f0e65..8f4d4bf 100644 ---

[PATCH v2 4/6] virtio_mmio: support non-legacy balloon devices

2015-03-31 Thread Michael S. Tsirkin
virtio_device_is_legacy_only is always false now, drop the test from virtio mmio. Signed-off-by: Michael S. Tsirkin Acked-by: Pawel Moll --- drivers/virtio/virtio_mmio.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c index

[PATCH] add generic callbacks into compaction

2015-03-31 Thread Gioh Kim
I sent a patch about page allocation for less fragmentation. http://permalink.gmane.org/gmane.linux.kernel.mm/130599 It proposes a page allocator allocates pages in the same pageblock for the drivers to move their unmovable pages. Some drivers which comsumes many pages and increases system fragme

Re: [PATCH] virtio: drop a useless config read

2015-03-31 Thread Rusty Russell
Cornelia Huck writes: > On Tue, 31 Mar 2015 13:55:42 +0200 > "Michael S. Tsirkin" wrote: > >> commit d71de9ec6ba806104439d3a669befda84757b5af >> "virtio: core support for config generation" >> fixed reading up 64 bit values, adding generation >> checks for such reads. >> >> By mistake, it le

Re: [PATCH v2 1/6] virtio_balloon: transitional interface

2015-03-31 Thread Rusty Russell
"Michael S. Tsirkin" writes: > Virtio 1.0 doesn't include a modern balloon device. > But it's not a big change to support a transitional > balloon device: this has the advantage of supporting > existing drivers, transparently. You decided to fix the packed struct... > diff --git a/drivers/virtio