Re: [PATCH v3 11/16] zsmalloc: separate free_zspage from putback_zspage

2016-04-17 Thread Sergey Senozhatsky
Hello Minchan, On (03/30/16 16:12), Minchan Kim wrote: [..] > @@ -1835,23 +1827,31 @@ static void __zs_compact(struct zs_pool *pool, struct > size_class *class) > if (!migrate_zspage(pool, class, &cc)) > break; > > - putbac

Re: [PATCH v3 10/16] zsmalloc: factor page chain functionality out

2016-04-17 Thread Sergey Senozhatsky
Hello, On (03/30/16 16:12), Minchan Kim wrote: > @@ -1421,7 +1434,6 @@ static unsigned long obj_malloc(struct size_class > *class, > unsigned long m_offset; > void *vaddr; > > - handle |= OBJ_ALLOCATED_TAG; a nitpick, why did you replace this ALLOCATED_TAG assignment with 2 'ha