Re: [RFC PATCH] vring: Force use of DMA API for ARM-based systems

2017-01-06 Thread Andy Lutomirski
On Fri, Jan 6, 2017 at 10:32 AM, Robin Murphy wrote: > On 06/01/17 17:48, Jean-Philippe Brucker wrote: >> Hi Will, >> >> On 20/12/16 15:14, Will Deacon wrote: >>> Booting Linux on an ARM fastmodel containing an SMMU emulation results >>> in an unexpected I/O page fault from the legacy virtio-blk P

Re: [PATCH V4 net-next 1/3] vhost: better detection of available buffers

2017-01-06 Thread Michael S. Tsirkin
On Fri, Jan 06, 2017 at 10:13:15AM +0800, Jason Wang wrote: > This patch tries to do several tweaks on vhost_vq_avail_empty() for a > better performance: > > - check cached avail index first which could avoid userspace memory access. > - using unlikely() for the failure of userspace access > - che

Re: [PATCH V4 net-next 3/3] tun: rx batching

2017-01-06 Thread Michael S. Tsirkin
On Fri, Jan 06, 2017 at 10:13:17AM +0800, Jason Wang wrote: > We can only process 1 packet at one time during sendmsg(). This often > lead bad cache utilization under heavy load. So this patch tries to do > some batching during rx before submitting them to host network > stack. This is done through

Re: [RFC PATCH] vring: Force use of DMA API for ARM-based systems

2017-01-06 Thread Robin Murphy
On 06/01/17 17:48, Jean-Philippe Brucker wrote: > Hi Will, > > On 20/12/16 15:14, Will Deacon wrote: >> Booting Linux on an ARM fastmodel containing an SMMU emulation results >> in an unexpected I/O page fault from the legacy virtio-blk PCI device: >> >> [1.211721] arm-smmu-v3 2b40.smmu: e

Re: [PATCH] virtio_blk: avoid DMA to stack for the sense buffer

2017-01-06 Thread 王金浦
Hi Christoph, 2017-01-04 6:25 GMT+01:00 Christoph Hellwig : > Most users of BLOCK_PC requests allocate the sense buffer on the stack, > so to avoid DMA to the stack copy them to a field in the heap allocated > virtblk_req structure. Without that any attempt at SCSI passthrough I/O, > including th

Re: [PATCH] virtio_blk: avoid DMA to stack for the sense buffer

2017-01-06 Thread 王金浦
2017-01-05 10:57 GMT+01:00 Christoph Hellwig : > On Wed, Jan 04, 2017 at 04:47:03PM +0100, 王金浦 wrote: >> This sounds scary. >> Could you share how to reproduce it, this should go into stable if >> it's the case. > > Step 1: Build your kernel with CONFIG_VMAP_STACK=y > Step 2: issue a SG_IO ioctl, e

[PATCH] net: Use kmemdup instead of kmalloc and memcpy

2017-01-06 Thread Shyam Saini
when some other buffer is immediately copied into allocated region. Replace calls to kmalloc followed by a memcpy with a direct call to kmemdup. Signed-off-by: Shyam Saini --- drivers/net/virtio_net.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/virtio_net.c

Re: [PATCH net 1/9] virtio-net: remove the warning before XDP linearizing

2017-01-06 Thread Daniel Borkmann
Hi Jason, On 12/23/2016 03:37 PM, Jason Wang wrote: Since we use EWMA to estimate the size of rx buffer. When rx buffer size is underestimated, it's usual to have a packet with more than one buffers. Consider this is not a bug, remove the warning and correct the comment before XDP linearizing.

Re: [PATCH 5/8] linux: drop __bitwise__ everywhere

2017-01-06 Thread Luca Coelho
On Thu, 2016-12-15 at 07:15 +0200, Michael S. Tsirkin wrote: > __bitwise__ used to mean "yes, please enable sparse checks > unconditionally", but now that we dropped __CHECK_ENDIAN__ > __bitwise is exactly the same. > There aren't many users, replace it by __bitwise everywhere. > > Signed-off-by:

Re: [RFC PATCH] vring: Force use of DMA API for ARM-based systems

2017-01-06 Thread Marc Zyngier
On 20/12/16 15:14, Will Deacon wrote: > Booting Linux on an ARM fastmodel containing an SMMU emulation results > in an unexpected I/O page fault from the legacy virtio-blk PCI device: > > [1.211721] arm-smmu-v3 2b40.smmu: event 0x10 received: > [1.211800] arm-smmu-v3 2b40.smmu:

Re: [RFC PATCH] vring: Force use of DMA API for ARM-based systems

2017-01-06 Thread Jean-Philippe Brucker
Hi Will, On 20/12/16 15:14, Will Deacon wrote: > Booting Linux on an ARM fastmodel containing an SMMU emulation results > in an unexpected I/O page fault from the legacy virtio-blk PCI device: > > [1.211721] arm-smmu-v3 2b40.smmu: event 0x10 received: > [1.211800] arm-smmu-v3 2b40

Re: [PATCH net-next] net: make ndo_get_stats64 a void function

2017-01-06 Thread kbuild test robot
Hi Stephen, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Stephen-Hemminger/net-make-ndo_get_stats64-a-void-function/20170106-160123 config: xtensa-allmodconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 4.9.0 reproduce: wget

Re: [PATCH net-next] net: make ndo_get_stats64 a void function

2017-01-06 Thread kbuild test robot
Hi Stephen, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Stephen-Hemminger/net-make-ndo_get_stats64-a-void-function/20170106-160123 config: x86_64-acpi-redef (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce