Re: [PATCH net-next] virtio-net: invoke zerocopy callback on xmit path if no tx napi

2017-08-29 Thread Willem de Bruijn
On Tue, Aug 29, 2017 at 9:45 PM, Jason Wang wrote: > > > On 2017年08月30日 03:35, Willem de Bruijn wrote: >> >> On Fri, Aug 25, 2017 at 9:03 PM, Willem de Bruijn >> wrote: >>> >>> On Fri, Aug 25, 2017 at 7:32 PM, Michael S. Tsirkin

Re: [PATCH net-next] virtio-net: invoke zerocopy callback on xmit path if no tx napi

2017-08-29 Thread Jason Wang
On 2017年08月30日 03:35, Willem de Bruijn wrote: On Fri, Aug 25, 2017 at 9:03 PM, Willem de Bruijn wrote: On Fri, Aug 25, 2017 at 7:32 PM, Michael S. Tsirkin wrote: On Fri, Aug 25, 2017 at 06:44:36PM -0400, Willem de Bruijn wrote: We don't

Re: [PATCH net-next] virtio-net: invoke zerocopy callback on xmit path if no tx napi

2017-08-29 Thread Willem de Bruijn
On Tue, Aug 29, 2017 at 4:40 PM, Michael S. Tsirkin wrote: > On Tue, Aug 29, 2017 at 03:53:08PM -0400, Willem de Bruijn wrote: >> On Tue, Aug 29, 2017 at 3:42 PM, Michael S. Tsirkin wrote: >> > On Tue, Aug 29, 2017 at 03:35:38PM -0400, Willem de Bruijn wrote: >>

Re: [PATCH RFC 2/2] virtio_net: enable probing for NEEDS_RESET support

2017-08-29 Thread Michael S. Tsirkin
On Tue, Aug 29, 2017 at 05:02:29PM -0400, Willem de Bruijn wrote: > + virtio-dev > > On Tue, Aug 29, 2017 at 4:38 PM, Michael S. Tsirkin wrote: > > On Tue, Aug 29, 2017 at 04:27:41PM -0400, Willem de Bruijn wrote: > >> On Tue, Aug 29, 2017 at 4:16 PM, Michael S. Tsirkin

Re: [PATCH RFC 2/2] virtio_net: enable probing for NEEDS_RESET support

2017-08-29 Thread Willem de Bruijn
+ virtio-dev On Tue, Aug 29, 2017 at 4:38 PM, Michael S. Tsirkin wrote: > On Tue, Aug 29, 2017 at 04:27:41PM -0400, Willem de Bruijn wrote: >> On Tue, Aug 29, 2017 at 4:16 PM, Michael S. Tsirkin wrote: >> > On Tue, Aug 29, 2017 at 04:07:59PM -0400, Willem de

Re: [PATCH net-next] virtio-net: invoke zerocopy callback on xmit path if no tx napi

2017-08-29 Thread Michael S. Tsirkin
On Tue, Aug 29, 2017 at 03:53:08PM -0400, Willem de Bruijn wrote: > On Tue, Aug 29, 2017 at 3:42 PM, Michael S. Tsirkin wrote: > > On Tue, Aug 29, 2017 at 03:35:38PM -0400, Willem de Bruijn wrote: > >> By the way, I have had an unrelated patch outstanding for a while > >> to have

Re: [PATCH RFC 2/2] virtio_net: enable probing for NEEDS_RESET support

2017-08-29 Thread Michael S. Tsirkin
On Tue, Aug 29, 2017 at 04:27:41PM -0400, Willem de Bruijn wrote: > On Tue, Aug 29, 2017 at 4:16 PM, Michael S. Tsirkin wrote: > > On Tue, Aug 29, 2017 at 04:07:59PM -0400, Willem de Bruijn wrote: > >> From: Willem de Bruijn > >> > >> Implement a mechanism to

Re: [PATCH RFC 2/2] virtio_net: enable probing for NEEDS_RESET support

2017-08-29 Thread Willem de Bruijn
On Tue, Aug 29, 2017 at 4:16 PM, Michael S. Tsirkin wrote: > On Tue, Aug 29, 2017 at 04:07:59PM -0400, Willem de Bruijn wrote: >> From: Willem de Bruijn >> >> Implement a mechanism to signal that a virtio device implements the >> VIRTIO_CONFIG_S_NEEDS_RESET

Re: [PATCH RFC 1/2] virtio_net: implement VIRTIO_CONFIG_S_NEEDS_RESET

2017-08-29 Thread Michael S. Tsirkin
On Tue, Aug 29, 2017 at 04:07:58PM -0400, Willem de Bruijn wrote: > From: Willem de Bruijn > > Implement the reset communication request defined in the VIRTIO 1.0 > specification and introduces in Linux in commit c00bbcf862896 ("virtio: > add VIRTIO_CONFIG_S_NEEDS_RESET

Re: [PATCH RFC 2/2] virtio_net: enable probing for NEEDS_RESET support

2017-08-29 Thread Michael S. Tsirkin
On Tue, Aug 29, 2017 at 04:07:59PM -0400, Willem de Bruijn wrote: > From: Willem de Bruijn > > Implement a mechanism to signal that a virtio device implements the > VIRTIO_CONFIG_S_NEEDS_RESET command. > > Testing for VIRTIO_CONFIG_S_NEEDS_RESET support by issuing the

[PATCH RFC 0/2] virtio-net: implement reset request

2017-08-29 Thread Willem de Bruijn
From: Willem de Bruijn Implement VIRTIO_CONFIG_S_NEEDS_RESET (patch 1) and add a feature bit to signal support (patch 2) Further details in the individual patches. Willem de Bruijn (2): virtio_net: implement VIRTIO_CONFIG_S_NEEDS_RESET virtio_net: enable probing for

[PATCH RFC 1/2] virtio_net: implement VIRTIO_CONFIG_S_NEEDS_RESET

2017-08-29 Thread Willem de Bruijn
From: Willem de Bruijn Implement the reset communication request defined in the VIRTIO 1.0 specification and introduces in Linux in commit c00bbcf862896 ("virtio: add VIRTIO_CONFIG_S_NEEDS_RESET device status bit"). Since that patch, the virtio-net driver has added a

[PATCH RFC 2/2] virtio_net: enable probing for NEEDS_RESET support

2017-08-29 Thread Willem de Bruijn
From: Willem de Bruijn Implement a mechanism to signal that a virtio device implements the VIRTIO_CONFIG_S_NEEDS_RESET command. Testing for VIRTIO_CONFIG_S_NEEDS_RESET support by issuing the request and verifying the reset state would require an expensive state change. To

Re: [PATCH net-next] virtio-net: invoke zerocopy callback on xmit path if no tx napi

2017-08-29 Thread Willem de Bruijn
On Tue, Aug 29, 2017 at 3:42 PM, Michael S. Tsirkin wrote: > On Tue, Aug 29, 2017 at 03:35:38PM -0400, Willem de Bruijn wrote: >> By the way, I have had an unrelated patch outstanding for a while >> to have virtio-net support the VIRTIO_CONFIG_S_NEEDS_RESET >> command. Will send

Re: [PATCH net-next] virtio-net: invoke zerocopy callback on xmit path if no tx napi

2017-08-29 Thread Michael S. Tsirkin
On Tue, Aug 29, 2017 at 03:35:38PM -0400, Willem de Bruijn wrote: > By the way, I have had an unrelated patch outstanding for a while > to have virtio-net support the VIRTIO_CONFIG_S_NEEDS_RESET > command. Will send that as RFC. Oh nice. One needs to be careful about locking there which is why no

Re: [RFC PATCH v2 1/7] x86/paravirt: Add pv_idle_ops to paravirt ops

2017-08-29 Thread Konrad Rzeszutek Wilk
On Tue, Aug 29, 2017 at 11:46:35AM +, Yang Zhang wrote: > So far, pv_idle_ops.poll is the only ops for pv_idle. .poll is called in > idle path which will polling for a while before we enter the real idle > state. > > In virtualization, idle path includes several heavy operations > includes

Re: [Qemu-devel] [RFC] Buffers/caches in VirtIO Balloon driver stats

2017-08-29 Thread Wei Wang
On 08/29/2017 05:57 PM, Stefan Hajnoczi wrote: On Sun, Aug 27, 2017 at 11:30:33PM +0200, Tomáš Golembiovský wrote: Hi, I have CCed the relevant mailing lists and people most recently involved in virtio-balloon discussions. Hopefully this will help get the right people to see your questions.

[RFC PATCH v2 5/7] Documentation: Add three sysctls for smart idle poll

2017-08-29 Thread Yang Zhang
To reduce the cost of poll, we introduce three sysctl to control the poll time. Signed-off-by: Yang Zhang Signed-off-by: Quan Xu Cc: Jonathan Corbet Cc: Jeremy Fitzhardinge Cc: Chris Wright Cc:

[RFC PATCH v2 4/7] x86/paravirt: Add update in x86/paravirt pv_idle_ops

2017-08-29 Thread Yang Zhang
.update is used to adjust the next poll time. Signed-off-by: Yang Zhang Signed-off-by: Quan Xu Cc: Jeremy Fitzhardinge Cc: Chris Wright Cc: Alok Kataria Cc: Rusty Russell

[RFC PATCH v2 1/7] x86/paravirt: Add pv_idle_ops to paravirt ops

2017-08-29 Thread Yang Zhang
So far, pv_idle_ops.poll is the only ops for pv_idle. .poll is called in idle path which will polling for a while before we enter the real idle state. In virtualization, idle path includes several heavy operations includes timer access(LAPIC timer or TSC deadline timer) which will hurt