Re: [PATCH 1/3] vhost: fix skb leak in handle_rx()

2017-12-03 Thread Jason Wang
On 2017年12月01日 22:37, Michael S. Tsirkin wrote: On Fri, Dec 01, 2017 at 03:11:05PM +0800, Jason Wang wrote: On 2017年12月01日 13:54, w...@redhat.com wrote: From: Wei Xu Matthew found a roughly 40% tcp throughput regression with commit c67df11f(vhost_net: try batch dequing

Re: [PATCH v18 10/10] virtio-balloon: don't report free pages when page poisoning is enabled

2017-12-03 Thread Wei Wang
On 12/01/2017 11:49 PM, Michael S. Tsirkin wrote: On Wed, Nov 29, 2017 at 09:55:26PM +0800, Wei Wang wrote: The guest free pages should not be discarded by the live migration thread when page poisoning is enabled with PAGE_POISONING_NO_SANITY=n, because skipping the transfer of such poisoned

Re: [PATCH v18 07/10] virtio-balloon: VIRTIO_BALLOON_F_SG

2017-12-03 Thread Wei Wang
On 12/01/2017 11:38 PM, Michael S. Tsirkin wrote: On Wed, Nov 29, 2017 at 09:55:23PM +0800, Wei Wang wrote: +static void send_one_desc(struct virtio_balloon *vb, + struct virtqueue *vq, + uint64_t addr, + uint32_t len, +

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-12-03 Thread Stephen Hemminger
On Sun, 3 Dec 2017 11:14:37 +0200 achiad shochat wrote: > On 3 December 2017 at 07:05, Michael S. Tsirkin wrote: > > On Fri, Dec 01, 2017 at 12:08:59PM -0800, Shannon Nelson wrote: > >> On 11/30/2017 6:11 AM, Michael S. Tsirkin wrote: > >> > On

Re: Memory corruption in powerpc guests with virtio_balloon (was Re: [PATCH v3] virtio_balloon: fix deadlock on OOM)

2017-12-03 Thread Michael Ellerman
"Michael S. Tsirkin" writes: > On Fri, Dec 01, 2017 at 11:31:08PM +1100, Michael Ellerman wrote: >> "Michael S. Tsirkin" writes: >> >> > fill_balloon doing memory allocations under balloon_lock >> > can cause a deadlock when leak_balloon is called from >> >

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-12-03 Thread achiad shochat
On 3 December 2017 at 07:05, Michael S. Tsirkin wrote: > On Fri, Dec 01, 2017 at 12:08:59PM -0800, Shannon Nelson wrote: >> On 11/30/2017 6:11 AM, Michael S. Tsirkin wrote: >> > On Thu, Nov 30, 2017 at 10:08:45AM +0200, achiad shochat wrote: >> > > Re. problem #2: >> > > Indeed