RE: [PATCH v6] virtio_blk: add DISCARD and WRIET ZEROES commands support

2018-06-10 Thread Liu, Changpeng
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > Sent: Friday, June 8, 2018 6:20 PM > To: Liu, Changpeng > Cc: virtualization@lists.linux-foundation.org; cav...@redhat.com; > jasow...@redhat.com; pbonz...@redhat.com; Wang, Wei W > > Subject: Re: [PATCH v6] vi

Re: [RFC V2] virtio: Add platform specific DMA API translation for virito devices

2018-06-10 Thread Benjamin Herrenschmidt
On Mon, 2018-06-11 at 06:28 +0300, Michael S. Tsirkin wrote: > > > However if the administrator > > ignores/forgets/deliberatey-decides/is-constrained to NOT enable the > > flag, virtio will not be able to pass control to the DMA ops associated > > with the virtio devices. Which means, we have no

Re: [RFC V2] virtio: Add platform specific DMA API translation for virito devices

2018-06-10 Thread Benjamin Herrenschmidt
On Sun, 2018-06-10 at 19:39 -0700, Ram Pai wrote: > > However if the administrator > ignores/forgets/deliberatey-decides/is-constrained to NOT enable the > flag, virtio will not be able to pass control to the DMA ops associated > with the virtio devices. Which means, we have no opportunity to shar

Re: [RFC V2] virtio: Add platform specific DMA API translation for virito devices

2018-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2018 at 07:39:09PM -0700, Ram Pai wrote: > On Thu, Jun 07, 2018 at 07:28:35PM +0300, Michael S. Tsirkin wrote: > > On Wed, Jun 06, 2018 at 10:23:06PM -0700, Christoph Hellwig wrote: > > > On Thu, May 31, 2018 at 08:43:58PM +0300, Michael S. Tsirkin wrote: > > > > Pls work on a long

Re: [PATCH net] vhost_net: remove VHOST_NET_F_VIRTIO_NET_HDR support

2018-06-10 Thread Michael S. Tsirkin
On Mon, Jun 11, 2018 at 10:29:36AM +0800, Jason Wang wrote: > > > On 2018年06月11日 10:12, Michael S. Tsirkin wrote: > > On Fri, Jun 08, 2018 at 01:07:09PM +0800, Jason Wang wrote: > > > > > > On 2018年06月08日 12:46, Michael S. Tsirkin wrote: > > > > On Fri, Jun 08, 2018 at 11:50:42AM +0800, Jason Wa

Re: [PATCH net] vhost_net: remove VHOST_NET_F_VIRTIO_NET_HDR support

2018-06-10 Thread Jason Wang
On 2018年06月11日 10:12, Michael S. Tsirkin wrote: On Fri, Jun 08, 2018 at 01:07:09PM +0800, Jason Wang wrote: On 2018年06月08日 12:46, Michael S. Tsirkin wrote: On Fri, Jun 08, 2018 at 11:50:42AM +0800, Jason Wang wrote: This feature bit is duplicated with VIRTIO_F_ANY_LAYOUT, this means if a us

Re: [PATCH net] vhost_net: remove VHOST_NET_F_VIRTIO_NET_HDR support

2018-06-10 Thread Michael S. Tsirkin
On Fri, Jun 08, 2018 at 01:07:09PM +0800, Jason Wang wrote: > > > On 2018年06月08日 12:46, Michael S. Tsirkin wrote: > > On Fri, Jun 08, 2018 at 11:50:42AM +0800, Jason Wang wrote: > > > This feature bit is duplicated with VIRTIO_F_ANY_LAYOUT, this means if > > > a userpsace want to enable VRITIO_F_

Re: [PATCH net] vhost_net: remove VHOST_NET_F_VIRTIO_NET_HDR support

2018-06-10 Thread David Miller
From: Jason Wang Date: Fri, 8 Jun 2018 11:50:42 +0800 > This feature bit is duplicated with VIRTIO_F_ANY_LAYOUT, this means if > a userpsace want to enable VRITIO_F_ANY_LAYOUT, > VHOST_NET_F_VIRTIO_NET_HDR will be implied too. This is wrong and will > break networking. Fixing this by safely remo