Re: [PATCH v2 00/11] x86/paravirt: several cleanups

2018-08-24 Thread Peter Zijlstra
On Fri, Aug 24, 2018 at 03:52:55PM +0200, Juergen Gross wrote: > Ping? Looking good; although I messed it up a little bit by adding a new paravirt function. Thanks for doing this! ___ Virtualization mailing list Virtualization@lists.linux-foundation.org

Re: [PATCH v2 10/11] x86/paravirt: move the Xen-only pv_mmu_ops under the PARAVIRT_XXL umbrella

2018-08-24 Thread Juergen Gross
On 24/08/18 16:12, Peter Zijlstra wrote: > On Mon, Aug 13, 2018 at 09:37:38AM +0200, Juergen Gross wrote: >> struct pv_mmu_ops { >> +/* TLB operations */ >> +void (*flush_tlb_user)(void); >> +void (*flush_tlb_kernel)(void); >> +void (*flush_tlb_one_user)(unsigned long addr); >> +

Re: [PATCH v2 09/11] x86/paravirt: move the Xen-only pv_irq_ops under the PARAVIRT_XXL umbrella

2018-08-24 Thread Juergen Gross
On 24/08/18 16:10, Peter Zijlstra wrote: > On Mon, Aug 13, 2018 at 09:37:37AM +0200, Juergen Gross wrote: >> Some of the paravirt ops defined in pv_irq_ops are for Xen PV guests >> only. Define them only if CONFIG_PARAVIRT_XXL is set. >> diff --git a/arch/x86/include/asm/paravirt_types.h >> b/arch

Re: [PATCH v2 10/11] x86/paravirt: move the Xen-only pv_mmu_ops under the PARAVIRT_XXL umbrella

2018-08-24 Thread Peter Zijlstra
On Mon, Aug 13, 2018 at 09:37:38AM +0200, Juergen Gross wrote: > struct pv_mmu_ops { > + /* TLB operations */ > + void (*flush_tlb_user)(void); > + void (*flush_tlb_kernel)(void); > + void (*flush_tlb_one_user)(unsigned long addr); > + void (*flush_tlb_others)(const struct cpum

Re: [PATCH v2 09/11] x86/paravirt: move the Xen-only pv_irq_ops under the PARAVIRT_XXL umbrella

2018-08-24 Thread Peter Zijlstra
On Mon, Aug 13, 2018 at 09:37:37AM +0200, Juergen Gross wrote: > Some of the paravirt ops defined in pv_irq_ops are for Xen PV guests > only. Define them only if CONFIG_PARAVIRT_XXL is set. > diff --git a/arch/x86/include/asm/paravirt_types.h > b/arch/x86/include/asm/paravirt_types.h > index e652e

Re: [PATCH v2 03/11] x86/paravirt: remove clobbers from struct paravirt_patch_site

2018-08-24 Thread Thomas Gleixner
On Mon, 13 Aug 2018, Juergen Gross wrote: > There is no need any longer to store the clobbers in struct > paravirt_patch_site. Remove clobbers from the struct and from the > related macros. > > While at it fix some lines longer than 80 characters. > > Signed-off-by: Juergen Gross Reviewed-by:

Re: [PATCH v2 02/11] x86/paravirt: remove clobbers parameter from paravirt patch functions

2018-08-24 Thread Thomas Gleixner
On Mon, 13 Aug 2018, Juergen Gross wrote: > The clobbers parameter from paravirt_patch_default() et al isn't used > any longer. Remove it. > > Signed-off-by: Juergen Gross Reviewed-by: Thomas Gleixner ___ Virtualization mailing list Virtualization@li

Re: [PATCH v2 01/11] x86/paravirt: make paravirt_patch_call() and paravirt_patch_jmp() static

2018-08-24 Thread Thomas Gleixner
On Mon, 13 Aug 2018, Juergen Gross wrote: > paravirt_patch_call() and paravirt_patch_jmp() are used in paravirt.c > only. Convert them to static. > > Signed-off-by: Juergen Gross Reviewed-by: Thomas Gleixner ___ Virtualization mailing list Virtualiza

Re: [PATCH v2 00/11] x86/paravirt: several cleanups

2018-08-24 Thread Juergen Gross
On 13/08/18 09:37, Juergen Gross wrote: > This series removes some no longer needed stuff from paravirt > infrastructure and puts large quantities of paravirt ops under a new > config option PARAVIRT_XXL which is selected by XEN_PV only. > > A pvops kernel without XEN_PV being configured is about

Re: [PATCH net] vhost: correctly check the iova range when waking virtqueue

2018-08-24 Thread Michael S. Tsirkin
On Fri, Aug 24, 2018 at 04:53:13PM +0800, Jason Wang wrote: > We don't wakeup the virtqueue if the first byte of pending iova range > is the last byte of the range we just got updated. This will lead a > virtqueue to wait for IOTLB updating forever. Fixing by correct the > check and wake up the vir

Re: [PATCH net] vhost: correctly check the iova range when waking virtqueue

2018-08-24 Thread Peter Xu
On Fri, Aug 24, 2018 at 04:53:13PM +0800, Jason Wang wrote: > We don't wakeup the virtqueue if the first byte of pending iova range > is the last byte of the range we just got updated. This will lead a > virtqueue to wait for IOTLB updating forever. Fixing by correct the > check and wake up the vir

[PATCH net] vhost: correctly check the iova range when waking virtqueue

2018-08-24 Thread Jason Wang
We don't wakeup the virtqueue if the first byte of pending iova range is the last byte of the range we just got updated. This will lead a virtqueue to wait for IOTLB updating forever. Fixing by correct the check and wake up the virtqueue in this case. Fixes: 6b1e6cc7855b ("vhost: new device IOTLB