Re: [PATCH net-next 0/3] vhost: accelerate metadata access through vmap()

2018-12-18 Thread Michael S. Tsirkin
On Sat, Dec 15, 2018 at 11:43:08AM -0800, David Miller wrote: > From: Jason Wang > Date: Fri, 14 Dec 2018 12:29:54 +0800 > > > > > On 2018/12/14 上午4:12, Michael S. Tsirkin wrote: > >> On Thu, Dec 13, 2018 at 06:10:19PM +0800, Jason Wang wrote: > >>> Hi: > >>> > >>> This series tries to access

Re: [PATCH] vhost: return EINVAL if iovecs size does not match the message size

2018-12-18 Thread Michael S. Tsirkin
On Sat, Dec 15, 2018 at 11:46:11AM -0800, David Miller wrote: > From: Pavel Tikhomirov > Date: Thu, 13 Dec 2018 17:53:50 +0300 > > > We've failed to copy and process vhost_iotlb_msg so let userspace at > > least know about it. For instance before these patch the code below runs > > without any

Re: [PATCH net-next 3/3] vhost: access vq metadata through kernel virtual address

2018-12-18 Thread David Miller
From: Jason Wang Date: Fri, 14 Dec 2018 11:57:35 +0800 > This is the price of all GUP users not only vhost itself. What's more > important, the goal is not to be left too much behind for other > backends like DPDK or AF_XDP (all of which are using GUP). +1

Re: [PATCH] vhost: return EINVAL if iovecs size does not match the message size

2018-12-18 Thread David Miller
From: Pavel Tikhomirov Date: Thu, 13 Dec 2018 17:53:50 +0300 > We've failed to copy and process vhost_iotlb_msg so let userspace at > least know about it. For instance before these patch the code below runs > without any error: ... > Signed-off-by: Pavel Tikhomirov Michael, will you be taking

Re: [PATCH net-next 0/3] vhost: accelerate metadata access through vmap()

2018-12-18 Thread David Miller
From: Jason Wang Date: Fri, 14 Dec 2018 12:29:54 +0800 > > On 2018/12/14 上午4:12, Michael S. Tsirkin wrote: >> On Thu, Dec 13, 2018 at 06:10:19PM +0800, Jason Wang wrote: >>> Hi: >>> >>> This series tries to access virtqueue metadata through kernel virtual >>> address instead of copy_user()

Call for Papers - MICRADS 2019, Rio de Janeiro, Brazil | Deadline: December 28

2018-12-18 Thread Marle
* Proceedings by Springer -- MICRADS´19 - The 2019 Multidisciplinary International Conference of Research Applied to Defense and Security Rio de Janeiro, Brazil, 8 - 10 May 2019 http://www.micrads.org/

Re: [PATCH net-next 0/3] vhost: accelerate metadata access through vmap()

2018-12-18 Thread Michael S. Tsirkin
On Fri, Dec 14, 2018 at 07:33:20AM -0500, Michael S. Tsirkin wrote: > > - unsafe_put_user/unsafe_get_user is not sufficient for accessing structures > > (e.g accessing descriptor) or arrays (batching). > > So you want unsafe_copy_xxx_user? I can do this. Hang on will post. Like this basically?

Re: [PATCH net-next 0/3] vhost: accelerate metadata access through vmap()

2018-12-18 Thread Michael S. Tsirkin
On Thu, Dec 13, 2018 at 06:10:19PM +0800, Jason Wang wrote: > Hi: > > This series tries to access virtqueue metadata through kernel virtual > address instead of copy_user() friends since they had too much > overheads like checks, spec barriers or even hardware feature > toggling. > > Test shows

Re: [PATCH net-next 3/3] vhost: access vq metadata through kernel virtual address

2018-12-18 Thread kbuild test robot
Hi Jason, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Jason-Wang/vhost-accelerate-metadata-access-through-vmap/20181214-200417 config: mips-malta_kvm_defconfig (attached as .config) compiler:

Re: [PATCH v2 0/5] VSOCK: support mergeable rx buffer in vhost-vsock

2018-12-18 Thread Michael S. Tsirkin
On Fri, Dec 14, 2018 at 06:24:40PM +0800, jiangyiwen wrote: > On 2018/12/12 23:09, Michael S. Tsirkin wrote: > > On Wed, Dec 12, 2018 at 05:25:50PM +0800, jiangyiwen wrote: > >> Now vsock only support send/receive small packet, it can't achieve > >> high performance. As previous discussed with

Re: [PATCH net V2 4/4] vhost: log dirty page correctly

2018-12-18 Thread Michael S. Tsirkin
On Fri, Dec 14, 2018 at 10:43:03AM +0800, Jason Wang wrote: > > On 2018/12/13 下午10:31, Michael S. Tsirkin wrote: > > > Just to make sure I understand this. It looks to me we should: > > > > > > - allow passing GIOVA->GPA through UAPI > > > > > > - cache GIOVA->GPA somewhere but still use

Re: [PATCH net-next 0/3] vhost: accelerate metadata access through vmap()

2018-12-18 Thread Michael S. Tsirkin
On Fri, Dec 14, 2018 at 12:29:54PM +0800, Jason Wang wrote: > > On 2018/12/14 上午4:12, Michael S. Tsirkin wrote: > > On Thu, Dec 13, 2018 at 06:10:19PM +0800, Jason Wang wrote: > > > Hi: > > > > > > This series tries to access virtqueue metadata through kernel virtual > > > address instead of

Re: [PATCH net-next 3/3] vhost: access vq metadata through kernel virtual address

2018-12-18 Thread Michael S. Tsirkin
On Fri, Dec 14, 2018 at 11:57:35AM +0800, Jason Wang wrote: > > On 2018/12/13 下午11:44, Michael S. Tsirkin wrote: > > On Thu, Dec 13, 2018 at 06:10:22PM +0800, Jason Wang wrote: > > > It was noticed that the copy_user() friends that was used to access > > > virtqueue metdata tends to be very

Re: [PATCH net-next 0/3] vhost: accelerate metadata access through vmap()

2018-12-18 Thread Michael S. Tsirkin
On Fri, Dec 14, 2018 at 11:42:18AM +0800, Jason Wang wrote: > > On 2018/12/13 下午11:27, Michael S. Tsirkin wrote: > > On Thu, Dec 13, 2018 at 06:10:19PM +0800, Jason Wang wrote: > > > Hi: > > > > > > This series tries to access virtqueue metadata through kernel virtual > > > address instead of

Re: [PATCH v2 0/5] VSOCK: support mergeable rx buffer in vhost-vsock

2018-12-18 Thread jiangyiwen
On 2018/12/12 23:09, Michael S. Tsirkin wrote: > On Wed, Dec 12, 2018 at 05:25:50PM +0800, jiangyiwen wrote: >> Now vsock only support send/receive small packet, it can't achieve >> high performance. As previous discussed with Jason Wang, I revisit the >> idea of vhost-net about mergeable rx