Re: [PATCH] tpm: Add driver for TPM over virtio

2019-02-22 Thread Michael S. Tsirkin
On Sat, Feb 23, 2019 at 12:36:34AM +0200, Jarkko Sakkinen wrote: > I do not require spec quality documentation. Just a few paragraphs of > what is in crosvm, kernel etc. and something about inner workings to > get a rough idea. No need for TCG level spec for this :-) OTOH for virtio if there's no

Re: [PATCH] tpm: Add driver for TPM over virtio

2019-02-22 Thread Michael S. Tsirkin
On Fri, Feb 22, 2019 at 01:40:25PM -0800, David Tolnay wrote: > On 2/21/19 9:51 PM, Michael S. Tsirkin wrote: > > On Thu, Feb 21, 2019 at 06:14:02PM -0800, David Tolnay wrote: > >> Add a config TCG_VIRTIO_VTPM which enables a driver providing the guest > >> kernel side of TPM over virtio. > >> > >>

Re: [PATCH] tpm: Add driver for TPM over virtio

2019-02-22 Thread Michael S. Tsirkin
On Fri, Feb 22, 2019 at 11:59:23PM +0200, Jarkko Sakkinen wrote: > On Fri, Feb 22, 2019 at 02:31:37PM -0700, Jason Gunthorpe wrote: > > On Fri, Feb 22, 2019 at 04:16:01PM -0500, Michael S. Tsirkin wrote: > > > On Fri, Feb 22, 2019 at 07:30:16AM -0800, James Bottomley wrote: > > > > On Thu, 2019-02-

Re: [PATCH] tpm: Add driver for TPM over virtio

2019-02-22 Thread Michael S. Tsirkin
On Fri, Feb 22, 2019 at 09:33:05PM +0200, Jarkko Sakkinen wrote: > On Fri, Feb 22, 2019 at 09:31:56PM +0200, Jarkko Sakkinen wrote: > > On Fri, Feb 22, 2019 at 10:23:02AM -0500, Michael S. Tsirkin wrote: > > > On Fri, Feb 22, 2019 at 12:26:10PM +0200, Jarkko Sakkinen wrote: > > > > On Thu, Feb 21,

Re: [PATCH] tpm: Add driver for TPM over virtio

2019-02-22 Thread Michael S. Tsirkin
On Fri, Feb 22, 2019 at 07:30:16AM -0800, James Bottomley wrote: > On Thu, 2019-02-21 at 18:14 -0800, David Tolnay wrote: > > Add a config TCG_VIRTIO_VTPM which enables a driver providing the > > guest kernel side of TPM over virtio. > > What's the use case for using this over the current non-virt

Re: [PATCH] tpm: Add driver for TPM over virtio

2019-02-22 Thread Michael S. Tsirkin
On Fri, Feb 22, 2019 at 09:31:56PM +0200, Jarkko Sakkinen wrote: > On Fri, Feb 22, 2019 at 10:23:02AM -0500, Michael S. Tsirkin wrote: > > On Fri, Feb 22, 2019 at 12:26:10PM +0200, Jarkko Sakkinen wrote: > > > On Thu, Feb 21, 2019 at 06:14:02PM -0800, David Tolnay wrote: > > > > Add a config TCG_VI

Re: [PATCH] tpm: Add driver for TPM over virtio

2019-02-22 Thread Michael S. Tsirkin
On Fri, Feb 22, 2019 at 12:26:10PM +0200, Jarkko Sakkinen wrote: > On Thu, Feb 21, 2019 at 06:14:02PM -0800, David Tolnay wrote: > > Add a config TCG_VIRTIO_VTPM which enables a driver providing the guest > > kernel side of TPM over virtio. > > > > Use case: TPM support is needed for performing tr

Re: [virtio-dev] Re: net_failover slave udev renaming (was Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework)

2019-02-22 Thread Michael S. Tsirkin
On Thu, Feb 21, 2019 at 11:55:11PM -0800, si-wei liu wrote: > > > On 2/21/2019 11:00 PM, Samudrala, Sridhar wrote: > > > > > > On 2/21/2019 7:33 PM, si-wei liu wrote: > > > > > > > > > On 2/21/2019 5:39 PM, Michael S. Tsirkin wrote: > > > > On Thu, Feb 21, 2019 at 05:14:44PM -0800, Siwei Liu

Re: [PATCH v7 0/7] Add virtio-iommu driver

2019-02-22 Thread Jean-Philippe Brucker
Hi Thiago, On 21/02/2019 22:18, Thiago Jung Bauermann wrote: > > Hello Jean-Philippe, > > Jean-Philippe Brucker writes: >> Makes sense, though I think other virtio devices have been developed a >> little more organically: device and driver code got upstreamed first, >> and then the specificatio

[PATCH v5 3/3] drm/qxl: remove conflicting framebuffers earlier

2019-02-22 Thread Gerd Hoffmann
Add error checking while being at it. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/qxl/qxl_drv.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_drv.c b/drivers/gpu/drm/qxl/qxl_drv.c index bb81e310eb6d..578d867a81d5

Re: [PATCH v4 2/2] drm/qxl: remove conflicting framebuffers earlier

2019-02-22 Thread Daniel Vetter
On Fri, Feb 22, 2019 at 08:16:04AM +0100, Gerd Hoffmann wrote: > Add error checking while being at it. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/qxl/qxl_drv.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/dr