Re: [PATCH net] vhost_net: fix possible infinite loop

2019-05-12 Thread Jason Wang
On 2019/5/13 上午1:10, Michael S. Tsirkin wrote: On Sun, May 05, 2019 at 12:20:24PM +0800, Jason Wang wrote: On 2019/4/26 下午3:35, Jason Wang wrote: On 2019/4/26 上午1:52, Michael S. Tsirkin wrote: On Thu, Apr 25, 2019 at 03:33:19AM -0400, Jason Wang wrote: When the rx buffer is too small for a

[PATCH net] vhost: don't use kmap() to log dirty pages

2019-05-12 Thread Jason Wang
Vhost log dirty pages directly to a userspace bitmap through GUP and kmap_atomic() since kernel doesn't have a set_bit_to_user() helper. This will cause issues for the arch that has virtually tagged caches. The way to fix is to keep using userspace virtual address. Fortunately, futex has

Re: [RFC PATCH V2] vhost: don't use kmap() to log dirty pages

2019-05-12 Thread Jason Wang
On 2019/5/10 下午12:48, Jason Wang wrote: On 2019/5/10 上午10:59, Jason Wang wrote:     r = get_user_pages_fast(log, 1, 1, ); OK so the trick is that page is pinned so you don't expect arch_futex_atomic_op_inuser below to fail. get_user_pages_fast guarantees page is not going away but does

Re: [Qemu-devel] [PATCH v8 2/6] virtio-pmem: Add virtio pmem driver

2019-05-12 Thread Pankaj Gupta
> > Guest reads the persistent memory range information from > > Qemu over VIRTIO and registers it on nvdimm_bus. It also > > creates a nd_region object with the persistent memory > > range information so that existing 'nvdimm/pmem' driver > > can reserve this into system memory map. This way >

Re: [PATCH 05/10] s390/cio: introduce DMA pools to cio

2019-05-12 Thread Halil Pasic
On Fri, 10 May 2019 16:10:13 +0200 Cornelia Huck wrote: > On Fri, 10 May 2019 00:11:12 +0200 > Halil Pasic wrote: > > > On Thu, 9 May 2019 12:11:06 +0200 > > Cornelia Huck wrote: > > > > > On Wed, 8 May 2019 23:22:10 +0200 > > > Halil Pasic wrote: > > > > > > > On Wed, 8 May 2019

Re: [PATCH v7 0/7] Add virtio-iommu driver

2019-05-12 Thread Michael S. Tsirkin
On Tue, Jan 15, 2019 at 12:19:52PM +, Jean-Philippe Brucker wrote: > Implement the virtio-iommu driver, following specification v0.9 [1]. > > This is a simple rebase onto Linux v5.0-rc2. We now use the > dev_iommu_fwspec_get() helper introduced in v5.0 instead of accessing >

Re: [PATCH net] vhost_net: fix possible infinite loop

2019-05-12 Thread Michael S. Tsirkin
On Sun, May 05, 2019 at 12:20:24PM +0800, Jason Wang wrote: > > On 2019/4/26 下午3:35, Jason Wang wrote: > > > > On 2019/4/26 上午1:52, Michael S. Tsirkin wrote: > > > On Thu, Apr 25, 2019 at 03:33:19AM -0400, Jason Wang wrote: > > > > When the rx buffer is too small for a packet, we will discard

Re: [PATCH v2 1/8] vsock/virtio: limit the memory used per-socket

2019-05-12 Thread Michael S. Tsirkin
On Fri, May 10, 2019 at 02:58:36PM +0200, Stefano Garzarella wrote: > Since virtio-vsock was introduced, the buffers filled by the host > and pushed to the guest using the vring, are directly queued in > a per-socket list avoiding to copy it. > These buffers are preallocated by the guest with a

Re: [PATCH v8 0/6] virtio pmem driver

2019-05-12 Thread Michael S. Tsirkin
On Fri, May 10, 2019 at 07:33:03PM -0400, Pankaj Gupta wrote: > > > > > > > Hi Michael & Dan, > > > > > > Please review/ack the patch series from LIBNVDIMM & VIRTIO side. > > > We have ack on ext4, xfs patches(4, 5 & 6) patch 2. Still need > > > your ack on nvdimm patches(1 & 3) & virtio

Re: [PATCH v8 2/6] virtio-pmem: Add virtio pmem driver

2019-05-12 Thread Michael S. Tsirkin
On Fri, May 10, 2019 at 09:21:58PM +0530, Pankaj Gupta wrote: > This patch adds virtio-pmem driver for KVM guest. > > Guest reads the persistent memory range information from > Qemu over VIRTIO and registers it on nvdimm_bus. It also > creates a nd_region object with the persistent memory > range

Re: [PATCH 01/10] virtio/s390: use vring_create_virtqueue

2019-05-12 Thread Michael S. Tsirkin
On Fri, May 10, 2019 at 04:07:44PM +0200, Cornelia Huck wrote: > On Tue, 7 May 2019 15:58:12 +0200 > Christian Borntraeger wrote: > > > On 05.05.19 13:15, Cornelia Huck wrote: > > > On Sat, 4 May 2019 16:03:40 +0200 > > > Halil Pasic wrote: > > > > > >> On Fri, 3 May 2019 16:04:48 -0400 > >

Re: [PATCH v7 0/7] Add virtio-iommu driver

2019-05-12 Thread Michael S. Tsirkin
On Tue, Jan 15, 2019 at 12:19:52PM +, Jean-Philippe Brucker wrote: > Implement the virtio-iommu driver, following specification v0.9 [1]. > > This is a simple rebase onto Linux v5.0-rc2. We now use the > dev_iommu_fwspec_get() helper introduced in v5.0 instead of accessing >