Re: [PATCH v3 5/8] virtio/s390: use cacheline aligned airq bit vectors

2019-06-03 Thread Christian Borntraeger
On 29.05.19 14:26, Michael Mueller wrote: > From: Halil Pasic > > The flag AIRQ_IV_CACHELINE was recently added to airq_iv_create(). Let > us use it! We actually wanted the vector to span a cacheline all along. Given that VIRTIO_IV_BITS is (L1_CACHE_BYTES * 8) this makes perfect sense. Revie

Re: [PATCH v3 2/5] vsock/virtio: fix locking for fwd_cnt and buf_alloc

2019-06-03 Thread Stefano Garzarella
On Sun, Jun 02, 2019 at 06:03:34PM -0700, David Miller wrote: > From: Stefano Garzarella > Date: Fri, 31 May 2019 15:39:51 +0200 > > > @@ -434,7 +434,9 @@ void virtio_transport_set_buffer_size(struct vsock_sock > > *vsk, u64 val) > > if (val > vvs->buf_size_max) > > vvs->buf_size

Re: [PATCH v3 2/8] s390/cio: introduce DMA pools to cio

2019-06-03 Thread Cornelia Huck
On Wed, 29 May 2019 14:26:51 +0200 Michael Mueller wrote: > From: Halil Pasic > > To support protected virtualization cio will need to make sure the > memory used for communication with the hypervisor is DMA memory. > > Let us introduce one global pool for cio. > > Our DMA pools are implement

Re: [PATCH v3 3/8] s390/cio: add basic protected virtualization support

2019-06-03 Thread Cornelia Huck
On Wed, 29 May 2019 14:26:52 +0200 Michael Mueller wrote: > From: Halil Pasic > > As virtio-ccw devices are channel devices, we need to use the dma area > for any communication with the hypervisor. "we need to use the dma area within the common I/O layer for any communication with the hypervis

Re: [PATCH v3 2/8] s390/cio: introduce DMA pools to cio

2019-06-03 Thread Michael Mueller
On 03.06.19 13:37, Cornelia Huck wrote: On Wed, 29 May 2019 14:26:51 +0200 Michael Mueller wrote: From: Halil Pasic To support protected virtualization cio will need to make sure the memory used for communication with the hypervisor is DMA memory. Let us introduce one global pool for cio

Re: [PATCH v3 3/8] s390/cio: add basic protected virtualization support

2019-06-03 Thread Michael Mueller
On 03.06.19 14:06, Cornelia Huck wrote: On Wed, 29 May 2019 14:26:52 +0200 Michael Mueller wrote: From: Halil Pasic As virtio-ccw devices are channel devices, we need to use the dma area for any communication with the hypervisor. "we need to use the dma area within the common I/O layer

Re: [PATCH v3 2/8] s390/cio: introduce DMA pools to cio

2019-06-03 Thread Halil Pasic
On Mon, 3 Jun 2019 13:37:45 +0200 Cornelia Huck wrote: > On Wed, 29 May 2019 14:26:51 +0200 > Michael Mueller wrote: > > > From: Halil Pasic > > > > To support protected virtualization cio will need to make sure the > > memory used for communication with the hypervisor is DMA memory. > > > >

Re: [PATCH v3 2/8] s390/cio: introduce DMA pools to cio

2019-06-03 Thread Halil Pasic
On Mon, 3 Jun 2019 14:09:02 +0200 Michael Mueller wrote: > >> @@ -224,6 +226,8 @@ struct subchannel *css_alloc_subchannel(struct > >> subchannel_id schid, > >>INIT_WORK(&sch->todo_work, css_sch_todo); > >>sch->dev.release = &css_subchannel_release; > >>device_initialize(&sch->dev);

Re: [PATCH v3 2/8] s390/cio: introduce DMA pools to cio

2019-06-03 Thread Cornelia Huck
On Mon, 3 Jun 2019 14:57:30 +0200 Halil Pasic wrote: > On Mon, 3 Jun 2019 14:09:02 +0200 > Michael Mueller wrote: > > > >> @@ -224,6 +226,8 @@ struct subchannel *css_alloc_subchannel(struct > > >> subchannel_id schid, > > >> INIT_WORK(&sch->todo_work, css_sch_todo); > > >> sc

Re: [PATCH v3 2/8] s390/cio: introduce DMA pools to cio

2019-06-03 Thread Cornelia Huck
On Mon, 3 Jun 2019 14:47:06 +0200 Halil Pasic wrote: > On Mon, 3 Jun 2019 13:37:45 +0200 > Cornelia Huck wrote: > > > On Wed, 29 May 2019 14:26:51 +0200 > > Michael Mueller wrote: > > > diff --git a/arch/s390/include/asm/cio.h b/arch/s390/include/asm/cio.h > > > index 1727180e8ca1..43c007d277

Re: [PATCH v3 3/8] s390/cio: add basic protected virtualization support

2019-06-03 Thread Cornelia Huck
On Mon, 3 Jun 2019 14:45:03 +0200 Michael Mueller wrote: > On 03.06.19 14:06, Cornelia Huck wrote: > > On Wed, 29 May 2019 14:26:52 +0200 > > Michael Mueller wrote: > >> @@ -1593,20 +1625,31 @@ struct ccw_device * __init > >> ccw_device_create_console(struct ccw_driver *drv) > >>re

Re: [PATCH v3 2/8] s390/cio: introduce DMA pools to cio

2019-06-03 Thread Michael Mueller
On 03.06.19 15:34, Cornelia Huck wrote: On Mon, 3 Jun 2019 14:57:30 +0200 Halil Pasic wrote: On Mon, 3 Jun 2019 14:09:02 +0200 Michael Mueller wrote: @@ -224,6 +226,8 @@ struct subchannel *css_alloc_subchannel(struct subchannel_id schid, INIT_WORK(&sch->todo_work, css_sch_todo);

Re: [PATCH v3 3/8] s390/cio: add basic protected virtualization support

2019-06-03 Thread Michael Mueller
On 03.06.19 15:42, Cornelia Huck wrote: On Mon, 3 Jun 2019 14:45:03 +0200 Michael Mueller wrote: On 03.06.19 14:06, Cornelia Huck wrote: On Wed, 29 May 2019 14:26:52 +0200 Michael Mueller wrote: @@ -1593,20 +1625,31 @@ struct ccw_device * __init ccw_device_create_console(struct ccw_dr

Re: [PATCH v3 2/8] s390/cio: introduce DMA pools to cio

2019-06-03 Thread Halil Pasic
On Mon, 3 Jun 2019 14:09:02 +0200 Michael Mueller wrote: > >> @@ -1059,16 +1168,19 @@ static int __init css_bus_init(void) > >>if (ret) > >>goto out_unregister; > >>ret = register_pm_notifier(&css_power_notifier); > >> - if (ret) { > >> - unregister_reboot_notifier(&

Re: [PATCH v3 2/8] s390/cio: introduce DMA pools to cio

2019-06-03 Thread Halil Pasic
On Mon, 3 Jun 2019 16:04:28 +0200 Halil Pasic wrote: > On Mon, 3 Jun 2019 14:09:02 +0200 > Michael Mueller wrote: > > > >> @@ -1059,16 +1168,19 @@ static int __init css_bus_init(void) > > >> if (ret) > > >> goto out_unregister; > > >> ret = register_pm_notifie

[PULL] vhost: cleanups and fixes

2019-06-03 Thread Michael S. Tsirkin
The following changes since commit cd6c84d8f0cdc911df435bb075ba22ce3c605b07: Linux 5.2-rc2 (2019-05-26 16:49:19 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to c1ea02f15ab5efb3e93fc3144d

Re: [PATCH v3 4/8] s390/airq: use DMA memory for adapter interrupts

2019-06-03 Thread Cornelia Huck
On Wed, 29 May 2019 14:26:53 +0200 Michael Mueller wrote: > From: Halil Pasic > > Protected virtualization guests have to use shared pages for airq > notifier bit vectors, because hypervisor needs to write these bits. > > Let us make sure we allocate DMA memory for the notifier bit vectors by

Re: [PATCH v3 5/8] virtio/s390: use cacheline aligned airq bit vectors

2019-06-03 Thread Cornelia Huck
On Wed, 29 May 2019 14:26:54 +0200 Michael Mueller wrote: > From: Halil Pasic > > The flag AIRQ_IV_CACHELINE was recently added to airq_iv_create(). Let > us use it! We actually wanted the vector to span a cacheline all along. > > Signed-off-by: Halil Pasic > Signed-off-by: Michael Mueller >

Re: [PATCH v3 6/8] virtio/s390: add indirection to indicators access

2019-06-03 Thread Cornelia Huck
On Wed, 29 May 2019 14:26:55 +0200 Michael Mueller wrote: > From: Halil Pasic > > This will come in handy soon when we pull out the indicators from > virtio_ccw_device to a memory area that is shared with the hypervisor > (in particular for protected virtualization guests). > > Signed-off-by:

Re: [PATCH v3 8/8] virtio/s390: make airq summary indicators DMA

2019-06-03 Thread Cornelia Huck
On Wed, 29 May 2019 14:26:57 +0200 Michael Mueller wrote: > From: Halil Pasic > > Hypervisor needs to interact with the summary indicators, so these > need to be DMA memory as well (at least for protected virtualization > guests). > > Signed-off-by: Halil Pasic > Signed-off-by: Michael Muelle

Re: [PATCH v3 7/8] virtio/s390: use DMA memory for ccw I/O and classic notifiers

2019-06-03 Thread Cornelia Huck
On Wed, 29 May 2019 14:26:56 +0200 Michael Mueller wrote: > From: Halil Pasic > > Before virtio-ccw could get away with not using DMA API for the pieces of > memory it does ccw I/O with. With protected virtualization this has to > change, since the hypervisor needs to read and sometimes also wr

Re: [PATCH 22/22] docs: fix broken documentation links

2019-06-03 Thread Mark Brown
On Wed, May 29, 2019 at 08:23:53PM -0300, Mauro Carvalho Chehab wrote: > Mostly due to x86 and acpi conversion, several documentation > links are still pointing to the old file. Fix them. Acked-by: Mark Brown signature.asc Description: PGP signature _

Re: [PATCH v3 8/8] virtio/s390: make airq summary indicators DMA

2019-06-03 Thread Halil Pasic
On Mon, 3 Jun 2019 18:03:37 +0200 Cornelia Huck wrote: > On Wed, 29 May 2019 14:26:57 +0200 > Michael Mueller wrote: > > > From: Halil Pasic > > > > Hypervisor needs to interact with the summary indicators, so these > > need to be DMA memory as well (at least for protected virtualization > >

Re: [PATCH v3 6/8] virtio/s390: add indirection to indicators access

2019-06-03 Thread Halil Pasic
On Mon, 3 Jun 2019 17:55:54 +0200 Cornelia Huck wrote: > On Wed, 29 May 2019 14:26:55 +0200 > Michael Mueller wrote: > > > From: Halil Pasic > > > > This will come in handy soon when we pull out the indicators from > > virtio_ccw_device to a memory area that is shared with the hypervisor > >

Re: [RFC PATCH] virtio_ring: Use DMA API if guest memory is encrypted

2019-06-03 Thread Thiago Jung Bauermann
Michael S. Tsirkin writes: > On Wed, Apr 17, 2019 at 06:42:00PM -0300, Thiago Jung Bauermann wrote: >> I rephrased it in terms of address translation. What do you think of >> this version? The flag name is slightly different too: >> >> >> VIRTIO_F_ACCESS_PLATFORM_NO_TRANSLATION This feature ha

Re: [RFC PATCH] virtio_ring: Use DMA API if guest memory is encrypted

2019-06-03 Thread Michael S. Tsirkin
On Mon, Jun 03, 2019 at 10:13:59PM -0300, Thiago Jung Bauermann wrote: > > > Michael S. Tsirkin writes: > > > On Wed, Apr 17, 2019 at 06:42:00PM -0300, Thiago Jung Bauermann wrote: > >> I rephrased it in terms of address translation. What do you think of > >> this version? The flag name is slig