Re: [PATCH net-next] vhost_net: disable zerocopy by default

2019-06-17 Thread David Miller
From: Jason Wang Date: Mon, 17 Jun 2019 05:20:54 -0400 > Vhost_net was known to suffer from HOL[1] issues which is not easy to > fix. Several downstream disable the feature by default. What's more, > the datapath was split and datacopy path got the support of batching > and XDP support recently w

Re: [PATCH 06/59] drm/prime: Actually remove DRIVER_PRIME everywhere

2019-06-17 Thread Emil Velikov
On 2019/06/14, Daniel Vetter wrote: > Split out to make the functional changes stick out more. > Since this patch flew-by, as standalone one (intentionally or not) I'd add, anything vaguely like: "Core users of DRIVER_PRIME were removed from core with prior patches." HTH Emil ___

[PATCH] drm/prime: Actually remove DRIVER_PRIME everywhere

2019-06-17 Thread Daniel Vetter
Split out to make the functional changes stick out more. v2: amdgpu gained DRIVER_SYNCOBJ_TIMELINE. v3: amdgpu lost DRIVER_SYNCOBJ_TIMELINE. v4: Don't add a space in i915_drv.c (Sam) Cc: Sam Ravnborg Reviewed-by: Eric Anholt Signed-off-by: Daniel Vetter Cc: amd-...@lists.freedesktop.org Cc:

Re: [PATCH net-next] vhost_net: disable zerocopy by default

2019-06-17 Thread Michael S. Tsirkin
On Mon, Jun 17, 2019 at 05:20:54AM -0400, Jason Wang wrote: > Vhost_net was known to suffer from HOL[1] issues which is not easy to > fix. Several downstream disable the feature by default. What's more, > the datapath was split and datacopy path got the support of batching > and XDP support recentl

Re: [PATCH 3/4] drm/virtio: simplify cursor updates

2019-06-17 Thread Daniel Vetter
On Mon, Jun 17, 2019 at 01:14:05PM +0200, Gerd Hoffmann wrote: > No need to do the reservation dance, > we can just wait on the fence directly. > > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/virtio/virtgpu_plane.c | 13 +++-- > 1 file changed, 3 insertions(+), 10 deletions(-) >

Re: [PATCH 4/4] drm/virtio: remove virtio_gpu_object_wait

2019-06-17 Thread Daniel Vetter
On Mon, Jun 17, 2019 at 01:14:06PM +0200, Gerd Hoffmann wrote: > No users left. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/virtio/virtgpu_drv.h| 1 - > drivers/gpu/drm/virtio/virtgpu_object.c | 13 - > 2 files changed, 14 deletions(-)

Re: [PATCH 2/4] drm/virtio: switch virtio_gpu_wait_ioctl() to gem helper.

2019-06-17 Thread Daniel Vetter
On Mon, Jun 17, 2019 at 01:14:04PM +0200, Gerd Hoffmann wrote: > Use drm_gem_reservation_object_wait() in virtio_gpu_wait_ioctl(). Would be good to mention here that with this the wait becomes lockless, we don't call ttm_bo_reserve/unreserve anymore. > Signed-off-by: Gerd Hoffmann > --- > drive

Re: [PATCH 1/4] drm/virtio: pass gem reservation object to ttm init

2019-06-17 Thread Daniel Vetter
On Mon, Jun 17, 2019 at 04:08:25PM +0200, Daniel Vetter wrote: > On Mon, Jun 17, 2019 at 01:14:03PM +0200, Gerd Hoffmann wrote: > > With this gem and ttm will use the same reservation object, > > so mixing and matching ttm / gem reservation helpers should > > work fine. > > > > Signed-off-by: Gerd

Re: [PATCH 1/4] drm/virtio: pass gem reservation object to ttm init

2019-06-17 Thread Daniel Vetter
On Mon, Jun 17, 2019 at 01:14:03PM +0200, Gerd Hoffmann wrote: > With this gem and ttm will use the same reservation object, > so mixing and matching ttm / gem reservation helpers should > work fine. > > Signed-off-by: Gerd Hoffmann While doing my prime doc+cleanup series I wondered whether we s

[PATCH 2/4] drm/virtio: switch virtio_gpu_wait_ioctl() to gem helper.

2019-06-17 Thread Gerd Hoffmann
Use drm_gem_reservation_object_wait() in virtio_gpu_wait_ioctl(). Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c b/drivers/gpu/drm/virtio/virtg

[PATCH 4/4] drm/virtio: remove virtio_gpu_object_wait

2019-06-17 Thread Gerd Hoffmann
No users left. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_drv.h| 1 - drivers/gpu/drm/virtio/virtgpu_object.c | 13 - 2 files changed, 14 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h b/drivers/gpu/drm/virtio/virtgpu_drv.h index 9e2d3062b0

[PATCH 3/4] drm/virtio: simplify cursor updates

2019-06-17 Thread Gerd Hoffmann
No need to do the reservation dance, we can just wait on the fence directly. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_plane.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio

[PATCH 1/4] drm/virtio: pass gem reservation object to ttm init

2019-06-17 Thread Gerd Hoffmann
With this gem and ttm will use the same reservation object, so mixing and matching ttm / gem reservation helpers should work fine. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_object.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio

[PATCH net-next] vhost_net: disable zerocopy by default

2019-06-17 Thread Jason Wang
Vhost_net was known to suffer from HOL[1] issues which is not easy to fix. Several downstream disable the feature by default. What's more, the datapath was split and datacopy path got the support of batching and XDP support recently which makes it faster than zerocopy part for small packets transmi