Re: [PATCH V5 4/6] mdev: introduce virtio device and its device ops

2019-10-24 Thread Jason Wang
On 2019/10/25 上午4:44, Alex Williamson wrote: On Thu, 24 Oct 2019 11:51:35 +0800 Jason Wang wrote: On 2019/10/24 上午5:57, Alex Williamson wrote: On Wed, 23 Oct 2019 21:07:50 +0800 Jason Wang wrote: This patch implements basic support for mdev driver that supports virtio transport for

Re: [PATCH V5 2/6] modpost: add support for mdev class id

2019-10-24 Thread Jason Wang
On 2019/10/25 上午3:54, Alex Williamson wrote: On Thu, 24 Oct 2019 11:31:04 +0800 Jason Wang wrote: On 2019/10/24 上午5:42, Alex Williamson wrote: On Wed, 23 Oct 2019 21:07:48 +0800 Jason Wang wrote: Add support to parse mdev class id table. Reviewed-by: Parav Pandit Signed-off-by: Jason

Re: [PATCH V5 1/6] mdev: class id support

2019-10-24 Thread Jason Wang
On 2019/10/25 上午4:13, Alex Williamson wrote: On Thu, 24 Oct 2019 13:46:36 -0600 Alex Williamson wrote: On Thu, 24 Oct 2019 11:27:36 +0800 Jason Wang wrote: On 2019/10/24 上午5:42, Alex Williamson wrote: On Wed, 23 Oct 2019 21:07:47 +0800 Jason Wang wrote: Mdev bus only supports vfio

Re: [PATCH v2 0/3] kcov: collect coverage from usb and vhost

2019-10-24 Thread Andrew Morton
On Thu, 24 Oct 2019 14:47:31 +0200 Andrey Konovalov wrote: > > is it expected that the new kcov feature will be used elsewhere in the > > kernel? > > > > If the latter, which are the expected subsystems? > > Currently we encountered two cases where this is useful: USB and vhost > workers. Most

Re: [PATCH V5 4/6] mdev: introduce virtio device and its device ops

2019-10-24 Thread Alex Williamson
On Thu, 24 Oct 2019 11:51:35 +0800 Jason Wang wrote: > On 2019/10/24 上午5:57, Alex Williamson wrote: > > On Wed, 23 Oct 2019 21:07:50 +0800 > > Jason Wang wrote: > > > >> This patch implements basic support for mdev driver that supports > >> virtio transport for kernel virtio driver. > >> > >>

Re: [PATCH V5 1/6] mdev: class id support

2019-10-24 Thread Alex Williamson
On Thu, 24 Oct 2019 13:46:36 -0600 Alex Williamson wrote: > On Thu, 24 Oct 2019 11:27:36 +0800 > Jason Wang wrote: > > > On 2019/10/24 上午5:42, Alex Williamson wrote: > > > On Wed, 23 Oct 2019 21:07:47 +0800 > > > Jason Wang wrote: > > > > > >> Mdev bus only supports vfio driver right

Re: [PATCH V5 2/6] modpost: add support for mdev class id

2019-10-24 Thread Alex Williamson
On Thu, 24 Oct 2019 11:31:04 +0800 Jason Wang wrote: > On 2019/10/24 上午5:42, Alex Williamson wrote: > > On Wed, 23 Oct 2019 21:07:48 +0800 > > Jason Wang wrote: > > > >> Add support to parse mdev class id table. > >> > >> Reviewed-by: Parav Pandit > >> Signed-off-by: Jason Wang > >> --- >

Re: [PATCH V5 1/6] mdev: class id support

2019-10-24 Thread Alex Williamson
On Thu, 24 Oct 2019 11:27:36 +0800 Jason Wang wrote: > On 2019/10/24 上午5:42, Alex Williamson wrote: > > On Wed, 23 Oct 2019 21:07:47 +0800 > > Jason Wang wrote: > > > >> Mdev bus only supports vfio driver right now, so it doesn't implement > >> match method. But in the future, we may add

[PATCH v2 03/27] crypto: virtio - switch to skcipher API

2019-10-24 Thread Ard Biesheuvel
Commit 7a7ffe65c8c5 ("crypto: skcipher - Add top-level skcipher interface") dated 20 august 2015 introduced the new skcipher API which is supposed to replace both blkcipher and ablkcipher. While all consumers of the API have been converted long ago, some producers of the ablkcipher remain, forcing

[PATCH v2 02/27] crypto: virtio - deal with unsupported input sizes

2019-10-24 Thread Ard Biesheuvel
Return -EINVAL for input sizes that are not a multiple of the AES block size, since they are not supported by our CBC chaining mode. While at it, remove the pr_err() that reports unsupported key sizes being used: we shouldn't spam the kernel log with that. Fixes: dbaf0624ffa5 ("crypto: add

[PATCH v2 01/27] crypto: virtio - implement missing support for output IVs

2019-10-24 Thread Ard Biesheuvel
In order to allow for CBC to be chained, which is something that the CTS template relies upon, implementations of CBC need to pass the IV to be used for subsequent invocations via the IV buffer. This was not implemented yet for virtio-crypto so implement it now. Fixes: dbaf0624ffa5 ("crypto: add

Re: [PATCH] drm/simple-kms: Standardize arguments for callbacks

2019-10-24 Thread Daniel Vetter
On Wed, Oct 23, 2019 at 05:40:32PM +0200, Linus Walleij wrote: > On Wed, Oct 23, 2019 at 12:13 PM Daniel Vetter wrote: > > > Passing the wrong type feels icky, everywhere else we use the pipe as > > the first parameter. Spotted while discussing patches with Thomas > > Zimmermann. > > > > v2:

Re: [PATCH v2] vhost: introduce mdev based hardware backend

2019-10-24 Thread Jason Wang
On 2019/10/24 下午5:18, Tiwei Bie wrote: On Thu, Oct 24, 2019 at 04:32:42PM +0800, Jason Wang wrote: On 2019/10/24 下午4:03, Jason Wang wrote: On 2019/10/24 下午12:21, Tiwei Bie wrote: On Wed, Oct 23, 2019 at 06:29:21PM +0800, Jason Wang wrote: On 2019/10/23 下午6:11, Tiwei Bie wrote: On Wed, Oct

Re: [PATCH v2] vhost: introduce mdev based hardware backend

2019-10-24 Thread Tiwei Bie
On Thu, Oct 24, 2019 at 04:32:42PM +0800, Jason Wang wrote: > On 2019/10/24 下午4:03, Jason Wang wrote: > > On 2019/10/24 下午12:21, Tiwei Bie wrote: > > > On Wed, Oct 23, 2019 at 06:29:21PM +0800, Jason Wang wrote: > > > > On 2019/10/23 下午6:11, Tiwei Bie wrote: > > > > > On Wed, Oct 23, 2019 at

Re: [PATCH RFC v3 6/9] mm: Allow to offline PageOffline() pages with a reference count of 0

2019-10-24 Thread David Hildenbrand
On 24.10.19 10:42, Michal Hocko wrote: On Wed 23-10-19 12:03:51, David Hildenbrand wrote: Do you see any downsides? The only downside I see is that we get more false negatives on has_unmovable_pages(), eventually resulting in the offlining stage after isolation to loop forever (as some

Re: [PATCH RFC v3 6/9] mm: Allow to offline PageOffline() pages with a reference count of 0

2019-10-24 Thread Michal Hocko
On Wed 23-10-19 12:03:51, David Hildenbrand wrote: > >Do you see any downsides? > > The only downside I see is that we get more false negatives on > has_unmovable_pages(), eventually resulting in the offlining stage after > isolation to loop forever (as some PageOffline() pages are not movable >

Re: [PATCH v2] vhost: introduce mdev based hardware backend

2019-10-24 Thread Jason Wang
On 2019/10/24 下午4:03, Jason Wang wrote: On 2019/10/24 下午12:21, Tiwei Bie wrote: On Wed, Oct 23, 2019 at 06:29:21PM +0800, Jason Wang wrote: On 2019/10/23 下午6:11, Tiwei Bie wrote: On Wed, Oct 23, 2019 at 03:25:00PM +0800, Jason Wang wrote: On 2019/10/23 下午3:07, Tiwei Bie wrote: On Wed, Oct

Re: [PATCH v2] vhost: introduce mdev based hardware backend

2019-10-24 Thread Jason Wang
On 2019/10/24 下午12:21, Tiwei Bie wrote: On Wed, Oct 23, 2019 at 06:29:21PM +0800, Jason Wang wrote: On 2019/10/23 下午6:11, Tiwei Bie wrote: On Wed, Oct 23, 2019 at 03:25:00PM +0800, Jason Wang wrote: On 2019/10/23 下午3:07, Tiwei Bie wrote: On Wed, Oct 23, 2019 at 01:46:23PM +0800, Jason Wang

Re: [PATCH v2 1/3] kcov: remote coverage support

2019-10-24 Thread Dmitry Vyukov via Virtualization
On Wed, Oct 23, 2019 at 5:24 PM Andrey Konovalov wrote: > > This patch adds background thread coverage collection ability to kcov. ... > +static struct kcov_remote *kcov_remote_add(struct kcov *kcov, u64 handle) > +{ > + struct kcov_remote *remote; > + > + if