Re: [PATCH v2] virtiofs: Use static const, not const static

2019-11-12 Thread Vivek Goyal
On Mon, Nov 11, 2019 at 08:15:45PM +0800, zhengbin wrote: > Move the static keyword to the front of declarations, which resolves > compiler warnings when building with "W=1": > > fs/fuse/virtio_fs.c:687:1: warning: ‘static’ is not at beginning of > declaration [-Wold-style-declaration] > const

Re: [PATCH 01/13] compiler.h: Split {READ,WRITE}_ONCE definitions out into rwonce.h

2019-11-12 Thread Will Deacon
On Mon, Nov 11, 2019 at 10:32:46AM +0100, Arnd Bergmann wrote: > On Mon, Nov 11, 2019 at 9:10 AM Christian Borntraeger > wrote: > > On 08.11.19 20:57, Arnd Bergmann wrote: > > > On Fri, Nov 8, 2019 at 6:01 PM Will Deacon wrote: > > >> > > >> In preparation for allowing architectures to define

Re: [PATCH] drm/virtgpu: fix double unregistration

2019-11-12 Thread Chuhong Yuan
On Tue, Nov 12, 2019 at 5:40 PM Daniel Vetter wrote: > > On Sat, Nov 09, 2019 at 03:54:17PM +0800, Chuhong Yuan wrote: > > drm_put_dev also calls drm_dev_unregister, so dev will be unregistered > > twice. > > Replace it with drm_dev_put to fix it. > > > > Signed-off-by: Chuhong Yuan > > Nice

Re: [PATCH net-next 12/14] vsock/vmci: register vmci_transport only when VMCI guest/host are active

2019-11-12 Thread Stefano Garzarella
On Tue, Nov 12, 2019 at 10:03:54AM +, Jorgen Hansen wrote: > > From: Stefano Garzarella [mailto:sgarz...@redhat.com] > > Sent: Monday, November 11, 2019 6:31 PM > > On Mon, Nov 11, 2019 at 04:27:28PM +, Jorgen Hansen wrote: > > > > From: Stefano Garzarella [mailto:sgarz...@redhat.com] > >

Re: [PATCH net-next 11/14] vsock: add multi-transports support

2019-11-12 Thread Stefano Garzarella
On Tue, Nov 12, 2019 at 09:59:12AM +, Jorgen Hansen wrote: > > From: Stefano Garzarella [mailto:sgarz...@redhat.com] > > Sent: Monday, November 11, 2019 6:18 PM > > To: Jorgen Hansen > > Subject: Re: [PATCH net-next 11/14] vsock: add multi-transports support > > > > On Mon, Nov 11, 2019 at

Re: [PATCH -next] virtiofs: Fix old-style declaration

2019-11-12 Thread Stefan Hajnoczi
On Mon, Nov 11, 2019 at 08:23:59PM +0800, YueHaibing wrote: > There expect the 'static' keyword to come first in a > declaration, and we get warnings like this with "make W=1": > > fs/fuse/virtio_fs.c:687:1: warning: 'static' is not at beginning of > declaration [-Wold-style-declaration] >

Re: [PATCH v2] virtiofs: Use static const, not const static

2019-11-12 Thread Stefan Hajnoczi
On Mon, Nov 11, 2019 at 08:15:45PM +0800, zhengbin wrote: > Move the static keyword to the front of declarations, which resolves > compiler warnings when building with "W=1": > > fs/fuse/virtio_fs.c:687:1: warning: ‘static’ is not at beginning of > declaration [-Wold-style-declaration] > const

RE: [PATCH net-next 12/14] vsock/vmci: register vmci_transport only when VMCI guest/host are active

2019-11-12 Thread Jorgen Hansen via Virtualization
> From: Stefano Garzarella [mailto:sgarz...@redhat.com] > Sent: Monday, November 11, 2019 6:31 PM > On Mon, Nov 11, 2019 at 04:27:28PM +, Jorgen Hansen wrote: > > > From: Stefano Garzarella [mailto:sgarz...@redhat.com] > > > Sent: Wednesday, October 23, 2019 11:56 AM > > > > > > To allow other

RE: [PATCH net-next 11/14] vsock: add multi-transports support

2019-11-12 Thread Jorgen Hansen via Virtualization
> From: Stefano Garzarella [mailto:sgarz...@redhat.com] > Sent: Monday, November 11, 2019 6:18 PM > To: Jorgen Hansen > Subject: Re: [PATCH net-next 11/14] vsock: add multi-transports support > > On Mon, Nov 11, 2019 at 01:53:39PM +, Jorgen Hansen wrote: > > > From: Stefano Garzarella

Re: [PATCH] drm/virtgpu: fix double unregistration

2019-11-12 Thread Daniel Vetter
On Sat, Nov 09, 2019 at 03:54:17PM +0800, Chuhong Yuan wrote: > drm_put_dev also calls drm_dev_unregister, so dev will be unregistered > twice. > Replace it with drm_dev_put to fix it. > > Signed-off-by: Chuhong Yuan Nice catch, I'll apply. Since this is so confusing, we actually have a todo