Re: [PATCH V2 3/5] vDPA: introduce vDPA bus

2020-02-16 Thread Jason Wang
On 2020/2/14 下午9:52, Jason Gunthorpe wrote: On Fri, Feb 14, 2020 at 11:23:27AM +0800, Jason Wang wrote: Though all vDPA devices have the same programming interface, but the semantic is different. So it looks to me that use bus complies what class.rst said: " Each device class defines a set o

Re: [PATCH V2 3/5] vDPA: introduce vDPA bus

2020-02-16 Thread Jason Wang
On 2020/2/14 下午10:04, Jason Gunthorpe wrote: On Fri, Feb 14, 2020 at 12:05:32PM +0800, Jason Wang wrote: The standard driver model is a 'bus' driver provides the HW access (think PCI level things), and a 'hw driver' attaches to the bus device, This is not true, kernel had already had plenty v

Re: [PATCH 3/3] iommu/virtio: Enable x86 support

2020-02-16 Thread Michael S. Tsirkin
On Fri, Feb 14, 2020 at 04:57:11PM +, Robin Murphy wrote: > On 14/02/2020 4:04 pm, Jean-Philippe Brucker wrote: > > With the built-in topology description in place, x86 platforms can now > > use the virtio-iommu. > > > > Signed-off-by: Jean-Philippe Brucker > > --- > > drivers/iommu/Kconfig

Re: [PATCH v1 3/3] virtio-balloon: Switch back to OOM handler for VIRTIO_BALLOON_F_DEFLATE_ON_OOM

2020-02-16 Thread Michael S. Tsirkin
On Fri, Feb 14, 2020 at 10:51:43AM +0100, David Hildenbrand wrote: > On 05.02.20 17:34, David Hildenbrand wrote: > > Commit 71994620bb25 ("virtio_balloon: replace oom notifier with shrinker") > > changed the behavior when deflation happens automatically. Instead of > > deflating when called by the

Re: [PATCH v1 3/3] virtio-balloon: Switch back to OOM handler for VIRTIO_BALLOON_F_DEFLATE_ON_OOM

2020-02-16 Thread Michael S. Tsirkin
On Fri, Feb 14, 2020 at 12:48:42PM -0800, Tyler Sanderson wrote: > Regarding Wei's patch that modifies the shrinker implementation, versus this > patch which reverts to OOM notifier: > I am in favor of both patches. But I do want to make sure a fix gets back > ported to 4.19 where the performance r

Re: [PATCH] virtio_balloon: Adjust label in virtballoon_probe

2020-02-16 Thread David Hildenbrand
> Am 16.02.2020 um 08:47 schrieb Nathan Chancellor : > > On Sun, Feb 16, 2020 at 08:36:45AM +0100, David Hildenbrand wrote: >> >> Am 16.02.2020 um 01:41 schrieb Nathan Chancellor : >>> >>> Clang warns when CONFIG_BALLOON_COMPACTION is unset: >>> >>> ../drivers/virtio/virtio_ball

Re: [PATCH] virtio_balloon: Fix unused label warning

2020-02-16 Thread David Hildenbrand
> Am 16.02.2020 um 08:46 schrieb Nathan Chancellor : > > On Mon, Feb 10, 2020 at 10:33:28AM +0100, Borislav Petkov wrote: >> From: Borislav Petkov >> >> Fix >> >> drivers/virtio/virtio_balloon.c: In function ‘virtballoon_probe’: >> drivers/virtio/virtio_balloon.c:963:1: warning: label ‘out_d