Re: [PATCH v3 0/3] virtio-net: introduce features defined in the spec

2020-03-01 Thread Jason Wang
On 2020/3/2 上午4:06, Michael S. Tsirkin wrote: On Sun, Mar 01, 2020 at 04:32:59PM +0200, Yuri Benditovich wrote: This series introduce virtio-net features VIRTIO_NET_F_RSC_EXT, VIRTIO_NET_F_RSS and VIRTIO_NET_F_HASH_REPORT. Changes from v2: reformatted structure in patch 1 Looks good but I

Re: [PATCH v3 0/3] virtio-net: introduce features defined in the spec

2020-03-01 Thread Michael S. Tsirkin
On Sun, Mar 01, 2020 at 04:32:59PM +0200, Yuri Benditovich wrote: > This series introduce virtio-net features VIRTIO_NET_F_RSC_EXT, > VIRTIO_NET_F_RSS and VIRTIO_NET_F_HASH_REPORT. > > Changes from v2: reformatted structure in patch 1 Looks good but I cound a couple more nits. Sorry I missed

Re: [PATCH v3 1/3] virtio-net: Introduce extended RSC feature

2020-03-01 Thread Michael S. Tsirkin
On Sun, Mar 01, 2020 at 04:33:00PM +0200, Yuri Benditovich wrote: > VIRTIO_NET_F_RSC_EXT feature bit indicates that the device > is able to provide extended RSC information. When the feature > is negotiatede and 'gso_type' field in received packet is not > GSO_NONE, the device reports number of

Re: [PATCH v3 2/3] virtio-net: Introduce RSS receive steering feature

2020-03-01 Thread Michael S. Tsirkin
On Sun, Mar 01, 2020 at 04:33:01PM +0200, Yuri Benditovich wrote: > RSS (Receive-side scaling) defines hash calculation > rules and decision on receive virtqueue according to > the calculated hash, provided mask to apply and > provided indirection table containing indices of > receive virqueues.

[PATCH v3 3/3] virtio-net: Introduce hash report feature

2020-03-01 Thread Yuri Benditovich
The feature VIRTIO_NET_F_HASH_REPORT extends the layout of the packet and requests the device to calculate hash on incoming packets and report it in the packet header. Signed-off-by: Yuri Benditovich --- include/uapi/linux/virtio_net.h | 36 + 1 file changed, 36

[PATCH v3 0/3] virtio-net: introduce features defined in the spec

2020-03-01 Thread Yuri Benditovich
This series introduce virtio-net features VIRTIO_NET_F_RSC_EXT, VIRTIO_NET_F_RSS and VIRTIO_NET_F_HASH_REPORT. Changes from v2: reformatted structure in patch 1 Yuri Benditovich (3): virtio-net: Introduce extended RSC feature virtio-net: Introduce RSS receive steering feature virtio-net:

[PATCH v3 1/3] virtio-net: Introduce extended RSC feature

2020-03-01 Thread Yuri Benditovich
VIRTIO_NET_F_RSC_EXT feature bit indicates that the device is able to provide extended RSC information. When the feature is negotiatede and 'gso_type' field in received packet is not GSO_NONE, the device reports number of coalesced packets in 'csum_start' field and number of duplicated acks in

[PATCH v3 2/3] virtio-net: Introduce RSS receive steering feature

2020-03-01 Thread Yuri Benditovich
RSS (Receive-side scaling) defines hash calculation rules and decision on receive virtqueue according to the calculated hash, provided mask to apply and provided indirection table containing indices of receive virqueues. The driver sends the control command to enable multiqueue and provide

Re: [PATCH v2 1/3] virtio-net: Introduce extended RSC feature

2020-03-01 Thread Yuri Benditovich
No problem, I'll send an update On Sun, Mar 1, 2020 at 1:31 PM Michael S. Tsirkin wrote: > > On Sun, Mar 01, 2020 at 01:07:31PM +0200, Yuri Benditovich wrote: > > VIRTIO_NET_F_RSC_EXT feature bit indicates that the device > > is able to provide extended RSC information. When the feature > > is

Re: [PATCH v2 0/3] virtio-net: introduce features defined in the spec

2020-03-01 Thread Michael S. Tsirkin
On Sun, Mar 01, 2020 at 02:47:41PM +0200, Yuri Benditovich wrote: > On Sun, Mar 1, 2020 at 1:32 PM Michael S. Tsirkin wrote: > > > > On Sun, Mar 01, 2020 at 01:07:30PM +0200, Yuri Benditovich wrote: > > > This series introduce virtio-net features VIRTIO_NET_F_RSC_EXT, > > > VIRTIO_NET_F_RSS and

Re: [PATCH v2 0/3] virtio-net: introduce features defined in the spec

2020-03-01 Thread Yuri Benditovich
On Sun, Mar 1, 2020 at 1:32 PM Michael S. Tsirkin wrote: > > On Sun, Mar 01, 2020 at 01:07:30PM +0200, Yuri Benditovich wrote: > > This series introduce virtio-net features VIRTIO_NET_F_RSC_EXT, > > VIRTIO_NET_F_RSS and VIRTIO_NET_F_HASH_REPORT. > > > > Changes from v1: > > __virtio -> __le > >

Re: [PATCH v2 0/3] virtio-net: introduce features defined in the spec

2020-03-01 Thread Michael S. Tsirkin
On Sun, Mar 01, 2020 at 01:07:30PM +0200, Yuri Benditovich wrote: > This series introduce virtio-net features VIRTIO_NET_F_RSC_EXT, > VIRTIO_NET_F_RSS and VIRTIO_NET_F_HASH_REPORT. > > Changes from v1: > __virtio -> __le > maximal -> maximum > minor style fixes Looks good to me - sent a bit of

Re: [PATCH v2 1/3] virtio-net: Introduce extended RSC feature

2020-03-01 Thread Michael S. Tsirkin
On Sun, Mar 01, 2020 at 01:07:31PM +0200, Yuri Benditovich wrote: > VIRTIO_NET_F_RSC_EXT feature bit indicates that the device > is able to provide extended RSC information. When the feature > is negotiatede and 'gso_type' field in received packet is not > GSO_NONE, the device reports number of

Re: [PATCH v2 1/3] iommu/virtio: Add topology description to virtio-iommu config space

2020-03-01 Thread Michael S. Tsirkin
On Fri, Feb 28, 2020 at 06:25:36PM +0100, Jean-Philippe Brucker wrote: > Platforms without device-tree do not currently have a method for > describing the vIOMMU topology. Provide a topology description embedded > into the virtio device. > > Use PCI FIXUP to probe the config space early, because

[PATCH v2 0/3] virtio-net: introduce features defined in the spec

2020-03-01 Thread Yuri Benditovich
This series introduce virtio-net features VIRTIO_NET_F_RSC_EXT, VIRTIO_NET_F_RSS and VIRTIO_NET_F_HASH_REPORT. Changes from v1: __virtio -> __le maximal -> maximum minor style fixes Yuri Benditovich (3): virtio-net: Introduce extended RSC feature virtio-net: Introduce RSS receive steering

[PATCH v2 3/3] virtio-net: Introduce hash report feature

2020-03-01 Thread Yuri Benditovich
The feature VIRTIO_NET_F_HASH_REPORT extends the layout of the packet and requests the device to calculate hash on incoming packets and report it in the packet header. Signed-off-by: Yuri Benditovich --- include/uapi/linux/virtio_net.h | 36 + 1 file changed, 36

[PATCH v2 2/3] virtio-net: Introduce RSS receive steering feature

2020-03-01 Thread Yuri Benditovich
RSS (Receive-side scaling) defines hash calculation rules and decision on receive virtqueue according to the calculated hash, provided mask to apply and provided indirection table containing indices of receive virqueues. The driver sends the control command to enable multiqueue and provide

[PATCH v2 1/3] virtio-net: Introduce extended RSC feature

2020-03-01 Thread Yuri Benditovich
VIRTIO_NET_F_RSC_EXT feature bit indicates that the device is able to provide extended RSC information. When the feature is negotiatede and 'gso_type' field in received packet is not GSO_NONE, the device reports number of coalesced packets in 'csum_start' field and number of duplicated acks in

Re: [PATCH 2/3] virtio-net: Introduce RSS receive steering feature

2020-03-01 Thread Michael S. Tsirkin
On Sat, Feb 29, 2020 at 07:13:00PM +0200, Yuri Benditovich wrote: > RSS (Receive-side scaling) defines hash calculation > rules and decision on receive virtqueue according to > the calculated hash, provided mask to apply and > provided indirection table containing indices of > receive virqueues.

Re: [PATCH 1/3] virtio-net: Introduce extended RSC feature

2020-03-01 Thread Michael S. Tsirkin
On Sat, Feb 29, 2020 at 07:12:59PM +0200, Yuri Benditovich wrote: > VIRTIO_NET_F_RSC_EXT feature bit indicates that the device > is able to provide extended RSC information. When the feature > is negotiatede and 'gso_type' field in received packet is not > GSO_NONE, the device reports number of

Re: [PATCH 3/3] virtio-net: Introduce hash report feature

2020-03-01 Thread Michael S. Tsirkin
On Sat, Feb 29, 2020 at 07:13:01PM +0200, Yuri Benditovich wrote: > The feature VIRTIO_NET_F_HASH_REPORT extends the > layout of the packet and requests the device to > calculate hash on incoming packets and report it > in the packet header. > > Signed-off-by: Yuri Benditovich > --- >