Re: [PATCH v3,1/2] doc: zh_CN: index files in filesystems subdirectory

2020-03-20 Thread Jonathan Corbet
On Mon, 16 Mar 2020 04:01:31 -0700 Wang Wenhu wrote: > Add filesystems subdirectory into the table of Contents for zh_CN, > all translations residing on it would be indexed conveniently. > > Reviewed-by: Alex Shi > Reviewed-by: Mauro Carvalho Chehab > Signed-off-by: Wang Wenhu > --- > Changel

Re: [PATCH 21/70] x86/boot/compressed/64: Add function to map a page unencrypted

2020-03-20 Thread Dave Hansen
On 3/20/20 3:12 PM, Joerg Roedel wrote: > On Fri, Mar 20, 2020 at 02:02:13PM -0700, Dave Hansen wrote: >> It *never* flushes global pages. For a generic function like this, that >> seems pretty dangerous because the PTEs it goes after could quite easily >> be Global. It's also not _obviously_ cor

Re: [PATCH 23/70] x86/sev-es: Add support for handling IOIO exceptions

2020-03-20 Thread Joerg Roedel
On Fri, Mar 20, 2020 at 02:03:17PM -0700, David Rientjes wrote: > On Thu, 19 Mar 2020, Joerg Roedel wrote: > > + if (exit_info_1 & IOIO_TYPE_STR) { > > + int df = (regs->flags & X86_EFLAGS_DF) ? -1 : 1; > > [ ... ] > > + if (!(exit_info_1 & IOIO_TYPE_IN)) { > > +

Re: [PATCH 62/70] x86/kvm: Add KVM specific VMMCALL handling under SEV-ES

2020-03-20 Thread Joerg Roedel
On Fri, Mar 20, 2020 at 02:23:58PM -0700, David Rientjes wrote: > On Thu, 19 Mar 2020, Joerg Roedel wrote: > > +#if defined(CONFIG_AMD_MEM_ENCRYPT) > > +static void kvm_sev_es_hcall_prepare(struct ghcb *ghcb, struct pt_regs > > *regs) > > +{ > > + /* RAX and CPL are already in the GHCB */ > > +

Re: [PATCH 18/70] x86/boot/compressed/64: Add stage1 #VC handler

2020-03-20 Thread Joerg Roedel
On Fri, Mar 20, 2020 at 02:16:39PM -0700, David Rientjes wrote: > On Thu, 19 Mar 2020, Joerg Roedel wrote: > > +#defineGHCB_SEV_GHCB_RESP_CODE(v) ((v) & 0xfff) > > +#defineVMGEXIT() { asm volatile("rep; > > vmmcall\n\r"); } > > Since preemption and irqs should b

Re: [PATCH 21/70] x86/boot/compressed/64: Add function to map a page unencrypted

2020-03-20 Thread Joerg Roedel
On Fri, Mar 20, 2020 at 02:02:13PM -0700, Dave Hansen wrote: > It *never* flushes global pages. For a generic function like this, that > seems pretty dangerous because the PTEs it goes after could quite easily > be Global. It's also not _obviously_ correct if PCIDs are in play > (which I don't th

Re: [PATCH 62/70] x86/kvm: Add KVM specific VMMCALL handling under SEV-ES

2020-03-20 Thread David Rientjes via Virtualization
On Thu, 19 Mar 2020, Joerg Roedel wrote: > From: Tom Lendacky > > Implement the callbacks to copy the processor state required by KVM to > the GHCB. > > Signed-off-by: Tom Lendacky > [ jroe...@suse.de: - Split out of a larger patch >- Adapt to different callback functions ]

Re: [PATCH 18/70] x86/boot/compressed/64: Add stage1 #VC handler

2020-03-20 Thread David Rientjes via Virtualization
On Thu, 19 Mar 2020, Joerg Roedel wrote: > diff --git a/arch/x86/include/asm/sev-es.h b/arch/x86/include/asm/sev-es.h > new file mode 100644 > index ..f524b40aef07 > --- /dev/null > +++ b/arch/x86/include/asm/sev-es.h > @@ -0,0 +1,45 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* >

Re: [PATCH 23/70] x86/sev-es: Add support for handling IOIO exceptions

2020-03-20 Thread David Rientjes via Virtualization
On Thu, 19 Mar 2020, Joerg Roedel wrote: > From: Tom Lendacky > > Add support for decoding and handling #VC exceptions for IOIO events. > > Signed-off-by: Tom Lendacky > [ jroe...@suse.de: Adapted code to #VC handling framework ] > Co-developed-by: Joerg Roedel > Signed-off-by: Joerg Roedel

Re: [PATCH 21/70] x86/boot/compressed/64: Add function to map a page unencrypted

2020-03-20 Thread Dave Hansen
On 3/20/20 1:53 PM, David Rientjes wrote: >> + >> +/* Clear encryption flag and write new pte */ >> +pte = pte_clear_flags(*ptep, _PAGE_ENC); >> +set_pte(ptep, pte); >> + >> +/* Flush TLB to map the page unencrypted */ >> +write_cr3(top_level_pgt); >> + > Is there a guarantee th

Re: [PATCH 21/70] x86/boot/compressed/64: Add function to map a page unencrypted

2020-03-20 Thread David Rientjes via Virtualization
On Thu, 19 Mar 2020, Joerg Roedel wrote: > From: Joerg Roedel > > This function is needed to map the GHCB for SEV-ES guests. The GHCB is > used for communication with the hypervisor, so its content must not be > encrypted. > > Signed-off-by: Joerg Roedel > --- > arch/x86/boot/compressed/ident

Re: [PATCH 70/70] x86/sev-es: Add NMI state tracking

2020-03-20 Thread Joerg Roedel
On Thu, Mar 19, 2020 at 02:27:49PM -0700, Andy Lutomirski wrote: > AIUI the shift-ist stuff is because we aren't very good about the way > that we handle tracing right now, and that can cause a limited degree > of recursion. #DB uses IST for historical reasons that don't > necessarily make sense.

Re: [RFC PATCH v2.1] x86/sev-es: Handle NMI State

2020-03-20 Thread Joerg Roedel
On Fri, Mar 20, 2020 at 07:42:09AM -0700, Dave Hansen wrote: > FWIW, perf plus the x86 selftests run in a big loop was my best way of > stressing the NMI path when we mucked with it for PTI. The selftests > make sure to hit some of the more rare entry/exit paths. Yeah, I ran the x86 selftests in

Re: [RFC PATCH v2.1] x86/sev-es: Handle NMI State

2020-03-20 Thread Dave Hansen
On 3/20/20 6:17 AM, Joerg Roedel wrote: > On Thu, Mar 19, 2020 at 08:35:59AM -0700, Andy Lutomirski wrote: >> 1. Just put the NMI unmask in do_nmi(). The kernel *already* knows >> how to handle running do_nmi() with NMIs unmasked. This is much, much >> simpler than your code. > Okay, attached is

[RFC PATCH v2.1] x86/sev-es: Handle NMI State

2020-03-20 Thread Joerg Roedel
On Thu, Mar 19, 2020 at 08:35:59AM -0700, Andy Lutomirski wrote: > 1. Just put the NMI unmask in do_nmi(). The kernel *already* knows > how to handle running do_nmi() with NMIs unmasked. This is much, much > simpler than your code. Okay, attached is the updated patch which implements this approa

Re: [PATCH V6 8/8] virtio: Intel IFC VF driver for VDPA

2020-03-20 Thread Jason Wang
On 2020/3/19 下午9:02, Jason Gunthorpe wrote: On Thu, Mar 19, 2020 at 04:14:37PM +0800, Jason Wang wrote: On 2020/3/18 下午8:22, Jason Gunthorpe wrote: On Wed, Mar 18, 2020 at 04:03:27PM +0800, Jason Wang wrote: From: Zhu Lingshan + +static int ifcvf_vdpa_attach(struct ifcvf_adapter *adapter) +{