Re: [External] Re: [PATCH 0/7] Introduce vdpa management tool

On 2020/11/30 下午3:07, Yongji Xie wrote: Thanks for adding me, Jason! Now I'm working on a v2 patchset for VDUSE (vDPA Device in Userspace) [1]. This tool is very useful for the vduse device. So I'm considering integrating this into my v2 patchset. But there is one problem： In this tool, vdpa

Re: [PATCH 000/141] Fix fall-through warnings for Clang

Gustavo, > This series aims to fix almost all remaining fall-through warnings in > order to enable -Wimplicit-fallthrough for Clang. Applied 20-22,54,120-124 to 5.11/scsi-staging, thanks. -- Martin K. Petersen Oracle Linux Engineering ___

Re: [PATCH v2 12/17] vdpa_sim: add get_config callback in vdpasim_dev_attr

On 2020/11/30 下午10:14, Stefano Garzarella wrote: On Mon, Nov 30, 2020 at 11:25:31AM +0800, Jason Wang wrote: On 2020/11/26 下午10:49, Stefano Garzarella wrote: The get_config callback can be used by the device to fill the config structure. The callback will be invoked in vdpasim_get_config()

Re: [PATCH AUTOSEL 5.9 22/33] vhost scsi: add lun parser helper

On Mon, Nov 30, 2020 at 09:29:02PM +0100, Paolo Bonzini wrote: On 30/11/20 20:44, Mike Christie wrote: I have never seen a public/open-source vhost-scsi testsuite. For patch 23 (the one that adds the lun reset support which is built on patch 22), we can't add it to stable right now if you

Re: [PATCH AUTOSEL 5.9 22/33] vhost scsi: add lun parser helper

On 30/11/20 20:44, Mike Christie wrote: I have never seen a public/open-source vhost-scsi testsuite. For patch 23 (the one that adds the lun reset support which is built on patch 22), we can't add it to stable right now if you wanted to, because it has a bug in it. Michael T, sent the fix:

Re: [PATCH AUTOSEL 5.9 22/33] vhost scsi: add lun parser helper

On 30/11/20 18:38, Sasha Levin wrote: I am not aware of any public CI being done _at all_ done on vhost-scsi, by CKI or everyone else.  So autoselection should be done only on subsystems that have very high coverage in CI. Where can I find a testsuite for virtio/vhost? I see one for KVM, but

Re: [PATCH AUTOSEL 5.9 22/33] vhost scsi: add lun parser helper

On Mon, Nov 30, 2020 at 09:33:46AM +0100, Paolo Bonzini wrote: On 29/11/20 22:06, Sasha Levin wrote: Plus all the testing we have for the stable trees, yes. It goes beyond just compiling at this point. Your very own co-workers (https://cki-project.org/) are pushing hard on this effort around

Re: [PATCH AUTOSEL 5.9 22/33] vhost scsi: add lun parser helper

On Mon, Nov 30, 2020 at 03:00:13PM +0100, Paolo Bonzini wrote: On 30/11/20 14:57, Greg KH wrote: Every patch should be "fixing a real issue"---even a new feature. But the larger the patch, the more the submitters and maintainers should be trusted rather than a bot. The line between feature

Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance

On Mon, Nov 30, 2020 at 06:41:45PM +0800, Cindy Lu wrote: > On Mon, Nov 30, 2020 at 5:33 PM Michael S. Tsirkin wrote: > > > > On Mon, Nov 30, 2020 at 11:27:59AM +0200, Eli Cohen wrote: > > > On Mon, Nov 30, 2020 at 04:00:51AM -0500, Michael S. Tsirkin wrote: > > > > On Mon, Nov 30, 2020 at

Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance

On Mon, Nov 30, 2020 at 01:51:06PM +0200, Eli Cohen wrote: > On Mon, Nov 30, 2020 at 04:33:09AM -0500, Michael S. Tsirkin wrote: > > On Mon, Nov 30, 2020 at 11:27:59AM +0200, Eli Cohen wrote: > > > On Mon, Nov 30, 2020 at 04:00:51AM -0500, Michael S. Tsirkin wrote: > > > > On Mon, Nov 30, 2020 at

Re: [PATCH v2 17/17] vdpa: split vdpasim to core and net modules

On Mon, Nov 30, 2020 at 11:31:43AM +0800, Jason Wang wrote: On 2020/11/26 下午10:49, Stefano Garzarella wrote: From: Max Gurtovoy Introduce new vdpa_sim_net and vdpa_sim (core) drivers. This is a preparation for adding a vdpa simulator module for block devices. Signed-off-by: Max Gurtovoy

Re: [PATCH v2 13/17] vdpa_sim: set vringh notify callback

On Mon, Nov 30, 2020 at 11:27:51AM +0800, Jason Wang wrote: On 2020/11/26 下午10:49, Stefano Garzarella wrote: Instead of calling the vq callback directly, we can leverage the vringh_notify() function, adding vdpasim_vq_notify() and setting it in the vringh notify callback. Suggested-by: Jason

Re: [PATCH v2 12/17] vdpa_sim: add get_config callback in vdpasim_dev_attr

On Mon, Nov 30, 2020 at 11:25:31AM +0800, Jason Wang wrote: On 2020/11/26 下午10:49, Stefano Garzarella wrote: The get_config callback can be used by the device to fill the config structure. The callback will be invoked in vdpasim_get_config() before copying bytes into caller buffer. Move

Re: [PATCH AUTOSEL 5.9 22/33] vhost scsi: add lun parser helper

On 30/11/20 14:57, Greg KH wrote: Every patch should be "fixing a real issue"---even a new feature. But the larger the patch, the more the submitters and maintainers should be trusted rather than a bot. The line between feature and bugfix_sometimes_ is blurry, I would say that in this case

Re: [PATCH AUTOSEL 5.9 22/33] vhost scsi: add lun parser helper

On Mon, Nov 30, 2020 at 02:52:11PM +0100, Paolo Bonzini wrote: > On 30/11/20 14:28, Greg KH wrote: > > > > Lines of code is not everything. If you think that this needs additional > > > > testing then that's fine and we can drop it, but not picking up a fix > > > > just because it's 120 lines is

Doctoral Symposium - CISTI 2021, Chaves, Portugal

-- -- -- -- Doctoral Symposium CISTI 2021 - 16th Iberian Conference on Information Systems and Technologies, Chaves, Portugal, 23 - 26 June 2021 http://www.cisti.eu/

Re: [PATCH AUTOSEL 5.9 22/33] vhost scsi: add lun parser helper

On 30/11/20 14:28, Greg KH wrote: Lines of code is not everything. If you think that this needs additional testing then that's fine and we can drop it, but not picking up a fix just because it's 120 lines is not something we'd do. Starting with the first two steps in stable-kernel-rules.rst:

Re: [PATCH AUTOSEL 5.9 22/33] vhost scsi: add lun parser helper

On Mon, Nov 30, 2020 at 09:33:46AM +0100, Paolo Bonzini wrote: > On 29/11/20 22:06, Sasha Levin wrote: > > On Sun, Nov 29, 2020 at 06:34:01PM +0100, Paolo Bonzini wrote: > > > On 29/11/20 05:13, Sasha Levin wrote: > > > > > Which doesn't seem to be suitable for stable either...  Patch 3/5 in > > >

Re: [PATCH v2 04/17] vdpa_sim: remove the limit of IOTLB entries

On Mon, Nov 30, 2020 at 11:07:08AM +0800, Jason Wang wrote: On 2020/11/26 下午10:49, Stefano Garzarella wrote: The simulated devices can support multiple queues, so this limit should be defined according to the number of queues supported by the device. Since we are in a simulator, let's simply

Re: [PATCH v2 02/17] vdpa_sim: remove unnecessary headers inclusion

On Mon, Nov 30, 2020 at 11:04:49AM +0800, Jason Wang wrote: On 2020/11/26 下午10:49, Stefano Garzarella wrote: Some headers are not necessary, so let's remove them to do some cleaning. Signed-off-by: Stefano Garzarella --- drivers/vdpa/vdpa_sim/vdpa_sim.c | 13 - 1 file changed,

Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance

On Mon, Nov 30, 2020 at 11:27:59AM +0200, Eli Cohen wrote: > On Mon, Nov 30, 2020 at 04:00:51AM -0500, Michael S. Tsirkin wrote: > > On Mon, Nov 30, 2020 at 08:27:46AM +0200, Eli Cohen wrote: > > > On Sun, Nov 29, 2020 at 03:08:22PM -0500, Michael S. Tsirkin wrote: > > > > On Sun, Nov 29, 2020 at

Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance

On Mon, Nov 30, 2020 at 08:27:46AM +0200, Eli Cohen wrote: > On Sun, Nov 29, 2020 at 03:08:22PM -0500, Michael S. Tsirkin wrote: > > On Sun, Nov 29, 2020 at 08:43:51AM +0200, Eli Cohen wrote: > > > We should not try to use the VF MAC address as that is used by the > > > regular (e.g. mlx5_core)

[GIT PULL] vhost,vdpa: bugfixes

The following changes since commit 418baf2c28f3473039f2f7377760bd8f6897ae18: Linux 5.10-rc5 (2020-11-22 15:36:08 -0800) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to

Re: [PATCH AUTOSEL 5.9 22/33] vhost scsi: add lun parser helper

On 29/11/20 22:06, Sasha Levin wrote: On Sun, Nov 29, 2020 at 06:34:01PM +0100, Paolo Bonzini wrote: On 29/11/20 05:13, Sasha Levin wrote: Which doesn't seem to be suitable for stable either...  Patch 3/5 in Why not? It was sent as a fix to Linus. Dunno, 120 lines of new code?  Even if