Re: [PATCH] vdpa/mlx5: Use write memory barrier after updating CQ index

2020-12-06 Thread Jason Wang
On 2020/12/6 下午6:57, Eli Cohen wrote: Make sure to put write memory barrier after updating CQ consumer index so the hardware knows that there are available CQE slots in the queue. Failure to do this can cause the update of the RX doorbell record to get updated before the CQ consumer index resul

Re: [PATCH v2 2/2] drivers: gpio: add virtio-gpio guest driver

2020-12-06 Thread Jason Wang
On 2020/12/6 上午3:32, Michael S. Tsirkin wrote: On Sat, Dec 05, 2020 at 08:59:55AM +0100, Enrico Weigelt, metux IT consult wrote: On 04.12.20 04:35, Jason Wang wrote: --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -1615,6 +1615,15 @@ config GPIO_MOCKUP         tools/testing/s

Re: [PATCH v2 2/2] drivers: gpio: add virtio-gpio guest driver

2020-12-06 Thread Jason Wang
On 2020/12/6 上午4:05, Enrico Weigelt, metux IT consult wrote: On 05.12.20 20:32, Michael S. Tsirkin wrote: Hi, It seems a bit of a mess, at this point I'm not entirely sure when should drivers select VIRTIO and when depend on it. if VIRTIO just enables something that could be seen as library

Re: [PATCH V2 19/19] vdpa: introduce virtio pci driver

2020-12-06 Thread Jason Wang
On 2020/12/5 上午1:12, Randy Dunlap wrote: On 12/4/20 7:20 AM, Stefano Garzarella wrote: On Fri, Dec 04, 2020 at 12:03:53PM +0800, Jason Wang wrote: This patch introduce a vDPA driver for virtio-pci device. It bridges the virtio-pci control command to the vDPA bus. This will be used for features

Re: [PATCH v2 2/2] drivers: gpio: add virtio-gpio guest driver

2020-12-06 Thread Jason Wang
On 2020/12/4 下午5:36, Enrico Weigelt, metux IT consult wrote: On 04.12.20 04:35, Jason Wang wrote: Hi, Is the plan to keep this doc synced with the one in the virtio specification? Yes, of course. I'm still in progress of doing the beaurocratic stuff w/ virtio-tc folks (ID registration, ...)

Re: [PATCH net-next] tun: fix ubuf refcount incorrectly on error path

2020-12-06 Thread Jason Wang
On 2020/12/4 下午6:22, wangyunjian wrote: -Original Message- From: Jason Wang [mailto:jasow...@redhat.com] Sent: Friday, December 4, 2020 2:11 PM To: wangyunjian ; m...@redhat.com Cc: virtualization@lists.linux-foundation.org; net...@vger.kernel.org; Lilijun (Jerry) ; xudingke Subject: Re

Re: [PATCH v3 04/19] vhost/iotlb: add VHOST_IOTLB_UNLIMITED macro

2020-12-06 Thread Jason Wang
On 2020/12/4 上午1:04, Stefano Garzarella wrote: It's possible to allocate an unlimited IOTLB calling vhost_iotlb_alloc() with 'limit' = 0. Add a new macro (VHOST_IOTLB_UNLIMITED) for this case and document it in the vhost_iotlb_alloc() documentation block. Suggested-by: Jason Wang Signed-off-b

Re: [PATCH v3 05/19] vdpa_sim: remove the limit of IOTLB entries

2020-12-06 Thread Jason Wang
On 2020/12/4 上午1:04, Stefano Garzarella wrote: The simulated devices can support multiple queues, so this limit should be defined according to the number of queues supported by the device. Since we are in a simulator, let's simply remove that limit. Suggested-by: Jason Wang Acked-by: Jason Wa

Re: [RFC PATCH 5/8] vhost: allow userspace to bind vqs to CPUs

2020-12-06 Thread Jason Wang
On 2020/12/5 上午12:32, Mike Christie wrote: On 12/4/20 2:09 AM, Jason Wang wrote: On 2020/12/4 下午3:56, Mike Christie wrote: +static long vhost_vring_set_cpu(struct vhost_dev *d, struct vhost_virtqueue *vq, +    void __user *argp) +{ +    struct vhost_vring_state s; +    int ret =

Re: [PATCH] vhost scsi: fix error return code in vhost_scsi_set_endpoint()

2020-12-06 Thread Jason Wang
On 2020/12/4 下午4:43, Zhang Changzhong wrote: Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 25b98b64e284 ("vhost scsi: alloc cmds per vq instead of session") Reported-by: Hulk Robot Signed-off-by: Zhang Changzhong ---

Re: [PATCH v3 12/19] vdpa_sim: make 'config' generic and usable for any device type

2020-12-06 Thread Jason Wang
On 2020/12/4 上午1:05, Stefano Garzarella wrote: Add new 'config_size' attribute in 'vdpasim_dev_attr' and allocates 'config' dynamically to support any device types. Signed-off-by: Stefano Garzarella --- drivers/vdpa/vdpa_sim/vdpa_sim.c | 17 + 1 file changed, 13 insertions(+

Re: [PATCH v3 13/19] vdpa_sim: add get_config callback in vdpasim_dev_attr

2020-12-06 Thread Jason Wang
On 2020/12/4 上午1:05, Stefano Garzarella wrote: The get_config callback can be used by the device to fill the config structure. The callback will be invoked in vdpasim_get_config() before copying bytes into caller buffer. Move vDPA-net config updates from vdpasim_set_features() in the new vdpasi

Re: [PATCH v3 14/19] vdpa_sim: add set_config callback in vdpasim_dev_attr

2020-12-06 Thread Jason Wang
On 2020/12/4 上午1:05, Stefano Garzarella wrote: The set_config callback can be used by the device to parse the config structure modified by the driver. The callback will be invoked, if set, in vdpasim_set_config() after copying bytes from caller buffer into vdpasim->config buffer. Signed-off-by

Re: [PATCH v3 15/19] vdpa_sim: set vringh notify callback

2020-12-06 Thread Jason Wang
On 2020/12/4 上午1:05, Stefano Garzarella wrote: Instead of calling the vq callback directly, we can leverage the vringh_notify() function, adding vdpasim_vq_notify() and setting it in the vringh notify callback. Suggested-by: Jason Wang Signed-off-by: Stefano Garzarella Acked-by: Jason Wang

Re: [PATCH v3 19/19] vdpa: split vdpasim to core and net modules

2020-12-06 Thread Jason Wang
On 2020/12/4 上午1:05, Stefano Garzarella wrote: From: Max Gurtovoy Introduce new vdpa_sim_net and vdpa_sim (core) drivers. This is a preparation for adding a vdpa simulator module for block devices. Signed-off-by: Max Gurtovoy [sgarzare: various cleanups/fixes] Signed-off-by: Stefano Garzarella