在 2021/4/15 下午6:27, Xuan Zhuo 写道:
On Wed, 14 Apr 2021 13:46:45 +0800, Jason Wang wrote:
在 2021/4/13 上午11:15, Xuan Zhuo 写道:
This patch implements the core part of xsk zerocopy xmit.
When the user calls sendto to consume the data in the xsk tx queue,
virtnet_xsk_wakeup() will be called.
In
在 2021/3/31 下午4:05, Xie Yongji 写道:
+ }
+ case VDUSE_INJECT_VQ_IRQ:
+ ret = -EINVAL;
+ if (arg >= dev->vq_num)
+ break;
+
+ ret = 0;
+ queue_work(vduse_irq_wq, >vqs[arg].inject);
+ break;
在 2021/4/16 上午10:58, Yongji Xie 写道:
On Fri, Apr 16, 2021 at 10:20 AM Jason Wang wrote:
在 2021/4/15 下午7:17, Yongji Xie 写道:
On Thu, Apr 15, 2021 at 5:05 PM Jason Wang wrote:
在 2021/4/15 下午4:36, Jason Wang 写道:
Please state this explicitly at the start of the document. Existing
interfaces
在 2021/4/16 上午1:27, Mike Christie 写道:
We use like 3 coding styles in this struct. Switch to just tabs.
Signed-off-by: Mike Christie
Reviewed-by: Chaitanya Kulkarni
Reviewed-by: Stefan Hajnoczi
---
Acked-by: Jason Wang
drivers/vhost/vhost.h | 12 ++--
1 file changed, 6
On 4/15/2021 9:41 PM, Stefano Garzarella wrote:
On Thu, Apr 15, 2021 at 05:53:35PM +0800, Zhu Lingshan wrote:
This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-block
for vDPA.
Signed-off-by: Zhu Lingshan
---
drivers/vdpa/ifcvf/ifcvf_base.h | 8 +++-
On 4/15/2021 9:48 PM, Stefano Garzarella wrote:
On Thu, Apr 15, 2021 at 05:53:36PM +0800, Zhu Lingshan wrote:
get_config_size() should return the size based on the decected
device type.
Signed-off-by: Zhu Lingshan
---
drivers/vdpa/ifcvf/ifcvf_main.c | 18 +-
1 file changed,
在 2021/4/16 上午1:27, Mike Christie 写道:
The vhost work flush function was flushing the entire work queue, so
there is no need for the double vhost_work_dev_flush calls in
vhost_scsi_flush.
And we do not need to call vhost_poll_flush for each poller because
that call also ends up flushing the
在 2021/4/15 下午10:38, Stefan Hajnoczi 写道:
On Thu, Apr 15, 2021 at 04:36:35PM +0800, Jason Wang wrote:
在 2021/4/15 下午3:19, Stefan Hajnoczi 写道:
On Thu, Apr 15, 2021 at 01:38:37PM +0800, Yongji Xie wrote:
On Wed, Apr 14, 2021 at 10:15 PM Stefan Hajnoczi wrote:
On Wed, Mar 31, 2021 at
在 2021/4/15 下午7:17, Yongji Xie 写道:
On Thu, Apr 15, 2021 at 5:05 PM Jason Wang wrote:
在 2021/4/15 下午4:36, Jason Wang 写道:
Please state this explicitly at the start of the document. Existing
interfaces like FUSE are designed to avoid trusting userspace.
There're some subtle difference here.
Hi
Am 15.04.21 um 14:57 schrieb Daniel Vetter:
On Thu, Apr 15, 2021 at 08:56:20AM +0200, Thomas Zimmermann wrote:
Hi
Am 09.04.21 um 11:22 schrieb Daniel Vetter:
Is it that easy? simepldrm's detach function has code to synchronize
with
concurrent hotplug removals. If we can use
On Wed, Apr 14, 2021 at 09:44:35AM +0100, Stefan Hajnoczi wrote:
> On Mon, Apr 12, 2021 at 10:42:17AM +0100, Christoph Hellwig wrote:
> > A note to the virtio committee: eMMC is the worst of all the currently
> > active storage standards by a large margin. It defines very strange
> > ad-hoc
On Mon, Apr 12, 2021 at 08:00:24AM -0400, Michael S. Tsirkin wrote:
> On Mon, Apr 12, 2021 at 10:42:17AM +0100, Christoph Hellwig wrote:
> > A note to the virtio committee: eMMC is the worst of all the currently
> > active storage standards by a large margin. It defines very strange
> > ad-hoc
On Thu, Mar 18, 2021 at 02:28:02PM -0400, Michael S. Tsirkin wrote:
> On Tue, Mar 16, 2021 at 08:16:54PM +0100, Jean-Philippe Brucker wrote:
> > With the VIOT support in place, x86 platforms can now use the
> > virtio-iommu.
> >
> > The arm64 Kconfig selects IOMMU_DMA, while x86 IOMMU drivers
On Thu, Mar 18, 2021 at 11:43:38AM +, Robin Murphy wrote:
> On 2021-03-16 19:16, Jean-Philippe Brucker wrote:
> > With the VIOT support in place, x86 platforms can now use the
> > virtio-iommu.
> >
> > The arm64 Kconfig selects IOMMU_DMA, while x86 IOMMU drivers select it
> > themselves.
>
>
On Fri, Mar 19, 2021 at 11:44:26AM +0100, Auger Eric wrote:
> add some kernel-doc comments matching the explanation in the commit message?
Yes, I'll add some comments. I got rid of the other issues you pointed out
while reworking the driver, should be more straightforward now
Thanks,
Jean
On Thu, Apr 15, 2021 at 04:36:35PM +0800, Jason Wang wrote:
>
> 在 2021/4/15 下午3:19, Stefan Hajnoczi 写道:
> > On Thu, Apr 15, 2021 at 01:38:37PM +0800, Yongji Xie wrote:
> > > On Wed, Apr 14, 2021 at 10:15 PM Stefan Hajnoczi
> > > wrote:
> > > > On Wed, Mar 31, 2021 at 04:05:19PM +0800, Xie
On Thu, Mar 18, 2021 at 06:52:44PM +0100, Auger Eric wrote:
> Besides
> Reviewed-by: Eric Auger
Thanks, though this patch comes from ACPICA and has now been merged with
the other ACPICA updates:
https://lore.kernel.org/linux-acpi/20210406213028.718796-1-erik.kan...@intel.com/
Thanks,
Jean
On Thu, Mar 18, 2021 at 07:36:50PM +, Robin Murphy wrote:
> On 2021-03-16 19:16, Jean-Philippe Brucker wrote:
> > The ACPI Virtual I/O Translation Table describes topology of
> > para-virtual platforms. For now it describes the relation between
> > virtio-iommu and the endpoints it manages.
On Thu, Apr 15, 2021 at 04:33:27PM +0800, Yongji Xie wrote:
> On Thu, Apr 15, 2021 at 3:19 PM Stefan Hajnoczi wrote:
> > On Thu, Apr 15, 2021 at 01:38:37PM +0800, Yongji Xie wrote:
> > > On Wed, Apr 14, 2021 at 10:15 PM Stefan Hajnoczi
> > > wrote:
> > > > On Wed, Mar 31, 2021 at 04:05:19PM
On Thu, Apr 15, 2021 at 05:53:36PM +0800, Zhu Lingshan wrote:
get_config_size() should return the size based on the decected
device type.
Signed-off-by: Zhu Lingshan
---
drivers/vdpa/ifcvf/ifcvf_main.c | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git
On Thu, Apr 15, 2021 at 05:53:35PM +0800, Zhu Lingshan wrote:
This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-block
for vDPA.
Signed-off-by: Zhu Lingshan
---
drivers/vdpa/ifcvf/ifcvf_base.h | 8 +++-
drivers/vdpa/ifcvf/ifcvf_main.c | 10 +-
2 files changed, 16
On Thu, Apr 15, 2021 at 08:56:20AM +0200, Thomas Zimmermann wrote:
> Hi
>
> Am 09.04.21 um 11:22 schrieb Daniel Vetter:
> > > Is it that easy? simepldrm's detach function has code to synchronize with
> > > concurrent hotplug removals. If we can use drm_dev_unplug() for
> > > everything,
> > >
On 15.04.2021 07:26, Randy Dunlap wrote:
Fix kernel-doc warning that the wrong function name is used in a
kernel-doc comment:
../sound/virtio/virtio_ctl_msg.c:70: warning: expecting prototype for
virtsnd_ctl_msg_request(). Prototype was for virtsnd_ctl_msg_response() instead
Signed-off-by:
Hi
Am 15.04.21 um 11:21 schrieb Maxime Ripard:
Hi,
On Thu, Apr 15, 2021 at 09:31:01AM +0200, Thomas Zimmermann wrote:
Am 08.04.21 um 10:13 schrieb Maxime Ripard:
Hi,
On Thu, Mar 18, 2021 at 11:29:19AM +0100, Thomas Zimmermann wrote:
Make sure required hardware clocks are enabled while the
在 2021/4/15 下午4:36, Jason Wang 写道:
Please state this explicitly at the start of the document. Existing
interfaces like FUSE are designed to avoid trusting userspace.
There're some subtle difference here. VDUSE present a device to kernel
which means IOMMU is probably the only thing to
The blitter functions copy a framebuffer to I/O memory using one of
the existing conversion functions.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Daniel Vetter
Tested-by: nerdopolis
---
drivers/gpu/drm/drm_format_helper.c | 87 +
include/drm/drm_format_helper.h
We register the simplekms device with the DRM platform helpers. A
native driver for the graphics hardware will kick-out the simpledrm
driver before taking over the device.
The original generic platform device from the simple-framebuffer boot
code will be unregistered. The native driver will use
This patchset adds support for simple-framebuffer platform devices and
a handover mechanism for native drivers to take-over control of the
hardware.
The new driver, called simpledrm, binds to a simple-frambuffer platform
device. The kernel's boot code creates such devices for firmware-provided
A firmware framebuffer might also be specified via device-tree files. If
no device platform data is given, try the DT device node.
v2:
* add Device Tree match table
* clean-up parser wrappers
Signed-off-by: Thomas Zimmermann
Tested-by: nerdopolis
---
Make sure required hardware regulators are enabled while the firmware
framebuffer is in use.
The basic code has been taken from the simplefb driver and adapted
to DRM. Regulators are released automatically via devres helpers.
v2:
* use strscpy()
Signed-off-by: Thomas Zimmermann
This displays a console on simpledrm's framebuffer. The default
framebuffer format is being used.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Daniel Vetter
Tested-by: nerdopolis
---
drivers/gpu/drm/tiny/simpledrm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
The memcpy's destination buffer might have a different pitch than the
source. Support different pitches as function argument.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Daniel Vetter
Tested-by: nerdopolis
---
drivers/gpu/drm/drm_format_helper.c| 9 +
The simpledrm driver is a DRM driver for simplefb framebuffers as
provided by the kernel's boot code. This driver enables basic
graphical output on many different graphics devices that are provided
by the platform (e.g., EFI, VESA, embedded framebuffers).
With the kernel's simplefb
Make sure required hardware clocks are enabled while the firmware
framebuffer is in use.
The basic code has been taken from the simplefb driver and adapted
to DRM. Clocks are released automatically via devres helpers.
Signed-off-by: Thomas Zimmermann
Tested-by: nerdopolis
---
Platform devices might operate on firmware framebuffers, such as VESA or
EFI. Before a native driver for the graphics hardware can take over the
device, it has to remove any platform driver that operates on the firmware
framebuffer. Aperture helpers provide the infrastructure for platform
drivers
在 2021/4/15 下午3:19, Stefan Hajnoczi 写道:
On Thu, Apr 15, 2021 at 01:38:37PM +0800, Yongji Xie wrote:
On Wed, Apr 14, 2021 at 10:15 PM Stefan Hajnoczi wrote:
On Wed, Mar 31, 2021 at 04:05:19PM +0800, Xie Yongji wrote:
VDUSE (vDPA Device in Userspace) is a framework to support
implementing
On Thu, Apr 15, 2021 at 04:23:15PM +0800, Zhu Lingshan wrote:
On 4/15/2021 4:12 PM, Stefano Garzarella wrote:
On Wed, Apr 14, 2021 at 05:18:32PM +0800, Zhu Lingshan wrote:
get_config_size() should return the size based on the decected
device type.
Signed-off-by: Zhu Lingshan
---
On 4/15/2021 4:12 PM, Stefano Garzarella wrote:
On Wed, Apr 14, 2021 at 05:18:32PM +0800, Zhu Lingshan wrote:
get_config_size() should return the size based on the decected
device type.
Signed-off-by: Zhu Lingshan
---
drivers/vdpa/ifcvf/ifcvf_main.c | 11 ++-
1 file changed, 10
On 2021/4/15 16:18, Wolfram Sang wrote:
On Thu, Apr 15, 2021 at 04:15:07PM +0800, Jie Deng wrote:
On 2021/4/15 15:28, Wolfram Sang wrote:
Now that we were able to catch you, I will use the opportunity to
clarify the doubts I had.
- struct mutex lock in struct virtio_i2c, I don't think this
在 2021/4/15 下午4:12, Stefano Garzarella 写道:
On Wed, Apr 14, 2021 at 05:18:32PM +0800, Zhu Lingshan wrote:
get_config_size() should return the size based on the decected
device type.
Signed-off-by: Zhu Lingshan
---
drivers/vdpa/ifcvf/ifcvf_main.c | 11 ++-
1 file changed, 10
On 2021/4/15 15:28, Wolfram Sang wrote:
Now that we were able to catch you, I will use the opportunity to
clarify the doubts I had.
- struct mutex lock in struct virtio_i2c, I don't think this is
required since the core takes care of locking in absence of this.
This is likely correct.
On Wed, Apr 14, 2021 at 05:18:32PM +0800, Zhu Lingshan wrote:
get_config_size() should return the size based on the decected
device type.
Signed-off-by: Zhu Lingshan
---
drivers/vdpa/ifcvf/ifcvf_main.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git
This patch reports the per vq doorbell location and size to vDPA
bus. Userspace can then map the doorbell via mmap() via vhost-vDPA bus
driver.
Signed-off-by: Jason Wang
---
drivers/vdpa/virtio_pci/vp_vdpa.c | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git
Sometimes it might be useful to report the capability physical
address. One example is to report the physical address of the doorbell
in order to be mapped by userspace.
Signed-off-by: Jason Wang
---
drivers/vdpa/virtio_pci/vp_vdpa.c | 3 ++-
drivers/virtio/virtio_pci_modern.c | 2 +-
No user now and the capability should not be setup
externally. Instead, every access to the capability should be done via
virtio_pci_modern_device.
Signed-off-by: Jason Wang
---
drivers/virtio/virtio_pci_modern_dev.c | 10 --
include/linux/virtio_pci_modern.h | 5 -
2 files
All users (both virtio-pci library and vp_vdpa driver) has been
switched to use vp_modern_map_vq_notify(). So there's no need to
export the low level helper of vp_modern_get_queue_notify_off().
Signed-off-by: Jason Wang
---
drivers/virtio/virtio_pci_modern_dev.c | 5 ++---
This patch switches to use vp_vdpa to use vp_modern_map_notify().
Signed-off-by: Jason Wang
---
drivers/vdpa/virtio_pci/vp_vdpa.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c
b/drivers/vdpa/virtio_pci/vp_vdpa.c
index
This patch switch to use vp_modern_map_notify() for virtio-pci
library.
Signed-off-by: Jason Wang
---
drivers/virtio/virtio_pci_modern.c | 27 ++-
1 file changed, 2 insertions(+), 25 deletions(-)
diff --git a/drivers/virtio/virtio_pci_modern.c
This patch factors out the logic of vq notify area mapping. Following
patches will switch to use this common helpers for both virtio_pci
library and virtio-pci vDPA driver.
Signed-off-by: Jason Wang
---
drivers/virtio/virtio_pci_modern_dev.c | 35 ++
Hi All:
This series implements the doorbell mapping support for virtio-pci
vDPA driver. Tested with page-per-vq=on in a nested guest.
Please review
Thanks
Jason Wang (7):
virtio_pci_modern: introduce helper to map vq notify area
virtio-pci library: switch to use vp_modern_map_vq_notify()
Hi
Am 08.04.21 um 10:13 schrieb Maxime Ripard:
Hi,
On Thu, Mar 18, 2021 at 11:29:19AM +0100, Thomas Zimmermann wrote:
Make sure required hardware clocks are enabled while the firmware
framebuffer is in use.
The basic code has been taken from the simplefb driver and adapted
to DRM. Clocks are
On 4/15/2021 3:17 PM, Jason Wang wrote:
在 2021/4/15 下午2:41, Zhu Lingshan 写道:
I think we've discussed this sometime in the past but what's the
reason for such whitelist consider there's already a
get_features() implemention?
E.g Any reason to block VIRTIO_BLK_F_WRITE_ZEROS or
On 4/15/2021 3:16 PM, Jason Wang wrote:
在 2021/4/15 下午2:36, Zhu Lingshan 写道:
On 4/15/2021 2:30 PM, Jason Wang wrote:
在 2021/4/15 下午1:52, Zhu Lingshan 写道:
On 4/15/2021 11:30 AM, Jason Wang wrote:
在 2021/4/14 下午5:18, Zhu Lingshan 写道:
This commit deduces VIRTIO device ID as device
On Thu, Apr 15, 2021 at 01:38:37PM +0800, Yongji Xie wrote:
> On Wed, Apr 14, 2021 at 10:15 PM Stefan Hajnoczi wrote:
> >
> > On Wed, Mar 31, 2021 at 04:05:19PM +0800, Xie Yongji wrote:
> > > VDUSE (vDPA Device in Userspace) is a framework to support
> > > implementing software-emulated vDPA
在 2021/4/15 下午2:41, Zhu Lingshan 写道:
I think we've discussed this sometime in the past but what's the
reason for such whitelist consider there's already a get_features()
implemention?
E.g Any reason to block VIRTIO_BLK_F_WRITE_ZEROS or
VIRTIO_F_RING_PACKED?
Thanks
The reason is some
在 2021/4/15 下午2:36, Zhu Lingshan 写道:
On 4/15/2021 2:30 PM, Jason Wang wrote:
在 2021/4/15 下午1:52, Zhu Lingshan 写道:
On 4/15/2021 11:30 AM, Jason Wang wrote:
在 2021/4/14 下午5:18, Zhu Lingshan 写道:
This commit deduces VIRTIO device ID as device type when probe,
then
Hi
Am 09.04.21 um 11:22 schrieb Daniel Vetter:
Is it that easy? simepldrm's detach function has code to synchronize with
concurrent hotplug removals. If we can use drm_dev_unplug() for everything,
I'm all for it.
Uh, I should have looked at the code instead of just asking silly
questions :-)
On 2021/4/15 14:45, Viresh Kumar wrote:
On 23-03-21, 10:27, Arnd Bergmann wrote:
I usually recommend the use of __maybe_unused for the suspend/resume
callbacks for drivers that use SIMPLE_DEV_PM_OPS() or similar helpers
that hide the exact conditions under which the functions get called.
In
On 4/15/2021 2:31 PM, Jason Wang wrote:
在 2021/4/15 下午1:55, Zhu Lingshan 写道:
On 4/15/2021 11:34 AM, Jason Wang wrote:
在 2021/4/14 下午5:18, Zhu Lingshan 写道:
This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-block
for vDPA.
Signed-off-by: Zhu Lingshan
---
On 4/15/2021 2:30 PM, Jason Wang wrote:
在 2021/4/15 下午1:52, Zhu Lingshan 写道:
On 4/15/2021 11:30 AM, Jason Wang wrote:
在 2021/4/14 下午5:18, Zhu Lingshan 写道:
This commit deduces VIRTIO device ID as device type when probe,
then ifcvf_vdpa_get_device_id() can simply return the ID.
在 2021/4/15 下午1:55, Zhu Lingshan 写道:
On 4/15/2021 11:34 AM, Jason Wang wrote:
在 2021/4/14 下午5:18, Zhu Lingshan 写道:
This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-block
for vDPA.
Signed-off-by: Zhu Lingshan
---
drivers/vdpa/ifcvf/ifcvf_base.h | 17 -
在 2021/4/15 下午1:52, Zhu Lingshan 写道:
On 4/15/2021 11:30 AM, Jason Wang wrote:
在 2021/4/14 下午5:18, Zhu Lingshan 写道:
This commit deduces VIRTIO device ID as device type when probe,
then ifcvf_vdpa_get_device_id() can simply return the ID.
ifcvf_vdpa_get_features() and
On 2021/4/14 11:52, Viresh Kumar wrote:
Is i2c/for-next the right tree to merge it
?
It should be.
Thanks Viresh.
Hi Wolfram,
Do you have any comments for this patch ? Your opinion will be important
to improve this patch
since you are the maintainer of I2C.
Thanks,
Jie
On 2021/4/15 11:51, Jason Wang wrote:
+ for (i = 0; i < nr; i++) {
+ /* Detach the ith request from the vq */
+ req = virtqueue_get_buf(vq, );
+
+ /*
+ * Condition (req && req == [i]) should always meet since
+ * we have total nr requests in the vq.
64 matches
Mail list logo
