Re: [PATCH] Provide detailed specification of virtio-blk lifetime metrics

2021-05-04 Thread Christoph Hellwig
On Tue, Apr 20, 2021 at 04:25:56PM +, Enrico Granata wrote: > In the course of review, some concerns were surfaced about the > original virtio-blk lifetime proposal, as it depends on the eMMC > spec which is not open > > Add a more detailed description of the meaning of the fields > added by t

Re: virtio_net: Almost a second until link becomes ready

2021-05-04 Thread Michael S. Tsirkin
On Tue, May 04, 2021 at 08:04:50PM +0200, Paul Menzel wrote: > Dear VirtIO net driver folks, > > > I would like to start the video conferencing software Jitsi in a QEMU/KVM VM > as quickly as possible. > > ``` > $ qemu-system-x86_64 --version > QEMU emulator version 5.1.0 > Copyright (c) 2003-20

Re: [PATCH RFC 00/14] vhost: multiple worker support

2021-05-04 Thread Mike Christie
On 5/4/21 10:56 AM, Stefano Garzarella wrote: > Hi Mike, > > On Wed, Apr 28, 2021 at 05:36:59PM -0500, Mike Christie wrote: >> The following patches apply over mst's vhost branch and were tested >> againt that branch and also mkp's 5.13 branch which has some vhost-scsi >> changes. >> >> These patc

Re: [PATCH RFC 12/14] vhost: add vhost_dev pointer to vhost_work

2021-05-04 Thread Mike Christie
On 5/4/21 10:33 AM, Stefano Garzarella wrote: > On Wed, Apr 28, 2021 at 05:37:12PM -0500, Mike Christie wrote: >> The next patch allows a vhost_worker to handle different devices. To >> prepare for that, this patch adds a pointer to the device on the work so >> we can get to the different mms in th

Re: [PATCH RFC 11/14] vhost: allow userspace to create workers

2021-05-04 Thread Mike Christie
On 5/4/21 10:30 AM, Stefano Garzarella wrote: > On Wed, Apr 28, 2021 at 05:37:11PM -0500, Mike Christie wrote: >> This patch allows userspace to create workers and bind them to vqs, so you >> can have N workers per dev and also share N workers with M vqs. The next >> patch will allow sharing across

Re: Re: [RFC v2] virtio-vsock: add description for datagram type

2021-05-04 Thread Jiang Wang .
On Tue, May 4, 2021 at 9:16 AM Stefano Garzarella wrote: > > Hi Jiang, > > On Mon, May 03, 2021 at 08:40:46PM -0700, Jiang Wang . wrote: > >Hi Stefano, > > > >I checked the VIRTIO_NET_F_MRG_RXBUF feature bit and I think vsock > >dgram can use that feature too. > > Cool, thanks for checking! NP.

Re: [RFC v2] virtio-vsock: add description for datagram type

2021-05-04 Thread Stefano Garzarella
Hi Jiang, On Mon, May 03, 2021 at 08:40:46PM -0700, Jiang Wang . wrote: Hi Stefano, I checked the VIRTIO_NET_F_MRG_RXBUF feature bit and I think vsock dgram can use that feature too. Cool, thanks for checking! Do we want to make this feature a must-have or optional? One idea is to make it o

Re: [PATCH RFC 00/14] vhost: multiple worker support

2021-05-04 Thread Stefano Garzarella
Hi Mike, On Wed, Apr 28, 2021 at 05:36:59PM -0500, Mike Christie wrote: The following patches apply over mst's vhost branch and were tested againt that branch and also mkp's 5.13 branch which has some vhost-scsi changes. These patches allow us to support multiple vhost workers per device. I end

Re: [PATCH RFC 12/14] vhost: add vhost_dev pointer to vhost_work

2021-05-04 Thread Stefano Garzarella
On Wed, Apr 28, 2021 at 05:37:12PM -0500, Mike Christie wrote: The next patch allows a vhost_worker to handle different devices. To prepare for that, this patch adds a pointer to the device on the work so we can get to the different mms in the vhost_worker thread. Signed-off-by: Mike Christie -

Re: [PATCH RFC 11/14] vhost: allow userspace to create workers

2021-05-04 Thread Stefano Garzarella
On Wed, Apr 28, 2021 at 05:37:11PM -0500, Mike Christie wrote: This patch allows userspace to create workers and bind them to vqs, so you can have N workers per dev and also share N workers with M vqs. The next patch will allow sharing across devices. Signed-off-by: Mike Christie --- drivers/vh

[PATCH] vhost-iotlb: fix vhost_iotlb_del_range() documentation

2021-05-04 Thread Stefano Garzarella
Trivial change for the vhost_iotlb_del_range() documentation, fixing the function name in the comment block. Discovered with `make C=2 M=drivers/vhost`: ../drivers/vhost/iotlb.c:92: warning: expecting prototype for vring_iotlb_del_range(). Prototype was for vhost_iotlb_del_range() instead Signed

Re: [PATCH] virtio_blk: cleanups: remove check obsoleted by CONFIG_LBDAF removal

2021-05-04 Thread Stefan Hajnoczi
On Fri, Apr 30, 2021 at 12:36:11PM +0200, Sohaib Mohamed wrote: > From: Sohaib > > Prior to 72deb455b5ec ("block: remove CONFIG_LBDAF"), it was optional if > the 32-bit kernel support block device and/or file sizes larger than 2 TiB > (considering the sector size is 512 bytes) > But now sector_t

[PATCH 2/2] virtio_pci_modern: correct sparse tags for notify

2021-05-04 Thread Michael S. Tsirkin
When switching virtio_pci_modern to use a helper for mappings we lost an __iomem tag. Restore it. Reported-by: kernel test robot Fixes: 9e3bb9b79a71 ("virtio_pci_modern: introduce helper to map vq notify area") Signed-off-by: Michael S. Tsirkin --- drivers/virtio/virtio_pci_modern_dev.c | 9 ++

[PATCH 1/2] virtio_pci_modern: __force cast the notify mapping

2021-05-04 Thread Michael S. Tsirkin
When switching virtio_pci_modern to use a helper for mappings we lost an __iomem tag. We should restore it. However, virtio_pci_modern is playing tricks by hiding an iomem pointer in a regular vq->priv pointer. Which is okay as long as it's all contained within a single file, but we need to __forc