Re: Re: [RFC v2] virtio-vsock: add description for datagram type

2021-05-18 Thread Jiang Wang .
On Tue, May 18, 2021 at 6:02 AM Stefano Garzarella wrote: > > On Mon, May 17, 2021 at 11:33:06PM -0700, Jiang Wang . wrote: > >On Mon, May 17, 2021 at 4:02 AM Stefano Garzarella > >wrote: > >> > >> On Fri, May 14, 2021 at 11:55:29AM -0700, Jiang Wang . wrote: > >> >On Fri, May 14, 2021 at 8:17

Re: [PATCH 5.4 042/111] virtio_net: Do not pull payload in skb->head

2021-05-18 Thread Sasha Levin
On Tue, May 18, 2021 at 09:35:26PM +0200, Eric Dumazet wrote: On Mon, Apr 12, 2021 at 11:12 AM Michael S. Tsirkin wrote: Note that an issue related to this patch was recently reported. It's quite possible that the root cause is a bug elsewhere in the kernel, but it probably makes sense to

Re: [RFC v2] virtio-vsock: add description for datagram type

2021-05-18 Thread Stefano Garzarella
On Mon, May 17, 2021 at 11:33:06PM -0700, Jiang Wang . wrote: On Mon, May 17, 2021 at 4:02 AM Stefano Garzarella wrote: On Fri, May 14, 2021 at 11:55:29AM -0700, Jiang Wang . wrote: >On Fri, May 14, 2021 at 8:17 AM Stefano Garzarella wrote: >> On Thu, May 13, 2021 at 04:26:03PM -0700, Jiang

Re: [PATCH 1/3] drm/virtio: Fixes a potential NULL pointer dereference on probe failure

2021-05-18 Thread Gerd Hoffmann
On Mon, May 17, 2021 at 04:49:11PM +0800, Xie Yongji wrote: > The dev->dev_private might not be allocated if virtio_gpu_pci_quirk() > or virtio_gpu_init() failed. In this case, we should avoid the cleanup > in virtio_gpu_release(). Pushed all three to drm-misc-next. thanks, Gerd

Re: [PATCH] virtio_net: Remove BUG() to aviod machine dead

2021-05-18 Thread Michael S. Tsirkin
typo in subject On Tue, May 18, 2021 at 05:46:56PM +0800, Xianting Tian wrote: > When met error, we output a print to avoid a BUG(). > > Signed-off-by: Xianting Tian > --- > drivers/net/virtio_net.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git

Re: Re: [RFC PATCH 00/17] Add validation for used length

2021-05-18 Thread Michael S. Tsirkin
On Tue, May 18, 2021 at 04:29:44PM +0800, Yongji Xie wrote: > On Tue, May 18, 2021 at 7:40 AM Michael S. Tsirkin wrote: > > > > On Mon, May 17, 2021 at 05:08:19PM +0800, Xie Yongji wrote: > > > Current virtio device drivers may trust the used length returned > > > in

Re: [PATCH -next] iommu/virtio: Add missing MODULE_DEVICE_TABLE

2021-05-18 Thread Joerg Roedel
On Sat, May 08, 2021 at 11:14:51AM +0800, Bixuan Cui wrote: > This patch adds missing MODULE_DEVICE_TABLE definition which generates > correct modalias for automatic loading of this driver when it is built > as an external module. > > Reported-by: Hulk Robot > Signed-off-by: Bixuan Cui > --- >

Re: Re: [RFC v2] virtio-vsock: add description for datagram type

2021-05-18 Thread Jiang Wang .
On Mon, May 17, 2021 at 4:02 AM Stefano Garzarella wrote: > > On Fri, May 14, 2021 at 11:55:29AM -0700, Jiang Wang . wrote: > >On Fri, May 14, 2021 at 8:17 AM Stefano Garzarella > >wrote: > >> On Thu, May 13, 2021 at 04:26:03PM -0700, Jiang Wang . wrote: > > [...] > > >> >I see. I will add some