Re: [PATCH net-next] virtio-net: realign page_to_skb() after merges

2021-08-02 Thread Michael S. Tsirkin
On Mon, Aug 02, 2021 at 10:57:29AM -0700, Jakub Kicinski wrote: > We ended up merging two versions of the same patch set: > > commit 8fb7da9e9907 ("virtio_net: get build_skb() buf by data ptr") > commit 5c37711d9f27 ("virtio-net: fix for unable to handle page fault for > address") > > into net,

Re: [PATCH V4 3/5] dt-bindings: gpio: Add bindings for gpio-virtio

2021-08-02 Thread Viresh Kumar
On 02-08-21, 13:40, Rob Herring wrote: > Humm, how does one implement interrupts without a parent interrupt? It > uses the parent virtio,mmio interrupt? Kind of, yeah, but not necessarily. The interrupt information is passed over buffers shared between host and guest. Now the guest may process t

Re: [PATCH net-next] virtio-net: realign page_to_skb() after merges

2021-08-02 Thread Jason Wang
在 2021/8/3 上午1:57, Jakub Kicinski 写道: We ended up merging two versions of the same patch set: commit 8fb7da9e9907 ("virtio_net: get build_skb() buf by data ptr") commit 5c37711d9f27 ("virtio-net: fix for unable to handle page fault for address") into net, and commit 7bf64460e3b2 ("virtio-net

RE: [PATCH v3 0/4] virtio short improvements

2021-08-02 Thread Parav Pandit via Virtualization
Hi Michael, > From: Parav Pandit > Sent: Thursday, July 29, 2021 10:09 AM > > Hi Michael, > > > From: Parav Pandit > > Sent: Wednesday, July 21, 2021 7:57 PM > > To: m...@redhat.com; virtualization@lists.linux-foundation.org > > Cc: Parav Pandit > > Subject: [PATCH v3 0/4] virtio short improve

Re: [PATCH 0/4] Add multi-cid support for vsock driver

2021-08-02 Thread Michael S. Tsirkin
On Mon, Aug 02, 2021 at 08:07:16PM +0800, fuguancheng wrote: > This patchset enables the user to specify additional CIDS for host and > guest when booting up the guest machine. The guest's additional CIDS cannot > be repeated, and can be used to communicate with the host. The user can > also choose

Re: [PATCH 1/4] VSOCK DRIVER: Add multi-cid support for guest

2021-08-02 Thread Michael S. Tsirkin
On Mon, Aug 02, 2021 at 08:07:17PM +0800, fuguancheng wrote: > This patch allowes the user to specify multiple additional CIDS > for the guest that can be used for communication between host > and guest. > > The guest reads the additional cids from the device config space. > The device config spac

Re: [PATCH 2/4] VSOCK DRIVER: support communication using additional guest cid

2021-08-02 Thread Michael S. Tsirkin
On Mon, Aug 02, 2021 at 08:07:18PM +0800, fuguancheng wrote: > Changes in this patch are made to allow the guest communicate > with the host using the additional cids specified when > creating the guest. > > In original settings, the packet sent with the additional CIDS will > be rejected when rec

Re: [PATCH 1/4] VSOCK DRIVER: Add multi-cid support for guest

2021-08-02 Thread Michael S. Tsirkin
On Mon, Aug 02, 2021 at 08:07:17PM +0800, fuguancheng wrote: > diff --git a/include/uapi/linux/virtio_vsock.h > b/include/uapi/linux/virtio_vsock.h > index 3dd3555b2740..0afc14446b01 100644 > --- a/include/uapi/linux/virtio_vsock.h > +++ b/include/uapi/linux/virtio_vsock.h > @@ -42,7 +42,8 @@ > #

Re: [PATCH 1/4] VSOCK DRIVER: Add multi-cid support for guest

2021-08-02 Thread Michael S. Tsirkin
On Mon, Aug 02, 2021 at 08:07:17PM +0800, fuguancheng wrote: > diff --git a/include/uapi/linux/vhost.h b/include/uapi/linux/vhost.h > index c998860d7bbc..a3ea99f6fc7f 100644 > --- a/include/uapi/linux/vhost.h > +++ b/include/uapi/linux/vhost.h > @@ -17,6 +17,13 @@ > > #define VHOST_FILE_UNBIND -

Re: PROBLEM: virtio_net LRO kernel panics

2021-08-02 Thread Michael S. Tsirkin
On Mon, Aug 02, 2021 at 01:32:05PM -0500, Ivan wrote: > On Tue, Jul 27, 2021 at 4:11 AM Michael S. Tsirkin wrote: > > > > On Mon, Jul 26, 2021 at 07:44:43PM -0500, Ivan wrote: > > > On Sat, Jul 24, 2021 at 11:18 PM Ivan > > > wrote: > > > > > > > > On Sat, Jul 24, 2021 at 7:17 PM Ivan > > > >

Re: [PATCH net] VSOCK: handle VIRTIO_VSOCK_OP_CREDIT_REQUEST

2021-08-02 Thread Michael S. Tsirkin
On Mon, Aug 02, 2021 at 07:35:06PM +0200, Harshavardhan Unnibhavi wrote: > The original implementation of the virtio-vsock driver does not > handle a VIRTIO_VSOCK_OP_CREDIT_REQUEST as required by the > virtio-vsock specification. The vsock device emulated by > vhost-vsock and the virtio-vsock drive

Re: [PATCH V4 2/5] dt-bindings: i2c: Add bindings for i2c-virtio

2021-08-02 Thread Rob Herring
On Tue, 27 Jul 2021 10:53:49 +0530, Viresh Kumar wrote: > This patch adds binding for virtio I2C device, it is based on > virtio-device bindings. > > Acked-by: Wolfram Sang > Reviewed-by: Arnd Bergmann > Signed-off-by: Viresh Kumar > --- > .../devicetree/bindings/i2c/i2c-virtio.yaml | 51 +++

Re: [PATCH V4 1/5] dt-bindings: virtio: Add binding for virtio devices

2021-08-02 Thread Rob Herring
On Tue, 27 Jul 2021 10:53:48 +0530, Viresh Kumar wrote: > Allow virtio device sub-nodes to be added to the virtio mmio or pci > nodes. The compatible property for virtio device must be of the format > "virtio,device", where ID is virtio device ID in hexadecimal format. > > Signed-off-by: Viresh Ku

Re: [PATCH V4 3/5] dt-bindings: gpio: Add bindings for gpio-virtio

2021-08-02 Thread Rob Herring
On Tue, Jul 27, 2021 at 10:53:50AM +0530, Viresh Kumar wrote: > This patch adds binding for virtio GPIO controller, it is based on > virtio-device bindings. > > Reviewed-by: Arnd Bergmann > Signed-off-by: Viresh Kumar > --- > .../devicetree/bindings/gpio/gpio-virtio.yaml | 59 ++

Re: [PATCH net] VSOCK: handle VIRTIO_VSOCK_OP_CREDIT_REQUEST

2021-08-02 Thread Stefano Garzarella
On Mon, Aug 02, 2021 at 07:35:06PM +0200, Harshavardhan Unnibhavi wrote: The original implementation of the virtio-vsock driver does not handle a VIRTIO_VSOCK_OP_CREDIT_REQUEST as required by the virtio-vsock specification. The vsock device emulated by vhost-vsock and the virtio-vsock driver neve

Re: [PATCH net v2 0/2] virtio-net: fix for build_skb()

2021-08-02 Thread Michael S. Tsirkin
On Fri, Jul 30, 2021 at 05:16:43AM -0700, Jakub Kicinski wrote: > On Tue, 1 Jun 2021 07:06:43 -0400 Michael S. Tsirkin wrote: > > On Tue, Jun 01, 2021 at 02:39:58PM +0800, Xuan Zhuo wrote: > > > #1 Fixed a serious error. > > > #2 Fixed a logical error, but this error did not cause any serious > >

[PATCH 4.19 01/30] virtio_net: Do not pull payload in skb->head

2021-08-02 Thread Greg Kroah-Hartman
From: Eric Dumazet commit 0f6925b3e8da0dbbb52447ca8a8b42b371aac7db upstream. Xuan Zhuo reported that commit 3226b158e67c ("net: avoid 32 x truesize under-estimation for tiny skbs") brought a ~10% performance drop. The reason for the performance drop was that GRO was forced to chain sk_buff (us

[PATCH 4.14 14/38] virtio_net: Do not pull payload in skb->head

2021-08-02 Thread Greg Kroah-Hartman
From: Eric Dumazet commit 0f6925b3e8da0dbbb52447ca8a8b42b371aac7db upstream. Xuan Zhuo reported that commit 3226b158e67c ("net: avoid 32 x truesize under-estimation for tiny skbs") brought a ~10% performance drop. The reason for the performance drop was that GRO was forced to chain sk_buff (us

Re: [PATCH 0/4] Add multi-cid support for vsock driver

2021-08-02 Thread Stefano Garzarella
On Mon, Aug 02, 2021 at 08:07:16PM +0800, fuguancheng wrote: This patchset enables the user to specify additional CIDS for host and guest when booting up the guest machine. The guest's additional CIDS cannot be repeated, and can be used to communicate with the host. The user can also choose to sp