Re: [PATCH v4 09/15] pci: Consolidate pci_iomap* and pci_iomap*wc

2021-08-12 Thread Andi Kleen
Why is it safe to make pci_iomap_wc_range() support IO ports when it didn't before? That might be desirable, but I think it *is* a functional change here. None of the callers use it to map IO ports, so it will be a no-op for them. But you're right, it's a (minor) functional change. -Andi

Re: [PATCH v4 10/15] asm/io.h: Add ioremap_shared fallback

2021-08-12 Thread Bjorn Helgaas
On Wed, Aug 04, 2021 at 05:52:13PM -0700, Kuppuswamy Sathyanarayanan wrote: > From: Andi Kleen > > This function is for declaring memory that should be shared with > a hypervisor in a confidential guest. If the architecture doesn't > implement it it's just ioremap. I would assume

Re: [PATCH v4 09/15] pci: Consolidate pci_iomap* and pci_iomap*wc

2021-08-12 Thread Bjorn Helgaas
Is there a branch with all of this applied? I was going to apply this to help take a look at it, but it doesn't apply to v5.14-rc1. I know you listed some prereqs in the cover letter, but it's a fair amount of work to sort all that out. On Wed, Aug 04, 2021 at 05:52:12PM -0700, Kuppuswamy

Re: [PATCH v6 1/2] tty: hvc: pass DMA capable memory to put_chars()

2021-08-12 Thread kernel test robot
Hi Xianting, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tty/tty-testing] [also build test WARNING on char-misc/char-misc-testing soc/for-next v5.14-rc5 next-20210812] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH 12/38] crypto: virtio: Replace deprecated CPU-hotplug functions.

2021-08-12 Thread Herbert Xu
On Tue, Aug 03, 2021 at 04:15:55PM +0200, Sebastian Andrzej Siewior wrote: > The functions get_online_cpus() and put_online_cpus() have been > deprecated during the CPU hotplug rework. They map directly to > cpus_read_lock() and cpus_read_unlock(). > > Replace deprecated CPU-hotplug functions

Re: [PATCH v1 3/3] kernel/resource: cleanup and optimize iomem_is_exclusive()

2021-08-12 Thread Andy Shevchenko
On Thu, Aug 12, 2021 at 09:34:00AM +0200, David Hildenbrand wrote: > On 12.08.21 09:14, Andy Shevchenko wrote: > > On Thursday, August 12, 2021, David Hildenbrand > > wrote: > > On 11.08.21 22:47, Andy Shevchenko wrote: > > On Wednesday, August 11, 2021, David

Re: [PATCH v4 1/2] tty: hvc: pass DMA capable memory to put_chars()

2021-08-12 Thread Arnd Bergmann
On Thu, Aug 12, 2021 at 10:08 AM Xianting TIan wrote: > 在 2021/8/6 下午10:51, Arnd Bergmann 写道: > > On Fri, Aug 6, 2021 at 5:01 AM Xianting Tian > >> +#define __ALIGNED__ __attribute__((__aligned__(sizeof(long > > I think you need a higher alignment for DMA buffers, instead of > >

Re: [PATCH resend] vsock/virtio: avoid potential deadlock when vsock device remove

2021-08-12 Thread Stefano Garzarella
On Thu, Aug 12, 2021 at 01:30:56PM +0800, Longpeng(Mike) wrote: There's a potential deadlock case when remove the vsock device or process the RESET event: vsock_for_each_connected_socket: spin_lock_bh(_table_lock) --- (1) ... virtio_vsock_reset_sock:

Re: [PATCH v1 3/3] kernel/resource: cleanup and optimize iomem_is_exclusive()

2021-08-12 Thread David Hildenbrand
On 12.08.21 09:14, Andy Shevchenko wrote: On Thursday, August 12, 2021, David Hildenbrand > wrote: On 11.08.21 22:47, Andy Shevchenko wrote: On Wednesday, August 11, 2021, David Hildenbrand mailto:da...@redhat.com>

Re: [PATCH v1 3/3] kernel/resource: cleanup and optimize iomem_is_exclusive()

2021-08-12 Thread Andy Shevchenko
On Thursday, August 12, 2021, David Hildenbrand wrote: > On 11.08.21 22:47, Andy Shevchenko wrote: > >> >> >> On Wednesday, August 11, 2021, David Hildenbrand > > wrote: >> >> Let's clean it up a bit, removing the unnecessary usage of r_next() by >>

Re: [PATCH v1 3/3] kernel/resource: cleanup and optimize iomem_is_exclusive()

2021-08-12 Thread David Hildenbrand
On 11.08.21 22:47, Andy Shevchenko wrote: On Wednesday, August 11, 2021, David Hildenbrand > wrote: Let's clean it up a bit, removing the unnecessary usage of r_next() by next_resource(), and use next_range_resource() in case we are not interested in a

Re: [Patch v1 3/3] vdpa/mlx5: Add multiqueue support

2021-08-12 Thread Jason Wang
在 2021/8/12 下午3:01, Eli Cohen 写道: On Thu, Aug 12, 2021 at 02:47:06PM +0800, Jason Wang wrote: On Thu, Aug 12, 2021 at 12:55 PM Eli Cohen wrote: On Thu, Aug 12, 2021 at 11:19:19AM +0800, Jason Wang wrote: 在 2021/8/11 下午7:04, Eli Cohen 写道: On Wed, Aug 11, 2021 at 04:37:44PM +0800, Jason Wang

Re: [Patch v1 3/3] vdpa/mlx5: Add multiqueue support

2021-08-12 Thread Jason Wang
On Thu, Aug 12, 2021 at 12:55 PM Eli Cohen wrote: > > On Thu, Aug 12, 2021 at 11:19:19AM +0800, Jason Wang wrote: > > > > 在 2021/8/11 下午7:04, Eli Cohen 写道: > > > On Wed, Aug 11, 2021 at 04:37:44PM +0800, Jason Wang wrote: > > > > 在 2021/8/11 下午3:53, Eli Cohen 写道: > > > > > > One thing need to

Re: [RFC PATCH] virtio-net: use NETIF_F_GRO_HW instead of NETIF_F_LRO

2021-08-12 Thread Jason Wang
在 2021/8/12 下午12:50, Michael S. Tsirkin 写道: On Thu, Aug 12, 2021 at 11:23:04AM +0800, Jason Wang wrote: 在 2021/8/12 上午6:17, Jakub Kicinski 写道: On Wed, 11 Aug 2021 16:16:23 +0800 Jason Wang wrote: Try to fix this by using NETIF_F_GRO_HW instead so we're not guaranteed to be re-segmented as