Re: [Virtio-fs] [virtiofsd PATCH v4 4/4] virtiofsd: support per-file DAX in FUSE_LOOKUP

2021-08-17 Thread JeffleXu
On 8/18/21 3:00 AM, Dr. David Alan Gilbert wrote: > * Jeffle Xu (jeffl...@linux.alibaba.com) wrote: >> For passthrough, when the corresponding virtiofs in guest is mounted >> with '-o dax=inode', advertise that the file is capable of per-file >> DAX if the inode in the backend fs is marked with

Re: [Virtio-fs] [virtiofsd PATCH v4 3/4] virtiofsd: support per-file DAX negotiation in FUSE_INIT

2021-08-17 Thread JeffleXu
On 8/18/21 1:15 AM, Dr. David Alan Gilbert wrote: > * Jeffle Xu (jeffl...@linux.alibaba.com) wrote: >> In FUSE_INIT negotiating phase, server/client should advertise if it >> supports per-file DAX. >> >> Once advertising support for per-file DAX feature, virtiofsd should >> support storing FS_DA

Re: [PATCH v4 0/8] fuse,virtiofs: support per-file DAX

2021-08-17 Thread JeffleXu
On 8/17/21 10:57 PM, Vivek Goyal wrote: > On Tue, Aug 17, 2021 at 09:22:53PM +0800, JeffleXu wrote: >> >> >> On 8/17/21 8:39 PM, Vivek Goyal wrote: >>> On Tue, Aug 17, 2021 at 10:06:53AM +0200, Miklos Szeredi wrote: On Tue, 17 Aug 2021 at 04:22, Jeffle Xu wrote: > > This patchset a

Re: [Virtio-fs] [PATCH v4 0/8] fuse,virtiofs: support per-file DAX

2021-08-17 Thread JeffleXu
On 8/17/21 10:54 PM, Vivek Goyal wrote: > On Tue, Aug 17, 2021 at 09:08:35PM +0800, JeffleXu wrote: >> >> >> On 8/17/21 6:09 PM, Miklos Szeredi wrote: >>> On Tue, 17 Aug 2021 at 11:32, Dr. David Alan Gilbert >>> wrote: * Miklos Szeredi (mik...@szeredi.hu) wrote: > On Tue, 17 Aug 2

RE: [PATCH linux-next v3 0/6] vdpa: enable user to set mac, mtu

2021-08-17 Thread Parav Pandit via Virtualization
> From: Jason Wang > Sent: Wednesday, August 18, 2021 10:02 AM > On Wed, Aug 18, 2021 at 11:15 AM Parav Pandit wrote: [..] > > > I'm inclined to say vxlan is closer to a model to follow. > > Ok. thanks for the feedback. We are using the model close to vxlan. > > Lets resolve should we have it

Re: [PATCH linux-next v3 0/6] vdpa: enable user to set mac, mtu

2021-08-17 Thread Jason Wang
On Wed, Aug 18, 2021 at 11:15 AM Parav Pandit wrote: > > > > > From: Michael S. Tsirkin > > Sent: Tuesday, August 17, 2021 2:24 AM > > > > On Mon, Aug 09, 2021 at 09:51:49AM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > > > Sent: Monday, August 9, 2021 3:10 PM > > > > > > > > O

Re: [PATCH v4 0/8] fuse,virtiofs: support per-file DAX

2021-08-17 Thread JeffleXu
On 8/17/21 10:08 PM, Miklos Szeredi wrote: > On Tue, 17 Aug 2021 at 15:22, JeffleXu wrote: >> >> >> >> On 8/17/21 8:39 PM, Vivek Goyal wrote: >>> On Tue, Aug 17, 2021 at 10:06:53AM +0200, Miklos Szeredi wrote: On Tue, 17 Aug 2021 at 04:22, Jeffle Xu wrote: > > This patchset adds s

[PATCH] i2c: virtio: Update i2c-adapter's of_node

2021-08-17 Thread Viresh Kumar
Set of-node of the adapter to the virtio device's of-node to enable automatic parsing the of the I2C devices, if present in the DT. Signed-off-by: Viresh Kumar --- drivers/i2c/busses/i2c-virtio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i2c/busses/i2c-virtio.c b/drivers/i2c/bu

RE: [PATCH linux-next v3 0/6] vdpa: enable user to set mac, mtu

2021-08-17 Thread Parav Pandit via Virtualization
> From: Michael S. Tsirkin > Sent: Tuesday, August 17, 2021 2:24 AM > > On Mon, Aug 09, 2021 at 09:51:49AM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > > Sent: Monday, August 9, 2021 3:10 PM > > > > > > On Fri, Aug 06, 2021 at 08:55:56AM +, Parav Pandit wrote: > > > > > >

Re: [Patch v1 3/3] vdpa/mlx5: Add multiqueue support

2021-08-17 Thread Jason Wang
On Tue, Aug 17, 2021 at 4:57 PM Jason Wang wrote: > > On Tue, Aug 17, 2021 at 2:01 PM Eli Cohen wrote: > > > > On Tue, Aug 17, 2021 at 01:48:17PM +0800, Jason Wang wrote: > > > On Tue, Aug 17, 2021 at 1:26 PM Eli Cohen wrote: > > > > > > > > On Tue, Aug 17, 2021 at 12:19:55PM +0800, Jason Wang w

Re: [PATCH v15] i2c: virtio: add a virtio i2c frontend driver

2021-08-17 Thread Jie Deng
On 2021/8/18 4:22, Wolfram Sang wrote: Michael S. Tsirkin Okay, with rc6 being released, I won't wait for an immutable branch anymore. I applied this now and we will see if there will be a merge conflict. If so, it will be trivial to handle, I'd think. So: Applied to for-next, thanks! T

Re: [Virtio-fs] [virtiofsd PATCH v4 4/4] virtiofsd: support per-file DAX in FUSE_LOOKUP

2021-08-17 Thread Dr. David Alan Gilbert
* Jeffle Xu (jeffl...@linux.alibaba.com) wrote: > For passthrough, when the corresponding virtiofs in guest is mounted > with '-o dax=inode', advertise that the file is capable of per-file > DAX if the inode in the backend fs is marked with FS_DAX_FL flag. > > Signed-off-by: Jeffle Xu > --- > to

Re: [PATCH v7 1/2] tty: hvc: pass DMA capable memory to put_chars()

2021-08-17 Thread kernel test robot
Hi Xianting, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tty/tty-testing] [also build test WARNING on char-misc/char-misc-testing soc/for-next v5.14-rc6 next-20210817] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [Virtio-fs] [virtiofsd PATCH v4 3/4] virtiofsd: support per-file DAX negotiation in FUSE_INIT

2021-08-17 Thread Dr. David Alan Gilbert
* Jeffle Xu (jeffl...@linux.alibaba.com) wrote: > In FUSE_INIT negotiating phase, server/client should advertise if it > supports per-file DAX. > > Once advertising support for per-file DAX feature, virtiofsd should > support storing FS_DAX_FL flag persistently passed by > FS_IOC_SETFLAGS/FS_IOC_F

Re: [PATCH v7 1/2] tty: hvc: pass DMA capable memory to put_chars()

2021-08-17 Thread Greg KH
On Tue, Aug 17, 2021 at 09:22:59PM +0800, Xianting Tian wrote: > We tested the patch, it worked normally. Who is "we"? > Signed-off-by: Xianting Tian Like I said before, I need another developer from your company to review and sign-off on this patch (and the other one), before I am willing to l

Re: [Virtio-fs] [PATCH v4 0/8] fuse,virtiofs: support per-file DAX

2021-08-17 Thread Vivek Goyal
On Tue, Aug 17, 2021 at 04:11:14PM +0200, Miklos Szeredi wrote: [..] > > As for virtiofs, Dr. David Alan Gilbert has mentioned that various files > > may compete for limited DAX window resource. > > > > Besides, supporting DAX for small files can be expensive. Small files > > can consume DAX windo

Re: [PATCH v4 0/8] fuse,virtiofs: support per-file DAX

2021-08-17 Thread Vivek Goyal
On Tue, Aug 17, 2021 at 09:22:53PM +0800, JeffleXu wrote: > > > On 8/17/21 8:39 PM, Vivek Goyal wrote: > > On Tue, Aug 17, 2021 at 10:06:53AM +0200, Miklos Szeredi wrote: > >> On Tue, 17 Aug 2021 at 04:22, Jeffle Xu wrote: > >>> > >>> This patchset adds support of per-file DAX for virtiofs, whic

Re: [Virtio-fs] [PATCH v4 0/8] fuse,virtiofs: support per-file DAX

2021-08-17 Thread Vivek Goyal
On Tue, Aug 17, 2021 at 09:08:35PM +0800, JeffleXu wrote: > > > On 8/17/21 6:09 PM, Miklos Szeredi wrote: > > On Tue, 17 Aug 2021 at 11:32, Dr. David Alan Gilbert > > wrote: > >> > >> * Miklos Szeredi (mik...@szeredi.hu) wrote: > >>> On Tue, 17 Aug 2021 at 04:22, Jeffle Xu > >>> wrote: >

Re: [Virtio-fs] [PATCH v4 6/8] fuse: mark inode DONT_CACHE when per-file DAX indication changes

2021-08-17 Thread JeffleXu
On 8/17/21 6:26 PM, Dr. David Alan Gilbert wrote: > * Jeffle Xu (jeffl...@linux.alibaba.com) wrote: >> When the per-file DAX indication changes while the file is still >> *opened*, it is quite complicated and maybe fragile to dynamically >> change the DAX state. >> >> Hence mark the inode and co

Re: [PATCH v4 0/8] fuse,virtiofs: support per-file DAX

2021-08-17 Thread JeffleXu
On 8/17/21 8:39 PM, Vivek Goyal wrote: > On Tue, Aug 17, 2021 at 10:06:53AM +0200, Miklos Szeredi wrote: >> On Tue, 17 Aug 2021 at 04:22, Jeffle Xu wrote: >>> >>> This patchset adds support of per-file DAX for virtiofs, which is >>> inspired by Ira Weiny's work on ext4[1] and xfs[2]. >> >> Can

Re: [Virtio-fs] [PATCH v4 0/8] fuse,virtiofs: support per-file DAX

2021-08-17 Thread JeffleXu
On 8/17/21 6:09 PM, Miklos Szeredi wrote: > On Tue, 17 Aug 2021 at 11:32, Dr. David Alan Gilbert > wrote: >> >> * Miklos Szeredi (mik...@szeredi.hu) wrote: >>> On Tue, 17 Aug 2021 at 04:22, Jeffle Xu wrote: This patchset adds support of per-file DAX for virtiofs, which is inspir

Re: [PATCH v4 0/8] fuse,virtiofs: support per-file DAX

2021-08-17 Thread Vivek Goyal
On Tue, Aug 17, 2021 at 10:06:53AM +0200, Miklos Szeredi wrote: > On Tue, 17 Aug 2021 at 04:22, Jeffle Xu wrote: > > > > This patchset adds support of per-file DAX for virtiofs, which is > > inspired by Ira Weiny's work on ext4[1] and xfs[2]. > > Can you please explain the background of this chan

Re: [Virtio-fs] [PATCH v4 0/8] fuse,virtiofs: support per-file DAX

2021-08-17 Thread Vivek Goyal
On Tue, Aug 17, 2021 at 10:32:14AM +0100, Dr. David Alan Gilbert wrote: > * Miklos Szeredi (mik...@szeredi.hu) wrote: > > On Tue, 17 Aug 2021 at 04:22, Jeffle Xu wrote: > > > > > > This patchset adds support of per-file DAX for virtiofs, which is > > > inspired by Ira Weiny's work on ext4[1] and x

Re: [kvm-unit-tests PATCH 0/6] Initial x86_64 UEFI support

2021-08-17 Thread Joerg Roedel
Hi Marc, On Fri, Aug 13, 2021 at 11:44:39AM -0700, Marc Orr wrote: > To date, we have _most_ x86 test cases (39/44) working under UEFI and > we've also got some of the test cases to boot under SEV-ES, using the > UEFI #VC handler. While the EFI APP approach simplifies the implementation a lot, I

Re: [Virtio-fs] [PATCH v4 0/8] fuse,virtiofs: support per-file DAX

2021-08-17 Thread Dr. David Alan Gilbert
* Miklos Szeredi (mik...@szeredi.hu) wrote: > On Tue, 17 Aug 2021 at 11:32, Dr. David Alan Gilbert > wrote: > > > > * Miklos Szeredi (mik...@szeredi.hu) wrote: > > > On Tue, 17 Aug 2021 at 04:22, Jeffle Xu > > > wrote: > > > > > > > > This patchset adds support of per-file DAX for virtiofs, whic

Re: [Virtio-fs] [PATCH v4 6/8] fuse: mark inode DONT_CACHE when per-file DAX indication changes

2021-08-17 Thread Dr. David Alan Gilbert
* Jeffle Xu (jeffl...@linux.alibaba.com) wrote: > When the per-file DAX indication changes while the file is still > *opened*, it is quite complicated and maybe fragile to dynamically > change the DAX state. > > Hence mark the inode and corresponding dentries as DONE_CACHE once the

Re: [Virtio-fs] [PATCH v4 0/8] fuse,virtiofs: support per-file DAX

2021-08-17 Thread Dr. David Alan Gilbert
* Miklos Szeredi (mik...@szeredi.hu) wrote: > On Tue, 17 Aug 2021 at 04:22, Jeffle Xu wrote: > > > > This patchset adds support of per-file DAX for virtiofs, which is > > inspired by Ira Weiny's work on ext4[1] and xfs[2]. > > Can you please explain the background of this change in detail? > > W

Re: [Patch v1 3/3] vdpa/mlx5: Add multiqueue support

2021-08-17 Thread Jason Wang
On Tue, Aug 17, 2021 at 2:01 PM Eli Cohen wrote: > > On Tue, Aug 17, 2021 at 01:48:17PM +0800, Jason Wang wrote: > > On Tue, Aug 17, 2021 at 1:26 PM Eli Cohen wrote: > > > > > > On Tue, Aug 17, 2021 at 12:19:55PM +0800, Jason Wang wrote: > > > > > > > > 在 2021/8/17 下午12:03, Parav Pandit 写道: > > >

Re: [PATCH net] virtio-net: use NETIF_F_GRO_HW instead of NETIF_F_LRO

2021-08-17 Thread Jason Wang
On Tue, Aug 17, 2021 at 2:46 PM Michael S. Tsirkin wrote: > > Patch is good. Suggest some tweaks to the commit log. > > On Tue, Aug 17, 2021 at 10:03:38AM +0800, Jason Wang wrote: > > Commit a02e8964eaf92 ("virtio-net: ethtool configurable LRO") tries to > > advertise LRO on behalf of the guest of

[PATCH V2 net] virtio-net: use NETIF_F_GRO_HW instead of NETIF_F_LRO

2021-08-17 Thread Jason Wang
Commit a02e8964eaf92 ("virtio-net: ethtool configurable LRO") maps LRO to virtio guest offloading features and allows the administrator to enable and disable those features via ethtool. This leads to several issues: - For a device that doesn't support control guest offloads, the "LRO" can't be