Re: [PATCH v3 1/3] MAINTAINERS: Update maintainers for paravirt ops and VMware hypervisor interface

2021-11-11 Thread Greg KH
On Thu, Nov 11, 2021 at 11:40:02AM -0800, Srivatsa S. Bhat wrote: > On Thu, Nov 11, 2021 at 07:45:02PM +0100, Greg KH wrote: > > On Thu, Nov 11, 2021 at 07:39:16AM -0800, Srivatsa S. Bhat wrote: > > > On Thu, Nov 11, 2021 at 07:50:39AM +0100, Greg KH wrote: > > > > On Wed, Nov 10, 2021 at

Re: [PATCH v2 1/2] i2c: virtio: disable timeout handling

2021-11-11 Thread Viresh Kumar
On 11-11-21, 17:04, Vincent Whitchurch wrote: > If a timeout is hit, it can result is incorrect data on the I2C bus > and/or memory corruptions in the guest since the device can still be > operating on the buffers it was given while the guest has freed them. > > Here is, for example, the start of

Re: [PATCH v4 0/3] virtio support cache indirect desc

2021-11-11 Thread Xuan Zhuo
On Thu, 11 Nov 2021 10:02:01 -0500, Michael S. Tsirkin wrote: > On Thu, Nov 11, 2021 at 02:52:07PM +0800, Xuan Zhuo wrote: > > On Wed, 10 Nov 2021 07:53:44 -0500, Michael S. Tsirkin > > wrote: > > > On Mon, Nov 08, 2021 at 10:47:40PM +0800, Xuan Zhuo wrote: > > > > On Mon, 8 Nov 2021 08:49:27

update_balloon_size_func blocked for more than 120 seconds

2021-11-11 Thread Luis Chamberlain
I get the following splats with a kvm guest in idle, after a few seconds it starts: [ 242.412806] INFO: task kworker/6:2:271 blockedfor more than 120 seconds. [ 242.415790] Tainted: GE 5.15.0-next-2021 #68 [ 242.417755] "echo 0 > /proc/sy

Re: regression with mainline kernel

2021-11-11 Thread Sudip Mukherjee
Hi Linus, On Thu, Nov 11, 2021 at 2:03 PM Sudip Mukherjee wrote: > > Hi Linus, > > My testing has been failing for the last few days. Last good test was > with 6f2b76a4a384 and I started seeing the failure with ce840177930f5 > where boot timeout. > > Last good test -

Re: [PATCH v3 1/3] MAINTAINERS: Update maintainers for paravirt ops and VMware hypervisor interface

2021-11-11 Thread Srivatsa S. Bhat
On Thu, Nov 11, 2021 at 07:45:02PM +0100, Greg KH wrote: > On Thu, Nov 11, 2021 at 07:39:16AM -0800, Srivatsa S. Bhat wrote: > > On Thu, Nov 11, 2021 at 07:50:39AM +0100, Greg KH wrote: > > > On Wed, Nov 10, 2021 at 12:08:16PM -0800, Srivatsa S. Bhat wrote: > > > > From: Srivatsa S. Bhat (VMware)

Re: [PATCH v3 1/3] MAINTAINERS: Update maintainers for paravirt ops and VMware hypervisor interface

2021-11-11 Thread Greg KH
On Thu, Nov 11, 2021 at 07:39:16AM -0800, Srivatsa S. Bhat wrote: > On Thu, Nov 11, 2021 at 07:50:39AM +0100, Greg KH wrote: > > On Wed, Nov 10, 2021 at 12:08:16PM -0800, Srivatsa S. Bhat wrote: > > > From: Srivatsa S. Bhat (VMware) > > > > > > Deep has decided to transfer maintainership of the

Re: [PATCH v2 2/2] i2c: virtio: fix completion handling

2021-11-11 Thread Michael S. Tsirkin
On Thu, Nov 11, 2021 at 05:04:12PM +0100, Vincent Whitchurch wrote: > The driver currently assumes that the notify callback is only received > when the device is done with all the queued buffers. > > However, this is not true, since the notify callback could be called > without any of the queued

Re: [PATCH v2 1/2] i2c: virtio: disable timeout handling

2021-11-11 Thread Michael S. Tsirkin
On Thu, Nov 11, 2021 at 05:04:11PM +0100, Vincent Whitchurch wrote: > If a timeout is hit, it can result is incorrect data on the I2C bus > and/or memory corruptions in the guest since the device can still be > operating on the buffers it was given while the guest has freed them. > > Here is, for

[PATCH v2 1/2] i2c: virtio: disable timeout handling

2021-11-11 Thread Vincent Whitchurch
If a timeout is hit, it can result is incorrect data on the I2C bus and/or memory corruptions in the guest since the device can still be operating on the buffers it was given while the guest has freed them. Here is, for example, the start of a slub_debug splat which was triggered on the next

[PATCH v2 2/2] i2c: virtio: fix completion handling

2021-11-11 Thread Vincent Whitchurch
The driver currently assumes that the notify callback is only received when the device is done with all the queued buffers. However, this is not true, since the notify callback could be called without any of the queued buffers being completed (for example, with virtio-pci and shared interrupts)

[PATCH v2 0/2] virtio-i2c: Fix buffer handling

2021-11-11 Thread Vincent Whitchurch
This fixes a couple of bugs in the buffer handling in virtio-i2c which can result in incorrect data on the I2C bus or memory corruption in the guest. I tested this on UML (virtio-uml needs a bug fix too, I will sent that out later) with the device implementation in rust-vmm/vhost-device. Changes

Re: [PATCH v3 1/3] MAINTAINERS: Update maintainers for paravirt ops and VMware hypervisor interface

2021-11-11 Thread Srivatsa S. Bhat
On Thu, Nov 11, 2021 at 07:50:39AM +0100, Greg KH wrote: > On Wed, Nov 10, 2021 at 12:08:16PM -0800, Srivatsa S. Bhat wrote: > > From: Srivatsa S. Bhat (VMware) > > > > Deep has decided to transfer maintainership of the VMware hypervisor > > interface to Srivatsa, and the joint-maintainership of

Re: [RFC] hypercall-vsock: add a new vsock transport

2021-11-11 Thread Michael S. Tsirkin
On Thu, Nov 11, 2021 at 07:58:29AM +, Wang, Wei W wrote: > On Wednesday, November 10, 2021 6:50 PM, Michael S. Tsirkin wrote: > > On Wed, Nov 10, 2021 at 07:12:36AM +, Wang, Wei W wrote: > > > > hypercalls are fundamentally hypervisor dependent though. > > Yes, each hypervisor needs to

Re: [PATCH v4 0/3] virtio support cache indirect desc

2021-11-11 Thread Michael S. Tsirkin
On Thu, Nov 11, 2021 at 02:52:07PM +0800, Xuan Zhuo wrote: > On Wed, 10 Nov 2021 07:53:44 -0500, Michael S. Tsirkin > wrote: > > On Mon, Nov 08, 2021 at 10:47:40PM +0800, Xuan Zhuo wrote: > > > On Mon, 8 Nov 2021 08:49:27 -0500, Michael S. Tsirkin > > > wrote: > > > > > > > > Hmm a bunch of

Re: [PATCH v3 1/3] MAINTAINERS: Update maintainers for paravirt ops and VMware hypervisor interface

2021-11-11 Thread Steven Rostedt
On Thu, 11 Nov 2021 07:50:39 +0100 Greg KH wrote: > > Signed-off-by: Srivatsa S. Bhat (VMware) > > Acked-by: Alexey Makhalov > > Acked-by: Deep Shah > > Acked-by: Juergen Gross > > Cc: sta...@vger.kernel.org > > Why are MAINTAINERS updates needed for stable? That's not normal :(

Re: [PATCH v3 3/3] MAINTAINERS: Mark VMware mailing list entries as email aliases

2021-11-11 Thread Juergen Gross via Virtualization
On 10.11.21 21:09, Srivatsa S. Bhat wrote: From: Srivatsa S. Bhat (VMware) VMware mailing lists in the MAINTAINERS file are private lists meant for VMware-internal review/notification for patches to the respective subsystems. Anyone can post to these addresses, but there is no public read

Re: [PATCH v3 3/3] MAINTAINERS: Mark VMware mailing list entries as email aliases

2021-11-11 Thread Joe Perches
On Wed, 2021-11-10 at 17:39 -0800, Jakub Kicinski wrote: > On Wed, 10 Nov 2021 12:09:06 -0800 Srivatsa S. Bhat wrote: > > DRM DRIVER FOR VMWARE VIRTUAL GPU > > -M: "VMware Graphics" > > M: Zack Rusin > > +R: VMware Graphics Reviewers > > L: dri-de...@lists.freedesktop.org > > S: Supported >

Re: [RFC] hypercall-vsock: add a new vsock transport

2021-11-11 Thread Paolo Bonzini
On 11/11/21 09:14, Wang, Wei W wrote: Adding Andra and Sergio, because IIRC Firecracker and libkrun emulates virtio-vsock with virtio-mmio so the implementation should be simple and also not directly tied to a specific VMM. OK. This would be OK for KVM based guests. For Hyperv and VMWare

RE: [RFC] hypercall-vsock: add a new vsock transport

2021-11-11 Thread Wang, Wei W
On Wednesday, November 10, 2021 7:17 PM, Stefano Garzarella wrote: > Adding Andra and Sergio, because IIRC Firecracker and libkrun emulates > virtio-vsock with virtio-mmio so the implementation should be simple and also > not directly tied to a specific VMM. > OK. This would be OK for KVM

RE: [RFC] hypercall-vsock: add a new vsock transport

2021-11-11 Thread Wang, Wei W
> From: Stefan Hajnoczi On Wednesday, November 10, 2021 5:35 PM, Stefan Hajnoczi wrote: > AF_VSOCK is designed to allow multiple transports, so why not. There is a cost > to developing and maintaining a vsock transport though. Yes. The effort could be reduced via simplifying the design as much