Re: [PATCH v3 09/10] vdpa/mlx5: Configure max supported virtqueues

2021-12-20 Thread Jason Wang
On Tue, Dec 21, 2021 at 2:23 PM Eli Cohen wrote: > > On Tue, Dec 21, 2021 at 02:04:39PM +0800, Jason Wang wrote: > > > > 在 2021/12/19 下午10:02, Eli Cohen 写道: > > > Configure max supported virtqueues on the management device. This info > > > can be retrieved using: > > > > > > $ vdpa dev show > > >

Re: [PATCH v3 07/10] vdpa: Add support for returning device configuration information

2021-12-20 Thread Jason Wang
On Tue, Dec 21, 2021 at 3:04 PM Eli Cohen wrote: > > On Tue, Dec 21, 2021 at 08:20:32AM +0200, Eli Cohen wrote: > > On Tue, Dec 21, 2021 at 01:57:54PM +0800, Jason Wang wrote: > > > On Sun, Dec 19, 2021 at 10:03 PM Eli Cohen wrote: > > > > > > > > Add netlink attribute to store the negotiated

Re: [PATCH v3 03/10] vdpa: Read device configuration only if FEATURES_OK

2021-12-20 Thread Jason Wang
On Tue, Dec 21, 2021 at 2:17 PM Eli Cohen wrote: > > On Tue, Dec 21, 2021 at 01:51:32PM +0800, Jason Wang wrote: > > On Sun, Dec 19, 2021 at 10:03 PM Eli Cohen wrote: > > > > > > Avoid reading device configuration during feature negotiation. Read > > > device status and verify that

Re: [PATCH v3 10/10] vdpa: Use BIT_ULL for bit operations

2021-12-20 Thread Jason Wang
On Sun, Dec 19, 2021 at 10:03 PM Eli Cohen wrote: > > All masks in this file are 64 bits. Change BIT to BIT_ULL. > > Other occurences use (1 << val) which yields a 32 bit value. Change them > to use BIT_ULL too. > It looks to me the patch was squashed with vendor specific stats extension

Re: [PATCH v3 09/10] vdpa/mlx5: Configure max supported virtqueues

2021-12-20 Thread Jason Wang
在 2021/12/19 下午10:02, Eli Cohen 写道: Configure max supported virtqueues on the management device. This info can be retrieved using: $ vdpa dev show vdpa-a: type network mgmtdev auxiliary/mlx5_core.sf.1 vendor_id \ max_vqp 3 max_vq_size 256 max_supported_vqs 256 I still think we

Re: [PATCH v3 07/10] vdpa: Add support for returning device configuration information

2021-12-20 Thread Jason Wang
On Sun, Dec 19, 2021 at 10:03 PM Eli Cohen wrote: > > Add netlink attribute to store the negotiated features. This can be used > by userspace to get the current state of the vdpa instance. > > Example: > $ vdpa dev config show vdpa-a > vdpa-a: mac 00:00:00:00:88:88 link up link_announce false

Re: [PATCH v3 04/10] vdpa: Allow to configure max data virtqueues

2021-12-20 Thread Jason Wang
On Sun, Dec 19, 2021 at 10:03 PM Eli Cohen wrote: > > Add netlink support to configure the max virtqueue pairs for a device. > At least one pair is required. The maximum is dictated by the device. > > Signed-off-by: Eli Cohen Acked-by: Jason Wang > > --- > V2 -> V3: > Fix error flow > >

Re: [PATCH v3 03/10] vdpa: Read device configuration only if FEATURES_OK

2021-12-20 Thread Jason Wang
On Sun, Dec 19, 2021 at 10:03 PM Eli Cohen wrote: > > Avoid reading device configuration during feature negotiation. Read > device status and verify that VIRTIO_CONFIG_S_FEATURES_OK is set. > Otherwise, return -EAGAIN. > > Signed-off-by: Eli Cohen > --- > drivers/vdpa/vdpa.c | 7 +++ > 1

Re: [PATCH v3 02/10] vdpa/mlx5: Distribute RX virtqueues in RQT object

2021-12-20 Thread Jason Wang
On Sun, Dec 19, 2021 at 10:03 PM Eli Cohen wrote: > > Distribute the available rx virtqueues amongst the available RQT > entries. > > RQTs require to have a power of two entries. When creating or modifying > the RQT, use the lowest number of power of two entries that is not less > than the number

Re: [PATCH v3 01/10] vdpa: Provide interface to read driver features

2021-12-20 Thread Jason Wang
On Sun, Dec 19, 2021 at 10:03 PM Eli Cohen wrote: > > Provide an interface to read the negotiated features. This is needed > when building the netlink message in vdpa_dev_net_config_fill(). > > Also fix the implementation of vdpa_dev_net_config_fill() to use the > negotiated features instead of

Re: [PATCH] gpio: virtio: remove timeout

2021-12-20 Thread Viresh Kumar
On 20-12-21, 14:06, Vincent Whitchurch wrote: > The driver imposes an arbitrary one second timeout on virtio requests, > but the specification doesn't prevent the virtio device from taking > longer to process requests, so remove this timeout to support all > systems and device implementations. >

[PATCH AUTOSEL 5.10 17/19] virtio_net: fix rx_drops stat for small pkts

2021-12-20 Thread Sasha Levin
From: Wenliang Wang [ Upstream commit 053c9e18c6f9cf82242ef35ac21cae1842725714 ] We found the stat of rx drops for small pkts does not increment when build_skb fail, it's not coherent with other mode's rx drops stat. Signed-off-by: Wenliang Wang Acked-by: Jason Wang Acked-by: Michael S.

[PATCH AUTOSEL 5.15 22/29] virtio_net: fix rx_drops stat for small pkts

2021-12-20 Thread Sasha Levin
From: Wenliang Wang [ Upstream commit 053c9e18c6f9cf82242ef35ac21cae1842725714 ] We found the stat of rx drops for small pkts does not increment when build_skb fail, it's not coherent with other mode's rx drops stat. Signed-off-by: Wenliang Wang Acked-by: Jason Wang Acked-by: Michael S.

Re: [PATCH v8 09/11] firmware: arm_scmi: Add atomic mode support to virtio transport

2021-12-20 Thread Michael S. Tsirkin
On Mon, Dec 20, 2021 at 07:56:44PM +, Cristian Marussi wrote: > Add support for .mark_txdone and .poll_done transport operations to SCMI > VirtIO transport as pre-requisites to enable atomic operations. > > Add a Kernel configuration option to enable SCMI VirtIO transport polling > and atomic

Re: [iproute2-next v2 4/4] vdpa: Enable user to set mtu of the vdpa device

2021-12-20 Thread Michael S. Tsirkin
On Mon, Dec 20, 2021 at 02:11:44PM -0700, David Ahern wrote: > On 12/20/21 12:11 PM, Parav Pandit wrote: > >> After consideration, this future proofing seems like a good thing to have. > > Ok. I will first get kernel change merged, after which will send v3 for > > iproute2. > > this set has been

Re: [iproute2-next v2 4/4] vdpa: Enable user to set mtu of the vdpa device

2021-12-20 Thread David Ahern
On 12/20/21 12:11 PM, Parav Pandit wrote: >> After consideration, this future proofing seems like a good thing to have. > Ok. I will first get kernel change merged, after which will send v3 for > iproute2. this set has been committed; not sure what happened to the notification from patchworks

RE: [iproute2-next v2 4/4] vdpa: Enable user to set mtu of the vdpa device

2021-12-20 Thread Parav Pandit via Virtualization
> From: Michael S. Tsirkin > Sent: Monday, December 20, 2021 5:33 PM > > On Mon, Dec 20, 2021 at 03:49:21AM +, Parav Pandit wrote: > > > > > > > From: Michael S. Tsirkin > > > Sent: Sunday, December 19, 2021 3:37 AM > > > > > > On Sat, Dec 18, 2021 at 01:53:01PM -0700, David Ahern wrote:

Re: [PATCH] gpio: virtio: remove timeout

2021-12-20 Thread Michael S. Tsirkin
On Mon, Dec 20, 2021 at 02:06:56PM +0100, Vincent Whitchurch wrote: > The driver imposes an arbitrary one second timeout on virtio requests, > but the specification doesn't prevent the virtio device from taking > longer to process requests, so remove this timeout to support all > systems and

Re: [PATCH] gpio: virtio: remove timeout

2021-12-20 Thread Michael S. Tsirkin
On Mon, Dec 20, 2021 at 03:54:56PM +0100, Bartosz Golaszewski wrote: > On Mon, Dec 20, 2021 at 2:07 PM Vincent Whitchurch > wrote: > > > > The driver imposes an arbitrary one second timeout on virtio requests, > > but the specification doesn't prevent the virtio device from taking > > longer to

Re: [PATCH 4/5] iommu: Separate IOVA rcache memories from iova_domain structure

2021-12-20 Thread Robin Murphy
Hi John, On 2021-12-20 08:49, John Garry wrote: On 24/09/2021 11:01, John Garry wrote: Only dma-iommu.c and vdpa actually use the "fast" mode of IOVA alloc and free. As such, it's wasteful that all other IOVA domains hold the rcache memories. In addition, the current IOVA domain init

[PATCH] gpio: virtio: remove timeout

2021-12-20 Thread Vincent Whitchurch
The driver imposes an arbitrary one second timeout on virtio requests, but the specification doesn't prevent the virtio device from taking longer to process requests, so remove this timeout to support all systems and device implementations. Fixes: 3a29355a22c0275fe86 ("gpio: Add virtio-gpio

Re: [iproute2-next v2 4/4] vdpa: Enable user to set mtu of the vdpa device

2021-12-20 Thread Michael S. Tsirkin
On Mon, Dec 20, 2021 at 03:49:21AM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Sunday, December 19, 2021 3:37 AM > > > > On Sat, Dec 18, 2021 at 01:53:01PM -0700, David Ahern wrote: > > > On 12/17/21 1:08 AM, Parav Pandit wrote: > > > > @@ -204,6 +217,8 @@ static void