Re: [PATCH] fuse: avoid unnecessary spinlock bump

2022-04-07 Thread JeffleXu
On 4/7/22 10:10 PM, Vivek Goyal wrote: > On Sat, Apr 02, 2022 at 06:32:50PM +0800, Jeffle Xu wrote: >> Move dmap free worker kicker inside the critical region, so that extra >> spinlock lock/unlock could be avoided. >> >> Suggested-by: Liu Jiang >> Signed-off-by: Jeffle Xu > > Looks good to

Re: [PATCH 1/5] iommu: Replace uses of IOMMU_CAP_CACHE_COHERENCY with dev_is_dma_coherent()

2022-04-07 Thread Alex Williamson
On Thu, 7 Apr 2022 12:23:31 -0300 Jason Gunthorpe wrote: > On Thu, Apr 07, 2022 at 04:17:11PM +0100, Robin Murphy wrote: > > > For the specific case of overriding PCIe No Snoop (which is more problematic > > from an Arm SMMU PoV) when assigning to a VM, would that not be easier > > solved by

Re: [PATCH 1/5] iommu: Replace uses of IOMMU_CAP_CACHE_COHERENCY with dev_is_dma_coherent()

2022-04-07 Thread Christoph Hellwig
On Thu, Apr 07, 2022 at 04:17:11PM +0100, Robin Murphy wrote: >> My take is that the drivers using this API are doing it to make sure >> their HW blocks are setup in a way that is consistent with the DMA API >> they are also using, and run in constrained embedded-style >> environments that know

Re: [PATCH 26/27] block: uncouple REQ_OP_SECURE_ERASE from REQ_OP_DISCARD

2022-04-07 Thread David Sterba
On Wed, Apr 06, 2022 at 08:05:15AM +0200, Christoph Hellwig wrote: > Secure erase is a very different operation from discard in that it is > a data integrity operation vs hint. Fully split the limits and helper > infrastructure to make the separation more clear. > > Signed-off-by: Christoph

Re: [PATCH 24/27] block: add a bdev_discard_granularity helper

2022-04-07 Thread David Sterba
On Wed, Apr 06, 2022 at 08:05:13AM +0200, Christoph Hellwig wrote: > Abstract away implementation details from file systems by providing a > block_device based helper to retreive the discard granularity. > > Signed-off-by: Christoph Hellwig > --- > block/blk-lib.c | 5 ++---

Re: [PATCH 07/27] btrfs: use bdev_max_active_zones instead of open coding it

2022-04-07 Thread Christoph Hellwig
On Thu, Apr 07, 2022 at 05:20:49PM +0200, David Sterba wrote: > On Wed, Apr 06, 2022 at 08:04:56AM +0200, Christoph Hellwig wrote: > > Signed-off-by: Christoph Hellwig > > As it's a standalone patch I can take it (possibly with other similar > prep btrfs patches) in current development cycle to

Re: [PATCH 23/27] block: add a bdev_max_discard_sectors helper

2022-04-07 Thread David Sterba
On Wed, Apr 06, 2022 at 08:05:12AM +0200, Christoph Hellwig wrote: > Add a helper to query the number of sectors support per each discard bio > based on the block device and use this helper to stop various places from > poking into the request_queue to see if discard is supported and if so how >

Re: [PATCH 11/27] block: add a bdev_write_cache helper

2022-04-07 Thread David Sterba
On Wed, Apr 06, 2022 at 08:05:00AM +0200, Christoph Hellwig wrote: > Add a helper to check the write cache flag based on the block_device > instead of having to poke into the block layer internal request_queue. > > Signed-off-by: Christoph Hellwig > --- > drivers/block/rnbd/rnbd-srv.c | 2

Re: [PATCH 10/27] block: add a bdev_nonrot helper

2022-04-07 Thread David Sterba
On Wed, Apr 06, 2022 at 08:04:59AM +0200, Christoph Hellwig wrote: > Add a helper to check the nonrot flag based on the block_device instead > of having to poke into the block layer internal request_queue. > > Signed-off-by: Christoph Hellwig > --- > block/ioctl.c | 2 +- >

Re: [PATCH 07/27] btrfs: use bdev_max_active_zones instead of open coding it

2022-04-07 Thread David Sterba
On Wed, Apr 06, 2022 at 08:04:56AM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig As it's a standalone patch I can take it (possibly with other similar prep btrfs patches) in current development cycle to relieve the inter-tree dependencies.

Re: [PATCH 1/5] iommu: Replace uses of IOMMU_CAP_CACHE_COHERENCY with dev_is_dma_coherent()

2022-04-07 Thread Robin Murphy
On 2022-04-07 14:59, Jason Gunthorpe wrote: On Thu, Apr 07, 2022 at 07:18:48AM +, Tian, Kevin wrote: From: Jason Gunthorpe Sent: Thursday, April 7, 2022 1:17 AM On Wed, Apr 06, 2022 at 06:10:31PM +0200, Christoph Hellwig wrote: On Wed, Apr 06, 2022 at 01:06:23PM -0300, Jason Gunthorpe

Re: [PATCH] fuse: avoid unnecessary spinlock bump

2022-04-07 Thread Vivek Goyal
On Sat, Apr 02, 2022 at 06:32:50PM +0800, Jeffle Xu wrote: > Move dmap free worker kicker inside the critical region, so that extra > spinlock lock/unlock could be avoided. > > Suggested-by: Liu Jiang > Signed-off-by: Jeffle Xu Looks good to me. Have you done any testing to make sure nothing

Re: [PATCH V2 4/5] virtio-pci: implement synchronize_vqs()

2022-04-07 Thread Jason Wang
On Thu, Apr 7, 2022 at 3:53 PM Cornelia Huck wrote: > > On Thu, Apr 07 2022, Jason Wang wrote: > > > 在 2022/4/6 下午11:31, Michael S. Tsirkin 写道: > >> On Wed, Apr 06, 2022 at 03:04:32PM +0200, Cornelia Huck wrote: > >>> On Wed, Apr 06 2022, "Michael S. Tsirkin" wrote: > >>> > On Wed, Apr 06,

Re: [PATCH V2 4/5] virtio-pci: implement synchronize_vqs()

2022-04-07 Thread Cornelia Huck
On Thu, Apr 07 2022, Jason Wang wrote: > 在 2022/4/6 下午11:31, Michael S. Tsirkin 写道: >> On Wed, Apr 06, 2022 at 03:04:32PM +0200, Cornelia Huck wrote: >>> On Wed, Apr 06 2022, "Michael S. Tsirkin" wrote: >>> On Wed, Apr 06, 2022 at 04:35:37PM +0800, Jason Wang wrote: > This patch

RE: [PATCH 1/5] iommu: Replace uses of IOMMU_CAP_CACHE_COHERENCY with dev_is_dma_coherent()

2022-04-07 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Thursday, April 7, 2022 1:17 AM > > On Wed, Apr 06, 2022 at 06:10:31PM +0200, Christoph Hellwig wrote: > > On Wed, Apr 06, 2022 at 01:06:23PM -0300, Jason Gunthorpe wrote: > > > On Wed, Apr 06, 2022 at 05:50:56PM +0200, Christoph Hellwig wrote: > > > > On Wed, Apr

Re: [PATCH V2 5/5] virtio: harden vring IRQ

2022-04-07 Thread Jason Wang
在 2022/4/6 下午8:04, Michael S. Tsirkin 写道: On Wed, Apr 06, 2022 at 04:35:38PM +0800, Jason Wang wrote: This is a rework on the previous IRQ hardening that is done for virtio-pci where several drawbacks were found and were reverted: 1) try to use IRQF_NO_AUTOEN which is not friendly to affinity

Re: [PATCH V2 4/5] virtio-pci: implement synchronize_vqs()

2022-04-07 Thread Jason Wang
在 2022/4/6 下午11:31, Michael S. Tsirkin 写道: On Wed, Apr 06, 2022 at 03:04:32PM +0200, Cornelia Huck wrote: On Wed, Apr 06 2022, "Michael S. Tsirkin" wrote: On Wed, Apr 06, 2022 at 04:35:37PM +0800, Jason Wang wrote: This patch implements PCI version of synchronize_vqs(). Cc: Thomas

Re: [PATCH V2 3/5] virtio: introduce config op to synchronize vring callbacks

2022-04-07 Thread Jason Wang
在 2022/4/6 下午7:59, Michael S. Tsirkin 写道: On Wed, Apr 06, 2022 at 04:35:36PM +0800, Jason Wang wrote: This patch introduce introduces a new new virtio config ops to vring callbacks. Transport specific method is required to call synchornize_irq() on the IRQs. For the transport that

Re: [PATCH V2 1/5] virtio: use virtio_device_ready() in virtio_device_restore()

2022-04-07 Thread Jason Wang
在 2022/4/6 下午7:44, Michael S. Tsirkin 写道: patch had wrong mime type. I managed to extra it but pls fix. From: Stefano Garzarella It will allows us will allow us to do extension on virtio_device_ready() without duplicating codes. code Cc: Thomas Gleixner Cc: Peter Zijlstra Cc: "Paul

Re: [PATCH V2 0/5] rework on the IRQ hardening of virtio

2022-04-07 Thread Jason Wang
在 2022/4/6 下午7:36, Michael S. Tsirkin 写道: On Wed, Apr 06, 2022 at 04:35:33PM +0800, Jason Wang wrote: Hi All: This is a rework on the IRQ hardening for virtio which is done previously by the following commits are reverted: 9e35276a5344 ("virtio_pci: harden MSI-X interrupts") 080cd7c3ac87