Re: [PATCH v2 00/19] Control VQ support in vDPA

2022-05-09 Thread Michael S. Tsirkin
On Mon, May 09, 2022 at 11:42:10AM +0800, Jason Wang wrote: > On Thu, Mar 31, 2022 at 2:05 AM Gautam Dawar wrote: > > > > Hi All: > > > > This series tries to add the support for control virtqueue in vDPA. > > > > Control virtqueue is used by networking device for accepting various > > commands fr

Re: [PATCH v1] vdpa: Do not count the pages that were already pinned in the vhost-vDPA

2022-05-09 Thread Jason Wang
On Mon, May 9, 2022 at 3:15 PM Cindy Lu wrote: > > We count pinned_vm as follow in vhost-vDPA > > lock_limit = rlimit(RLIMIT_MEMLOCK) >> PAGE_SHIFT; > if (npages + atomic64_read(&dev->mm->pinned_vm) > lock_limit) { > ret = -ENOMEM; > goto unlock; >

Re: [PATCH v1] vdpa: Do not count the pages that were already pinned in the vhost-vDPA

2022-05-09 Thread kernel test robot
submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Cindy-Lu/vdpa-Do-not-count-the-pages-that-were-already-pinned-in-the-vhost-vDPA/20220509-152644 base: https://git.kernel.org/pub

Re: [PATCH v3 1/2] kernel: add platform_has() infrastructure

2022-05-09 Thread Boris Petkov
On May 4, 2022 5:57:02 PM GMT+02:00, Juergen Gross wrote: >Add a simple infrastructure for setting, resetting and querying >platform feature flags. > >Flags can be either global or architecture specific. > >Signed-off-by: Juergen Gross >--- >V2: >- rename set/reset functions to platform_[set|c

Re: [PATCH v3 2/2] virtio: replace arch_has_restricted_virtio_memory_access()

2022-05-09 Thread Boris Petkov
On May 4, 2022 3:57:03 PM UTC, Juergen Gross wrote: >Instead of using arch_has_restricted_virtio_memory_access() together >with CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS, replace those >with platform_has() and a new platform feature >PLATFORM_VIRTIO_RESTRICTED_MEM_ACCESS. > >Signed-off-by

Re: [PATCH v1] vdpa: Do not count the pages that were already pinned in the vhost-vDPA

2022-05-09 Thread kernel test robot
submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Cindy-Lu/vdpa-Do-not-count-the-pages-that-were-already-pinned-in-the-vhost-vDPA/20220509-152644 base: https://git.kernel.org/pub

Re: [PATCH v1] vdpa: Do not count the pages that were already pinned in the vhost-vDPA

2022-05-09 Thread kernel test robot
patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Cindy-Lu/vdpa-Do-not-count-the-pages-that-were-already-pinned-in-the-vhost-vDPA/20220509-152644 base: https://git.kernel.org/pub/scm/li

Re: [PATCH v4 10/15] drm/shmem-helper: Take reservation lock instead of drm_gem_shmem locks

2022-05-09 Thread Daniel Vetter
On Fri, May 06, 2022 at 01:49:12AM +0300, Dmitry Osipenko wrote: > On 5/5/22 11:12, Daniel Vetter wrote: > > On Wed, May 04, 2022 at 06:56:09PM +0300, Dmitry Osipenko wrote: > >> On 5/4/22 11:21, Daniel Vetter wrote: > >> ... > > - Maybe also do what you suggest and keep a separate lock for thi

Re: [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-05-09 Thread Daniel Vetter
On Fri, May 06, 2022 at 03:10:43AM +0300, Dmitry Osipenko wrote: > On 5/5/22 11:34, Thomas Zimmermann wrote: > > Hi > > > > Am 18.04.22 um 00:37 schrieb Dmitry Osipenko: > >> Introduce a common DRM SHMEM shrinker. It allows to reduce code > >> duplication among DRM drivers that implement theirs ow

Re: [PATCH V4 1/9] virtio: use virtio_device_ready() in virtio_device_restore()

2022-05-09 Thread Cornelia Huck
On Sat, May 07 2022, Jason Wang wrote: > From: Stefano Garzarella > > It will allow us to do extension on virtio_device_ready() without > duplicating code. > > Cc: Thomas Gleixner > Cc: Peter Zijlstra > Cc: "Paul E. McKenney" > Cc: Marc Zyngier > Cc: Halil Pasic > Cc: Cornelia Huck > Signe

Re: [PATCH V4 3/9] virtio: introduce config op to synchronize vring callbacks

2022-05-09 Thread Cornelia Huck
On Sat, May 07 2022, Jason Wang wrote: > This patch introduces new virtio config op to vring > callbacks. Transport specific method is required to make sure the > write before this function is visible to the vring_interrupt() that is > called after the return of this function. For the transport t

Re: [PATCH V4 4/9] virtio-pci: implement synchronize_cbs()

2022-05-09 Thread Cornelia Huck
On Sat, May 07 2022, Jason Wang wrote: > We can simply reuse vp_synchronize_vectors() for .synchronize_cbs(). > > Cc: Thomas Gleixner > Cc: Peter Zijlstra > Cc: "Paul E. McKenney" > Cc: Marc Zyngier > Cc: Halil Pasic > Cc: Cornelia Huck > Signed-off-by: Jason Wang > --- > drivers/virtio/v

Re: [PATCH V4 5/9] virtio-mmio: implement synchronize_cbs()

2022-05-09 Thread Cornelia Huck
On Sat, May 07 2022, Jason Wang wrote: > Simply synchronize the platform irq that is used by us. > > Cc: Thomas Gleixner > Cc: Peter Zijlstra > Cc: "Paul E. McKenney" > Cc: Marc Zyngier > Cc: Halil Pasic > Cc: Cornelia Huck > Signed-off-by: Jason Wang > --- > drivers/virtio/virtio_mmio.c

Re: [PATCH V2 5/7] dt-bindings: Add xen, dev-domid property description for xen-grant DMA ops

2022-05-09 Thread Stefano Stabellini
On Sat, 7 May 2022, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > Introduce Xen specific binding for the virtualized device (e.g. virtio) > to be used by Xen grant DMA-mapping layer in the subsequent commit. > > This binding indicates that Xen grant mappings scheme needs to be > e

Re: [PATCH v11 0/6] Use pageblock_order for cma and alloc_contig_range alignment.

2022-05-09 Thread Andrew Morton
On Mon, 25 Apr 2022 10:31:12 -0400 Zi Yan wrote: > This patchset tries to remove the MAX_ORDER-1 alignment requirement for CMA > and alloc_contig_range(). It prepares for my upcoming changes to make > MAX_ORDER adjustable at boot time[1]. I'm thinking this looks ready to be merged into mm-stable

Re: [PATCH V4 1/9] virtio: use virtio_device_ready() in virtio_device_restore()

2022-05-09 Thread Jason Wang
On Mon, May 9, 2022 at 11:22 PM Cornelia Huck wrote: > > On Sat, May 07 2022, Jason Wang wrote: > > > From: Stefano Garzarella > > > > It will allow us to do extension on virtio_device_ready() without > > duplicating code. > > > > Cc: Thomas Gleixner > > Cc: Peter Zijlstra > > Cc: "Paul E. McK

Re: [PATCH] virtio_net: Remove unused case in virtio_skb_set_hash()

2022-05-09 Thread Jason Wang
On Mon, May 9, 2022 at 9:17 PM Tang Bin wrote: > > In this function, "VIRTIO_NET_HASH_REPORT_NONE" is included > in "default", so it canbe removed. > > Signed-off-by: Tang Bin > --- > drivers/net/virtio_net.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/virtio_net.c b/driv

Re: [PATCH v4 1/3] vdpa: Fix error logic in vdpa_nl_cmd_dev_get_doit

2022-05-09 Thread Jason Wang
On Mon, May 9, 2022 at 12:33 AM Eli Cohen wrote: > > In vdpa_nl_cmd_dev_get_doit(), ff the call to genlmsg_reply() fails we I guess you mean "if" here? > must not call nlmsg_free() since this is done inside genlmsg_reply(). > > Fix it. > > Fixes: bc0d90ee021f ("vdpa: Enable user to query vdpa de

Re: [PATCH v4 3/3] vdpa/mlx5: Add support for reading descriptor statistics

2022-05-09 Thread Jason Wang
On Mon, May 9, 2022 at 12:33 AM Eli Cohen wrote: > > Implement the get_vq_stats calback of vdpa_config_ops to return the > statistics for a virtqueue. > > The statistics are provided as vendor specific statistics where the > driver provides a pair of attribute name and attribute value. > > In addi

Re: [PATCH] virtio_net: Remove unused case in virtio_skb_set_hash()

2022-05-09 Thread Michael S. Tsirkin
On Mon, May 09, 2022 at 09:14:32PM +0800, Tang Bin wrote: > In this function, "VIRTIO_NET_HASH_REPORT_NONE" is included > in "default", so it canbe removed. > > Signed-off-by: Tang Bin What's the point of this? > --- > drivers/net/virtio_net.c | 1 - > 1 file changed, 1 deletion(-) > > diff -