Re: [RFC PATCH v1 0/8] virtio/vsock: experimental zerocopy receive

2022-05-19 Thread Stefano Garzarella
On Wed, May 18, 2022 at 11:04:30AM +, Arseniy Krasnov wrote: Hello Stefano, On 17.05.2022 18:14, Stefano Garzarella wrote: Hi Arseniy, On Thu, May 12, 2022 at 05:04:11AM +, Arseniy Krasnov wrote: INTRODUCTION Hello, this is experimental implementation

Re: [PATCH V5 6/9] virtio-ccw: implement synchronize_cbs()

2022-05-19 Thread Jason Wang
On Wed, May 18, 2022 at 5:32 PM Cornelia Huck wrote: > > On Wed, May 18 2022, Jason Wang wrote: > > > This patch tries to implement the synchronize_cbs() for ccw. For the > > vring_interrupt() that is called via virtio_airq_handler(), the > > synchronization is simply done via the airq_info's loc

Re: [PATCH V5 7/9] virtio: allow to unbreak virtqueue

2022-05-19 Thread Jason Wang
On Wed, May 18, 2022 at 6:04 PM Cornelia Huck wrote: > > On Wed, May 18 2022, Jason Wang wrote: > > > This patch allows the new introduced __virtio_break_device() to > > unbreak the virtqueue. > > > > Cc: Thomas Gleixner > > Cc: Peter Zijlstra > > Cc: "Paul E. McKenney" > > Cc: Marc Zyngier >

Re: [PATCH V5 2/9] virtio: use virtio_reset_device() when possible

2022-05-19 Thread Stefano Garzarella
On Wed, May 18, 2022 at 11:59:44AM +0800, Jason Wang wrote: This allows us to do common extension without duplicating code. Cc: Thomas Gleixner Cc: Peter Zijlstra Cc: "Paul E. McKenney" Cc: Marc Zyngier Cc: Halil Pasic Cc: Cornelia Huck Cc: Vineeth Vijayan Cc: Peter Oberparleiter Cc: lin

Re: [PATCH V5 3/9] virtio: introduce config op to synchronize vring callbacks

2022-05-19 Thread Stefano Garzarella
On Wed, May 18, 2022 at 11:59:45AM +0800, Jason Wang wrote: This patch introduces new virtio config op to vring callbacks. Transport specific method is required to make sure the write before this function is visible to the vring_interrupt() that is called after the return of this function. For th

Re: [PATCH V5 9/9] virtio: use WARN_ON() to warn illegal status value

2022-05-19 Thread Stefano Garzarella
On Wed, May 18, 2022 at 11:59:51AM +0800, Jason Wang wrote: We used to use BUG_ON() in virtio_device_ready() to detect illegal status value, this seems sub-optimal since the value is under the control of the device. Switch to use WARN_ON() instead. Cc: Thomas Gleixner Cc: Peter Zijlstra Cc: "P

Re: [PATCH 1/3] sched/headers: Fix compilation error with GCC 12

2022-05-19 Thread Peter Zijlstra
On Mon, Apr 25, 2022 at 04:07:43PM +0200, Christophe de Dinechin wrote: > >> extern struct sched_class __begin_sched_classes[]; > >> extern struct sched_class __end_sched_classes[]; > >> > >> -#define sched_class_highest (__end_sched_classes - 1) > >> +/* > >> + * sched_class_highests is really _

Re: [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-05-19 Thread Daniel Vetter
On Thu, May 12, 2022 at 10:04:53PM +0300, Dmitry Osipenko wrote: > On 5/12/22 20:04, Daniel Vetter wrote: > > On Thu, 12 May 2022 at 13:36, Dmitry Osipenko > > wrote: > >> > >> On 5/11/22 22:09, Daniel Vetter wrote: > >>> On Wed, May 11, 2022 at 07:06:18PM +0300, Dmitry Osipenko wrote: > On 5

Re: [PATCH] vdpasim: allow to enable a vq repeatedly

2022-05-19 Thread Stefano Garzarella
On Thu, May 19, 2022 at 04:31:45PM +0200, Eugenio Pérez wrote: Code must be resilient to enable a queue many times. At the moment the queue is resetting so it's definitely not the expected behavior. Fixes: 2c53d0f64c06 ("vdpasim: vDPA device simulator") Cc: sta...@vger.kernel.org Signed-off-by:

Re: [PATCH v3 2/2] virtio: replace arch_has_restricted_virtio_memory_access()

2022-05-19 Thread Juergen Gross via Virtualization
On 04.05.22 17:57, Juergen Gross wrote: Instead of using arch_has_restricted_virtio_memory_access() together with CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS, replace those with platform_has() and a new platform feature PLATFORM_VIRTIO_RESTRICTED_MEM_ACCESS. Signed-off-by: Juergen Gross C

Re: [PATCH v2] vdpasim: allow to enable a vq repeatedly

2022-05-19 Thread Stefano Garzarella
On Thu, May 19, 2022 at 04:59:19PM +0200, Eugenio Pérez wrote: Code must be resilient to enable a queue many times. At the moment the queue is resetting so it's definitely not the expected behavior. v2: set vq->ready = 0 at disable. Fixes: 2c53d0f64c06 ("vdpasim: vDPA device simulator") Cc: st