Re: [PATCH v6 17/22] drm/shmem-helper: Add generic memory shrinker

2022-06-24 Thread Daniel Vetter
On Mon, Jun 20, 2022 at 08:18:04AM -0700, Rob Clark wrote: > On Mon, Jun 20, 2022 at 7:09 AM Dmitry Osipenko > wrote: > > > > On 6/19/22 20:53, Rob Clark wrote: > > ... > > >> +static unsigned long > > >> +drm_gem_shmem_shrinker_count_objects(struct shrinker *shrinker, > > >> +

Re: [PATCH v6 17/22] drm/shmem-helper: Add generic memory shrinker

2022-06-24 Thread Daniel Vetter
On Sun, Jun 19, 2022 at 10:53:03AM -0700, Rob Clark wrote: > On Thu, May 26, 2022 at 4:55 PM Dmitry Osipenko > wrote: > > + mutex_unlock(&gem_shrinker->lock); > > As I mentioned on other thread, count_objects, being approximate but > lockless and fast is the important thing. Otherwise when

Re: [PATCH v2 3/5] vfio/iommu_type1: Remove the domain->ops comparison

2022-06-24 Thread Robin Murphy
On 2022-06-24 14:16, Jason Gunthorpe wrote: On Wed, Jun 22, 2022 at 08:54:45AM +0100, Robin Murphy wrote: On 2022-06-16 23:23, Nicolin Chen wrote: On Thu, Jun 16, 2022 at 06:40:14AM +, Tian, Kevin wrote: The domain->ops validation was added, as a precaution, for mixed-driver systems. Howe

Re: virtio_balloon regression in 5.19-rc3

2022-06-24 Thread Michael S. Tsirkin
On Tue, Jun 21, 2022 at 06:10:00PM +0200, Ben Hutchings wrote: > On Tue, 2022-06-21 at 17:34 +0800, Jason Wang wrote: > > On Tue, Jun 21, 2022 at 5:24 PM David Hildenbrand wrote: > > > > > > On 20.06.22 20:49, Ben Hutchings wrote: > > > > I've tested a 5.19-rc3 kernel on top of QEMU/KVM with mach

Re: [PATCH V3] virtio: disable notification hardening by default

2022-06-24 Thread Michael S. Tsirkin
On Fri, Jun 24, 2022 at 04:41:55PM +0800, Xuan Zhuo wrote: > On Wed, 22 Jun 2022 09:29:40 +0800, Jason Wang wrote: > > We try to harden virtio device notifications in 8b4ec69d7e09 ("virtio: > > harden vring IRQ"). It works with the assumption that the driver or > > core can properly call virtio_de

Re: [PATCH V3] virtio: disable notification hardening by default

2022-06-24 Thread Xuan Zhuo
On Wed, 22 Jun 2022 09:29:40 +0800, Jason Wang wrote: > We try to harden virtio device notifications in 8b4ec69d7e09 ("virtio: > harden vring IRQ"). It works with the assumption that the driver or > core can properly call virtio_device_ready() at the right > place. Unfortunately, this seems to be

[PATCH] vringh: iterate on iotlb_translate to handle large translations

2022-06-24 Thread Stefano Garzarella
iotlb_translate() can return -ENOBUFS if the bio_vec is not big enough to contain all the ranges for translation. This can happen for example if the VMM maps a large bounce buffer, without using hugepages, that requires more than 16 ranges to translate the addresses. To handle this case, let's ext

Re: [PATCH v10 00/41] virtio pci support VIRTIO_F_RING_RESET

2022-06-24 Thread Xuan Zhuo
On Fri, 24 Jun 2022 03:00:12 -0400, "Michael S. Tsirkin" wrote: > On Fri, Jun 24, 2022 at 10:55:40AM +0800, Xuan Zhuo wrote: > > The virtio spec already supports the virtio queue reset function. This > > patch set > > is to add this function to the kernel. The relevant virtio spec information >

Re: [PATCH v10 25/41] virtio_pci: struct virtio_pci_common_cfg add queue_notify_data

2022-06-24 Thread Xuan Zhuo
On Fri, 24 Jun 2022 02:59:39 -0400, "Michael S. Tsirkin" wrote: > On Fri, Jun 24, 2022 at 10:56:05AM +0800, Xuan Zhuo wrote: > > Add queue_notify_data in struct virtio_pci_common_cfg, which comes from > > here https://github.com/oasis-tcs/virtio-spec/issues/89 > > > > For not breaks uABI, add a n

Re: [PATCH v10 00/41] virtio pci support VIRTIO_F_RING_RESET

2022-06-24 Thread Michael S. Tsirkin
On Fri, Jun 24, 2022 at 10:55:40AM +0800, Xuan Zhuo wrote: > The virtio spec already supports the virtio queue reset function. This patch > set > is to add this function to the kernel. The relevant virtio spec information is > here: > > https://github.com/oasis-tcs/virtio-spec/issues/124 >

Re: [PATCH v10 25/41] virtio_pci: struct virtio_pci_common_cfg add queue_notify_data

2022-06-24 Thread Michael S. Tsirkin
On Fri, Jun 24, 2022 at 10:56:05AM +0800, Xuan Zhuo wrote: > Add queue_notify_data in struct virtio_pci_common_cfg, which comes from > here https://github.com/oasis-tcs/virtio-spec/issues/89 > > For not breaks uABI, add a new struct virtio_pci_common_cfg_notify. What exactly is meant by not break