Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-05 Thread Si-Wei Liu
On 8/5/2022 3:11 PM, Si-Wei Liu wrote: On 8/1/2022 9:45 PM, Gavin Li wrote: Currently add_recvbuf_big() allocates MAX_SKB_FRAGS segments for big packets even when GUEST_* offloads are not present on the device. However, if GSO is not supported, GUEST GSO (virtio term), or GRO HW (netdev core

Re: IOTLB support for vhost/vsock breaks crosvm on Android

2022-08-05 Thread Linus Torvalds
On Fri, Aug 5, 2022 at 11:11 AM Will Deacon wrote: > > [tl;dr a change from ~18 months ago breaks Android userspace and I don't > know what to do about it] Augh. I had hoped that android being "closer" to upstream would have meant that somebody actually tests android with upstream kernels. Peop

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-05 Thread Si-Wei Liu
On 8/1/2022 9:45 PM, Gavin Li wrote: Currently add_recvbuf_big() allocates MAX_SKB_FRAGS segments for big packets even when GUEST_* offloads are not present on the device. However, if GSO is not supported, GUEST GSO (virtio term), or GRO HW (netdev core term) it should have been be called.

IOTLB support for vhost/vsock breaks crosvm on Android

2022-08-05 Thread Will Deacon
Hi folks, [tl;dr a change from ~18 months ago breaks Android userspace and I don't know what to do about it] As part of the development work for next year's Android, we've recently been bringing up a 5.15 KVM host and have observed that vsock no longer works for communicating with a guest becaus

Re: [PATCH 00/12] drm/format-helper: Move to struct iosys_map

2022-08-05 Thread Sam Ravnborg
Hi Thomas, On Wed, Jul 27, 2022 at 01:33:00PM +0200, Thomas Zimmermann wrote: > Change format-conversion helpers to use struct iosys_map for source > and destination buffers. Update all users. Also prepare interface for > multi-plane color formats. > > The format-conversion helpers mostly used to

Re: [PATCH 12/12] drm/format-helper: Move destination-buffer handling into internal helper

2022-08-05 Thread Sam Ravnborg
Hi Thomas, On Wed, Jul 27, 2022 at 01:33:12PM +0200, Thomas Zimmermann wrote: > The format-convertion helpers handle several cases for different > values of destination buffer and pitch. Move that code into the > internal helper drm_fb_xfrm() and avoid quite a bit of duplucation. This is very nic

Re: [RFC PATCH v3 0/9] vsock: updates for SO_RCVLOWAT handling

2022-08-05 Thread Stefano Garzarella
Hi Arseniy, sorry but I didn't have time to review this series. I will definitely do it next Monday! Have a nice weekend, Stefano On Wed, Aug 03, 2022 at 01:48:06PM +, Arseniy Krasnov wrote: Hello, This patchset includes some updates for SO_RCVLOWAT: 1) af_vsock: During my experiments

Re: [PATCH RFC net-next] vsock: Reschedule connect_work for O_NONBLOCK connect() requests

2022-08-05 Thread Stefano Garzarella
On Thu, Aug 04, 2022 at 04:44:47PM -0700, Peilin Ye wrote: Hi Stefano, On Thu, Aug 04, 2022 at 08:59:23AM +0200, Stefano Garzarella wrote: The last thing I was trying to figure out before sending the patch was whether to set sock->state = SS_UNCONNECTED in vsock_connect_timeout(). I think we s

[PATCH] tools/virtio: initialize spinlocks in vring_test.c

2022-08-05 Thread Ricardo Cañuelo
The virtio_device vqs_list spinlocks must be initialized before use to prevent functions that manipulate the device virtualqueues, such as vring_new_virtqueue(), from blocking indefinitely. Signed-off-by: Ricardo Cañuelo --- tools/virtio/vringh_test.c | 2 ++ 1 file changed, 2 insertions(+) dif