Re: [RFC v3 6/7] virtio: in order support for virtio_ring

2022-09-06 Thread Jason Wang
在 2022/9/1 13:54, Guo Zhi 写道: If in order feature negotiated, we can skip the used ring to get buffer's desc id sequentially. For skipped buffers in the batch, the used ring doesn't contain the buffer length, actually there is not need to get skipped buffers' length as they are tx buffer.

Re: [PATCH v5 2/2] virtio-net: use mtu size as buffer length for big packets

2022-09-06 Thread Michael S. Tsirkin
On Thu, Sep 01, 2022 at 05:10:38AM +0300, Gavin Li wrote: > Currently add_recvbuf_big() allocates MAX_SKB_FRAGS segments for big > packets even when GUEST_* offloads are not present on the device. > However, if guest GSO is not supported, it would be sufficient to > allocate segments to cover just

Re: [RFC v3 3/7] vsock: batch buffers in tx

2022-09-06 Thread Jason Wang
在 2022/9/1 13:54, Guo Zhi 写道: Vsock uses buffers in order, and for tx driver doesn't have to know the length of the buffer. So we can do a batch for vsock if in order negotiated, only write one used ring for a batch of buffers Signed-off-by: Guo Zhi --- drivers/vhost/vsock.c | 12

Re: [RFC v3 1/7] vhost: expose used buffers

2022-09-06 Thread Jason Wang
在 2022/9/1 13:54, Guo Zhi 写道: Follow VIRTIO 1.1 spec, only writing out a single used ring for a batch of descriptors. Signed-off-by: Guo Zhi --- drivers/vhost/vhost.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/vhost/vhost.c

Re: [RFC v3 0/7] In order support for virtio_ring, vhost and vsock.

2022-09-06 Thread Jason Wang
在 2022/9/1 13:54, Guo Zhi 写道: In virtio-spec 1.1, new feature bit VIRTIO_F_IN_ORDER was introduced. When this feature has been negotiated, virtio driver will use descriptors in ring order: starting from offset 0 in the table, and wrapping around at the end of the table. Vhost devices will

Re: [virtio-dev] [PATCH v5 2/2] virtio-net: use mtu size as buffer length for big packets

2022-09-06 Thread Jason Wang
在 2022/9/1 10:10, Gavin Li 写道: Currently add_recvbuf_big() allocates MAX_SKB_FRAGS segments for big packets even when GUEST_* offloads are not present on the device. However, if guest GSO is not supported, it would be sufficient to allocate segments to cover just up the MTU size and no further.

Re: [PATCH net] virtio-net: add cond_resched() to the command waiting loop

2022-09-06 Thread Jason Wang
On Tue, Sep 6, 2022 at 6:56 PM Paolo Abeni wrote: > > On Mon, 2022-09-05 at 15:49 +0800, Jason Wang wrote: > > On Mon, Sep 5, 2022 at 3:15 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Sep 05, 2022 at 12:53:41PM +0800, Jason Wang wrote: > > > > Adding cond_resched() to the command waiting

Re: [PATCH v1] drm/ttm: Refcount allocated tail pages

2022-09-06 Thread Daniel Vetter
On Tue, Sep 06, 2022 at 10:01:47PM +0200, Daniel Vetter wrote: > On Mon, Aug 15, 2022 at 12:05:19PM +0200, Christian König wrote: > > Am 15.08.22 um 11:54 schrieb Dmitry Osipenko: > > > Higher order pages allocated using alloc_pages() aren't refcounted and > > > they > > > need to be refcounted,

Re: [PATCH v1] drm/ttm: Refcount allocated tail pages

2022-09-06 Thread Daniel Vetter
On Mon, Aug 15, 2022 at 12:05:19PM +0200, Christian König wrote: > Am 15.08.22 um 11:54 schrieb Dmitry Osipenko: > > Higher order pages allocated using alloc_pages() aren't refcounted and they > > need to be refcounted, otherwise it's impossible to map them by KVM. This > > patch sets the refcount

Re: [PATCH 2/3] MAINTAINERS: Change status of some VMware drivers

2022-09-06 Thread Nadav Amit via Virtualization
On Sep 6, 2022, at 10:27 AM, Vishnu Dasa wrote: > From: Vishnu Dasa > > Change the status from 'Maintained' to 'Supported' for VMWARE > BALLOON DRIVER, VMWARE PVRDMA DRIVER, VMWARE PVSCSI driver, > VMWARE VMCI DRIVER, VMWARE VMMOUSE SUBDRIVER and VMWARE VMXNET3 > ETHERNET DRIVER. > > This

[PATCH 3/3] MAINTAINERS: Add a new entry for VMWARE VSOCK VMCI TRANSPORT DRIVER

2022-09-06 Thread vdasa--- via Virtualization
From: Vishnu Dasa Add a new entry for VMWARE VSOCK VMCI TRANSPORT DRIVER in the MAINTAINERS file. Signed-off-by: Vishnu Dasa --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5a634b5d6f6c..0e52ee3521c3 100644 --- a/MAINTAINERS +++

[PATCH 2/3] MAINTAINERS: Change status of some VMware drivers

2022-09-06 Thread vdasa--- via Virtualization
From: Vishnu Dasa Change the status from 'Maintained' to 'Supported' for VMWARE BALLOON DRIVER, VMWARE PVRDMA DRIVER, VMWARE PVSCSI driver, VMWARE VMCI DRIVER, VMWARE VMMOUSE SUBDRIVER and VMWARE VMXNET3 ETHERNET DRIVER. This needs to be done to conform to the guidelines in [1]. Maintainers for

[PATCH 1/3] MAINTAINERS: Change VMware PVSCSI driver entry to upper case

2022-09-06 Thread vdasa--- via Virtualization
From: Vishnu Dasa Change 'VMware PVSCSI driver' entry to upper case. This is a trivial change being done for uniformity. Signed-off-by: Vishnu Dasa --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 38f9ef4b53ec..b75eb23a099b

[PATCH 0/3] MAINTAINERS: Update entries for some VMware drivers

2022-09-06 Thread vdasa--- via Virtualization
From: Vishnu Dasa This series updates a few existing maintainer entries for VMware supported drivers and adds a new entry for vsock vmci transport driver. Vishnu Dasa (3): MAINTAINERS: Change VMware PVSCSI driver entry to upper case MAINTAINERS: Change status of some VMware drivers

[PATCH] drm/bochs: fix blanking

2022-09-06 Thread Gerd Hoffmann
VGA_IS1_RC is the color mode register (VGA_IS1_RM the one for monochrome mode, note C vs. M at the end). So when using VGA_IS1_RC make sure the vga device is actually in color mode and set the corresponding bit in the misc register. Reproducible when booting VMs in UEFI mode with some edk2

Re: [PATCH] virtiofs: Drop unnecessary initialization in send_forget_request and virtio_fs_get_tree

2022-09-06 Thread Stefan Hajnoczi
On Tue, Sep 06, 2022 at 01:38:48AM -0400, Deming Wang wrote: > The variable is initialized but it is only used after its assignment. > > Signed-off-by: Deming Wang > --- > fs/fuse/virtio_fs.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/fs/fuse/virtio_fs.c

Re: [PATCH 0/6] virtio/vsock: introduce dgrams, sk_buff, and qdisc

2022-09-06 Thread Stefan Hajnoczi
Hi Bobby, If you are attending Linux Foundation conferences in Dublin, Ireland next week (Linux Plumbers Conference, Open Source Summit Europe, KVM Forum, ContainerCon Europe, CloudOpen Europe, etc) then you could meet Stefano Garzarella and others to discuss this patch series. Using netdev and

Re: [PATCH 3/6] vsock: add netdev to vhost/virtio vsock

2022-09-06 Thread Michael S. Tsirkin
On Mon, Aug 15, 2022 at 10:56:06AM -0700, Bobby Eshleman wrote: > In order to support usage of qdisc on vsock traffic, this commit > introduces a struct net_device to vhost and virtio vsock. > > Two new devices are created, vhost-vsock for vhost and virtio-vsock > for virtio. The devices are

Re: [PATCH net] virtio-net: add cond_resched() to the command waiting loop

2022-09-06 Thread Paolo Abeni
On Mon, 2022-09-05 at 15:49 +0800, Jason Wang wrote: > On Mon, Sep 5, 2022 at 3:15 PM Michael S. Tsirkin wrote: > > > > On Mon, Sep 05, 2022 at 12:53:41PM +0800, Jason Wang wrote: > > > Adding cond_resched() to the command waiting loop for a better > > > co-operation with the scheduler. This

Re: [PATCH] virtiofs: Drop unnecessary initialization in send_forget_request and virtio_fs_get_tree

2022-09-06 Thread kernel test robot
' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Deming-Wang/virtiofs-Drop-unnecessary-initialization-in-send_forget_request-and-virtio_fs_get_tree/20220906-135058 base:7e18e42e4b280c85b76967a9106a13ca61c16179

Re: [PATCH] Documentation: add basic information on vDPA

2022-09-06 Thread Xuan Zhuo
On Wed, 17 Aug 2022 18:19:56 -0400, Stefan Hajnoczi wrote: > The vDPA driver framework is largely undocumented. Add a basic page that > describes what vDPA is, where to get more information, and how to use > the simulator for testing. > > In the future it would be nice to add an overview of the

Re: [PATCH 0/6] virtio/vsock: introduce dgrams, sk_buff, and qdisc

2022-09-06 Thread Stefano Garzarella
On Thu, Aug 18, 2022 at 12:28:48PM +0800, Jason Wang wrote: 在 2022/8/17 14:54, Michael S. Tsirkin 写道: On Mon, Aug 15, 2022 at 10:56:03AM -0700, Bobby Eshleman wrote: Hey everybody, This series introduces datagrams, packet scheduling, and sk_buff usage to virtio vsock. The usage of struct

Re: [PATCH] Documentation: add basic information on vDPA

2022-09-06 Thread Stefano Garzarella
On Wed, Aug 17, 2022 at 06:19:56PM -0400, Stefan Hajnoczi wrote: The vDPA driver framework is largely undocumented. Add a basic page that describes what vDPA is, where to get more information, and how to use the simulator for testing. In the future it would be nice to add an overview of the