Re: [PATCH v3 3/4] vdpa: show dev config as-is in "vdpa dev show" output

2022-12-19 Thread Jason Wang
在 2022/10/29 07:23, Si-Wei Liu 写道: On 10/27/2022 1:47 AM, Jason Wang wrote: On Thu, Oct 27, 2022 at 2:31 PM Si-Wei Liu wrote: On 10/25/2022 9:44 PM, Jason Wang wrote: 在 2022/10/26 09:10, Si-Wei Liu 写道: On 10/24/2022 7:24 PM, Jason Wang wrote: On Tue, Oct 25, 2022 at 3:14 AM Si-Wei

[PATCH] virtio: fix virtio_config_ops kerneldocs

2022-12-19 Thread Ricardo Cañuelo
Fixes two warning messages when building htmldocs: warning: duplicate section name 'Note' warning: expecting prototype for virtio_config_ops(). Prototype was for vq_callback_t() instead Signed-off-by: Ricardo Cañuelo --- include/linux/virtio_config.h | 9 + 1 file

Re: [PATCH 3/3 v6] virtio: vdpa: new SolidNET DPU driver.

2022-12-19 Thread Alvaro Karsz
Hi Jason, > So I think we actually don't need to depend on HWMON here? > > hwmon.c is only complied when HWMON is enabled and we use IS_ENABLED to > exclude the hwmon specific does. We are not really depending on HWMON with "(HWMON || HWMON=n)" If HWMON=n, the driver can be compiled either as a

Re: [PATCH 3/3 v6] virtio: vdpa: new SolidNET DPU driver.

2022-12-19 Thread Jason Wang
在 2022/12/19 16:35, Alvaro Karsz 写道: This commit includes: 1) The driver to manage the controlplane over vDPA bus. 2) A HW monitor device to read health values from the DPU. Signed-off-by: Alvaro Karsz -- v2: - Auto detect the BAR used for communication. - When waiting for

Re: [PATCH 0/4] Fix probe failed when modprobe modules

2022-12-19 Thread Jason Wang
On Mon, Dec 19, 2022 at 6:15 PM Michael S. Tsirkin wrote: > > On Tue, Nov 29, 2022 at 11:37:09AM +0800, Jason Wang wrote: > > > > > > > > > Quite a lot of core work here. Jason are you still looking into > > > hardening? > > > > Yes, last time we've discussed a solution that depends on the first

Re: [PATCH v2 06/11] vduse: Support automatic irq callback affinity

2022-12-19 Thread Jason Wang
On Mon, Dec 19, 2022 at 12:56 PM Yongji Xie wrote: > > On Fri, Dec 16, 2022 at 1:30 PM Jason Wang wrote: > > > > On Mon, Dec 5, 2022 at 4:59 PM Xie Yongji wrote: > > > > > > This brings current interrupt affinity spreading mechanism > > > to vduse device. We will make use of

Re: [PATCH v2 03/11] vdpa: Add set_irq_affinity callback in vdpa_config_ops

2022-12-19 Thread Jason Wang
On Mon, Dec 19, 2022 at 3:12 PM Yongji Xie wrote: > > On Mon, Dec 19, 2022 at 2:06 PM Jason Wang wrote: > > > > On Mon, Dec 19, 2022 at 12:39 PM Yongji Xie wrote: > > > > > > On Fri, Dec 16, 2022 at 11:58 AM Jason Wang wrote: > > > > > > > > On Mon, Dec 5, 2022 at 4:43 PM Xie Yongji > > > >

Re: [PATCH v2 08/11] vduse: Add sysfs interface for irq callback affinity

2022-12-19 Thread Jason Wang
On Mon, Dec 19, 2022 at 1:16 PM Yongji Xie wrote: > > On Fri, Dec 16, 2022 at 1:35 PM Jason Wang wrote: > > > > On Mon, Dec 5, 2022 at 5:03 PM Xie Yongji wrote: > > > > > > Add sysfs interface for each vduse virtqueue to > > > show the affinity and effective affinity for irq > > > callback. > >

Re: [PATCH v2 05/11] vduse: Introduce bound workqueue for irq injection

2022-12-19 Thread Jason Wang
On Mon, Dec 19, 2022 at 1:04 PM Yongji Xie wrote: > > On Fri, Dec 16, 2022 at 12:02 PM Jason Wang wrote: > > > > On Mon, Dec 5, 2022 at 4:44 PM Xie Yongji wrote: > > > > > > This introduces a bound workqueue to support running > > > irq callback in a specified cpu. > > > > > > Signed-off-by:

Re: [PATCH 3/3 v6] virtio: vdpa: new SolidNET DPU driver.

2022-12-19 Thread Michael S. Tsirkin
On Mon, Dec 19, 2022 at 01:32:22PM +0200, Alvaro Karsz wrote: > Ok, > > > can be patch on top ... > > Just to be sure, you mean here to create a new patch adding a comment > to the kconfig file, not a new version for this patch, right? yes ___

Re: [RFC PATCH v1 0/2] virtio/vsock: fix mutual rx/tx hungup

2022-12-19 Thread Stefano Garzarella
Hi Arseniy, On Sat, Dec 17, 2022 at 8:42 PM Arseniy Krasnov wrote: > > Hello, > > seems I found strange thing(may be a bug) where sender('tx' later) and > receiver('rx' later) could stuck forever. Potential fix is in the first > patch, second patch contains reproducer, based on vsock test

[PATCH v5] virtio_blk: add VIRTIO_BLK_F_LIFETIME feature support

2022-12-19 Thread Alvaro Karsz
Implement the VIRTIO_BLK_F_LIFETIME feature for Virtio block devices. This commit introduces a new ioctl command, VIRTIO_BLK_IOCTL_GET_LIFETIME. VIRTIO_BLK_IOCTL_GET_LIFETIME ioctl asks for the block device to provide lifetime information by sending a VIRTIO_BLK_T_GET_LIFETIME command to the

Re: [PATCH v4] virtio_blk: add VIRTIO_BLK_F_LIFETIME feature support

2022-12-19 Thread Alvaro Karsz
> Since you repin it anyway, do you mind rebasing on top of my tree? Sure, no problem. > I would maybe add a comment Ok, i will add the comment in the new version. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org

Re: [PATCH 3/3 v6] virtio: vdpa: new SolidNET DPU driver.

2022-12-19 Thread Alvaro Karsz
Ok, > can be patch on top ... Just to be sure, you mean here to create a new patch adding a comment to the kconfig file, not a new version for this patch, right? ___ Virtualization mailing list Virtualization@lists.linux-foundation.org

Re: [PATCH 3/3 v6] virtio: vdpa: new SolidNET DPU driver.

2022-12-19 Thread Michael S. Tsirkin
On Mon, Dec 19, 2022 at 12:55:02PM +0200, Alvaro Karsz wrote: > > could we add a comment explaining this trick please? > > can be patch on top ... > > Add a comment where? > Do you mean adding a comment in the change log? Right here in kconfig file where the trick is.

Re: [PATCH 3/3 v6] virtio: vdpa: new SolidNET DPU driver.

2022-12-19 Thread Alvaro Karsz
> could we add a comment explaining this trick please? > can be patch on top ... Add a comment where? Do you mean adding a comment in the change log? ___ Virtualization mailing list Virtualization@lists.linux-foundation.org

Re: [RESEND PATCH v5 1/1] docs: driver-api: virtio: virtio on Linux

2022-12-19 Thread Michael S. Tsirkin
On Mon, Dec 19, 2022 at 03:38:11PM +0700, Bagas Sanjaya wrote: > On 12/19/22 13:20, Michael S. Tsirkin wrote: > > I think I agree with this comment. This seems minor enough so I applied > > the patch for now. Bagas would you like to post your suggestion as a patch > > on > > top? Would be

Re: [PATCH 3/3 v6] virtio: vdpa: new SolidNET DPU driver.

2022-12-19 Thread Michael S. Tsirkin
On Mon, Dec 19, 2022 at 10:35:11AM +0200, Alvaro Karsz wrote: > This commit includes: > 1) The driver to manage the controlplane over vDPA bus. > 2) A HW monitor device to read health values from the DPU. > > Signed-off-by: Alvaro Karsz > -- > v2: > - Auto detect the BAR used for

Re: [PATCH 3/3 v6] virtio: vdpa: new SolidNET DPU driver.

2022-12-19 Thread Michael S. Tsirkin
On Mon, Dec 19, 2022 at 05:43:55AM -0500, Michael S. Tsirkin wrote: > On Mon, Dec 19, 2022 at 10:35:11AM +0200, Alvaro Karsz wrote: > > This commit includes: > > 1) The driver to manage the controlplane over vDPA bus. > > 2) A HW monitor device to read health values from the DPU. > > > >

Re: [PATCH 3/3 v6] virtio: vdpa: new SolidNET DPU driver.

2022-12-19 Thread Michael S. Tsirkin
On Mon, Dec 19, 2022 at 10:35:11AM +0200, Alvaro Karsz wrote: > This commit includes: > 1) The driver to manage the controlplane over vDPA bus. > 2) A HW monitor device to read health values from the DPU. > > Signed-off-by: Alvaro Karsz As far as I can tell patches 1,2 are upstream right? So

Re: [PATCH v4] virtio_blk: add VIRTIO_BLK_F_LIFETIME feature support

2022-12-19 Thread Michael S. Tsirkin
On Mon, Dec 19, 2022 at 12:13:06PM +0200, Alvaro Karsz wrote: > Implement the VIRTIO_BLK_F_LIFETIME feature for Virtio block devices. > > This commit introduces a new ioctl command, VIRTIO_BLK_IOCTL_GET_LIFETIME. > > VIRTIO_BLK_IOCTL_GET_LIFETIME ioctl asks for the block device to provide >

Re: [PATCH 0/4] Fix probe failed when modprobe modules

2022-12-19 Thread Michael S. Tsirkin
On Tue, Nov 29, 2022 at 11:37:09AM +0800, Jason Wang wrote: > > > > > > Quite a lot of core work here. Jason are you still looking into > > hardening? > > Yes, last time we've discussed a solution that depends on the first > kick to enable the interrupt handler. But after some thought, it seems >

[PATCH v4] virtio_blk: add VIRTIO_BLK_F_LIFETIME feature support

2022-12-19 Thread Alvaro Karsz
Implement the VIRTIO_BLK_F_LIFETIME feature for Virtio block devices. This commit introduces a new ioctl command, VIRTIO_BLK_IOCTL_GET_LIFETIME. VIRTIO_BLK_IOCTL_GET_LIFETIME ioctl asks for the block device to provide lifetime information by sending a VIRTIO_BLK_T_GET_LIFETIME command to the

Re: [PATCH v3] virtio_blk: add VIRTIO_BLK_F_LIFETIME feature support

2022-12-19 Thread Alvaro Karsz
Hi Michael, Sorry, I had no time to create a new version. I'll do it today. Alvaro ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

[PATCH 3/3 v6] virtio: vdpa: new SolidNET DPU driver.

2022-12-19 Thread Alvaro Karsz
This commit includes: 1) The driver to manage the controlplane over vDPA bus. 2) A HW monitor device to read health values from the DPU. Signed-off-by: Alvaro Karsz -- v2: - Auto detect the BAR used for communication. - When waiting for the DPU to write a config, wait for 5secs

[RESEND PATCH 2/3] New PCI quirk for SolidRun SNET DPU.

2022-12-19 Thread Alvaro Karsz
The DPU advertises FLR, but it may cause the device to hang. This only happens with revision 0x1. Signed-off-by: Alvaro Karsz --- drivers/pci/quirks.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 285acc4aacc..809d03272c2 100644

[RESEND PATCH 1/3] Add SolidRun vendor id

2022-12-19 Thread Alvaro Karsz
The vendor id is used in 2 differrent source files, the SNET vdpa driver and pci quirks. Signed-off-by: Alvaro Karsz --- include/linux/pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index b362d90eb9b..33bbe3160b4 100644 ---

[RESEND PATCH 0/3] virtio: vdpa: new SolidNET DPU driver

2022-12-19 Thread Alvaro Karsz
This series adds a vDPA driver for SolidNET DPU. Patch 1 adds SolidRun vendor id to pci_ids. Patch 2 adds a pci quirk needed by the DPU. Patch 3 has the driver source code. Patch 1 is prerequisite for both patch 2 and patch 3. Alvaro Karsz (3): Add SolidRun vendor id New PCI quirk for