On Wed, Dec 21, 2022 at 09:28:16AM +0200, Tudor Ambarus wrote:
> Hi,
>
> I added Greg KH to the thread, maybe he can shed some light on whether
> new support can be marked as fixes and backported to stable. The rules
> on what kind of patches are accepted into the -stable tree don't mention
> new
The buffer size and the size passed to snprintf don't match, causing
clang warnings.
This patch increases a little bit the size of the buffer, and uses
sizeof() to get the buffer size.
This patch should be applied on top of the following patch:
virtio: vdpa: new SolidNET DPU driver,
by Alvaro
> Please post a follow-up ASAP. I can squash myself if I rebase.
>
> Thanks!
Sure, I'll do it now
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
On Wed, Dec 21, 2022 at 2:35 PM Michael S. Tsirkin wrote:
>
> On Wed, Dec 21, 2022 at 11:23:09AM +0800, Jason Wang wrote:
> > On Tue, Dec 20, 2022 at 10:02 PM Cindy Lu wrote:
> > >
> > > The input of vhost_vdpa_iotlb_unmap() was changed in 881ac7d2314f,
> > > But some function was not changed
On Tue, Dec 20, 2022 at 06:46:20PM +0200, Alvaro Karsz wrote:
> Hi Nathan,
>
> > This does not appear to be a false positive but what was the intent
> > here? Should the local name variables increase their length or should
> > the buffer length be reduced?
>
> You're right, the local name
On Wed, Dec 21, 2022 at 01:58:11PM +0800, Cindy Lu wrote:
> On Wed, 21 Dec 2022 at 11:23, Jason Wang wrote:
> >
> > On Tue, Dec 20, 2022 at 10:02 PM Cindy Lu wrote:
> > >
> > > The input of vhost_vdpa_iotlb_unmap() was changed in 881ac7d2314f,
> > > But some function was not changed while
On Wed, Dec 21, 2022 at 11:23:09AM +0800, Jason Wang wrote:
> On Tue, Dec 20, 2022 at 10:02 PM Cindy Lu wrote:
> >
> > The input of vhost_vdpa_iotlb_unmap() was changed in 881ac7d2314f,
> > But some function was not changed while calling this function.
> > Add this change
> >
> > Cc:
vDPA simulators are software emulated device, so let's switch to use
weak barriers to avoid extra overhead in the driver.
Signed-off-by: Jason Wang
---
drivers/vdpa/vdpa_sim/vdpa_sim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c
This patch adds support for basic vendor stats that include counters
for tx, rx and cvq.
Signed-off-by: Jason Wang
---
drivers/vdpa/vdpa_sim/vdpa_sim.c | 2 +
drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 215 ++-
2 files changed, 211 insertions(+), 6 deletions(-)
diff
Allow individual simulator to customize the allocation size.
Signed-off-by: Jason Wang
---
drivers/vdpa/vdpa_sim/vdpa_sim.c | 8 ++--
drivers/vdpa/vdpa_sim/vdpa_sim.h | 1 +
drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 1 +
drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 1 +
4 files changed, 9
This patch adds a new config ops callback to allow individual
simulator to implement the vendor stats callback.
Signed-off-by: Jason Wang
---
drivers/vdpa/vdpa_sim/vdpa_sim.c | 13 +
drivers/vdpa/vdpa_sim/vdpa_sim.h | 3 +++
2 files changed, 16 insertions(+)
diff --git
This allows us to control the allocation size of the structure.
Signed-off-by: Jason Wang
---
drivers/vdpa/vdpa_sim/vdpa_sim.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c
index
Hi All:
This series implements vendor stats in vdpasim_net. Please review.
Thanks
Jason Wang (4):
vdpa_sim: switch to use __vdpa_alloc_device()
vdpasim: customize allocation size
vdpa_sim: support vendor satistics
vdpa_sim_net: vendor satistics
drivers/vdpa/vdpa_sim/vdpa_sim.c |
On Tue, Dec 20, 2022 at 5:07 PM Alvaro Karsz wrote:
>
> Add a comment in Kconfig explaining the
> "depends on .. && (HWMON || HWMON=n)" part.
>
> This patch should be applied on top of the following patch:
>
> virtio: vdpa: new SolidNET DPU driver,
> by Alvaro Karsz alvaro.ka...@solid-run.com
>
>
On Tue, Dec 20, 2022 at 7:23 PM Michael S. Tsirkin wrote:
>
> When building without CONFIG_BLK_DEV_ZONED, VIRTIO_BLK_F_ZONED
> is excluded from array of driver features.
> As a result virtio_has_feature panics in virtio_check_driver_offered_feature
> since that by design verifies that a feature
On Tue, Dec 20, 2022 at 10:02 PM Cindy Lu wrote:
>
> The input of vhost_vdpa_iotlb_unmap() was changed in 881ac7d2314f,
> But some function was not changed while calling this function.
> Add this change
>
> Cc: sta...@vger.kernel.org
> Fixes: 881ac7d2314f ("vhost_vdpa: fix the crash in unmap a
On Tue, Dec 20, 2022 at 6:14 PM Yongji Xie wrote:
>
> On Tue, Dec 20, 2022 at 2:31 PM Jason Wang wrote:
> >
> > On Mon, Dec 19, 2022 at 3:12 PM Yongji Xie wrote:
> > >
> > > On Mon, Dec 19, 2022 at 2:06 PM Jason Wang wrote:
> > > >
> > > > On Mon, Dec 19, 2022 at 12:39 PM Yongji Xie
> > > >
On Tue, Dec 20, 2022 at 6:02 PM Yongji Xie wrote:
>
> On Tue, Dec 20, 2022 at 2:28 PM Jason Wang wrote:
> >
> > On Mon, Dec 19, 2022 at 1:04 PM Yongji Xie wrote:
> > >
> > > On Fri, Dec 16, 2022 at 12:02 PM Jason Wang wrote:
> > > >
> > > > On Mon, Dec 5, 2022 at 4:44 PM Xie Yongji
> > > >
On 12/18/2022 10:31 PM, Michael S. Tsirkin wrote:
On Fri, Oct 28, 2022 at 04:23:49PM -0700, Si-Wei Liu wrote:
I can post a v3 that shows the code, it shouldn't be
too hard.
I take it another version of this patchset is planned?
Yes, I saw you just merged "vdpa: merge functionally
On Tue, Dec 20, 2022 at 01:49:04PM -0700, Nathan Chancellor wrote:
> On Tue, Dec 20, 2022 at 06:46:20PM +0200, Alvaro Karsz wrote:
> > Hi Nathan,
> >
> > > This does not appear to be a false positive but what was the intent
> > > here? Should the local name variables increase their length or
On Tue, Dec 20, 2022, at 17:46, Alvaro Karsz wrote:
> Hi Nathan,
>
>> This does not appear to be a false positive but what was the intent
>> here? Should the local name variables increase their length or should
>> the buffer length be reduced?
>
> You're right, the local name variables and
* Published in IEEE Xplore
* Google Scholar H5-Index = 22
-- Doctoral Symposium of CISTI'2023
--
CISTI'2023 - 18th Iberian Conference on Information Systems and Technologies
20 - 23 of June 2023, University of
On Tue, Dec 20, 2022 at 07:52:01AM -0500, Michael S. Tsirkin wrote:
> virtio blk returns a 64 bit append_sector in an input buffer,
> in LE format. This field is not tagged as LE correctly, so
> even though the generated code is ok, we get warnings from sparse:
>
>
On Tue, Dec 20, 2022 at 07:41:53AM -0500, Michael S. Tsirkin wrote:
> virtblk_result returns blk_status_t which is a bitwise restricted type,
> so we are not supposed to stuff it in a plain int temporary variable.
> All we do with it is pass it on to a function expecting blk_status_t so
> the
On Tue, Dec 20, 2022 at 06:23:44AM -0500, Michael S. Tsirkin wrote:
> When building without CONFIG_BLK_DEV_ZONED, VIRTIO_BLK_F_ZONED
> is excluded from array of driver features.
> As a result virtio_has_feature panics in virtio_check_driver_offered_feature
> since that by design verifies that a
On Tue, Dec 20, 2022 at 8:21 AM Tudor Ambarus wrote:
>
> Hi,
>
> There's a bug [1] reported by syzkaller in linux-5.15.y that I'd like
> to squash. The commit in stable that introduces the bug is:
> b99c71f90978 net: skip virtio_net_hdr_set_proto if protocol already set
> The upstream commit for
Hi Nathan,
> This does not appear to be a false positive but what was the intent
> here? Should the local name variables increase their length or should
> the buffer length be reduced?
You're right, the local name variables and snprintf argument don't match.
Thanks for noticing.
I think that we
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
branch HEAD: e45fb347b630ee76482fe938ba76cf8eab811290 Add linux-next specific
files for 20221220
Error/Warning reports:
https://lore.kernel.org/oe-kbuild-all/202211242120.mzzvguln-...@intel.com
https
qemu-x86_64 and qemu-arm64 boot failed with Linux next-20221220 tag.
> >>> It is always reproducible with gcc-11/ gcc-12 and clang tool chains.
> >>>
> >>> Reported-by: Linux Kernel Functional Testing
> >>>
> >>> <6>[0.00]
virtio blk returns a 64 bit append_sector in an input buffer,
in LE format. This field is not tagged as LE correctly, so
even though the generated code is ok, we get warnings from sparse:
drivers/block/virtio_blk.c:332:33: sparse: sparse: cast to restricted __le64
Make sparse happy by using the
virtblk_result returns blk_status_t which is a bitwise restricted type,
so we are not supposed to stuff it in a plain int temporary variable.
All we do with it is pass it on to a function expecting blk_status_t so
the generated code is ok, but we get warnings from sparse:
On Tue, Dec 20, 2022 at 12:29:43PM +0100, Ricardo Cañuelo wrote:
> Fixes two warning messages when building htmldocs:
>
> warning: duplicate section name 'Note'
> warning: expecting prototype for virtio_config_ops().
> Prototype was for vq_callback_t() instead
>
> Link:
>
On 20/12/22 11:25, Michael S. Tsirkin wrote:
This doesn't matter I think, what Fixes tag does is tell tools
if you have commit A you want this one on top.
Ok, thanks for clarifying. v3 submitted.
Cheers,
Ricardo
___
Virtualization mailing list
Fixes two warning messages when building htmldocs:
warning: duplicate section name 'Note'
warning: expecting prototype for virtio_config_ops().
Prototype was for vq_callback_t() instead
Link:
https://lore.kernel.org/linux-next/20221220105956.47868...@canb.auug.org.au/
When building without CONFIG_BLK_DEV_ZONED, VIRTIO_BLK_F_ZONED
is excluded from array of driver features.
As a result virtio_has_feature panics in virtio_check_driver_offered_feature
since that by design verifies that a feature we are checking for
is listed in the feature array.
To fix, replace
On Tue, Dec 20, 2022 at 04:58:26PM +0700, Bagas Sanjaya wrote:
> Michael S. Tsirkin has asked me [1] to post my improv suggestions for
> now-applied virtio documentation [2], so here is the suggestion patch series.
> The original suggestion must be splitted since it contains three distinct
>
On Tue, Dec 20, 2022 at 06:27:59PM +0800, Xuan Zhuo wrote:
> On Tue, 20 Dec 2022 14:51:54 +0530, Naresh Kamboju
> wrote:
> > The qemu-x86_64 and qemu-arm64 boot failed with Linux next-20221220 tag.
> > It is always reproducible with gcc-11/ gcc-12 and clang tool chains
On Tue, Dec 20, 2022 at 04:12:05PM +0530, Naresh Kamboju wrote:
> On Tue, 20 Dec 2022 at 16:04, Xuan Zhuo wrote:
> >
> > On Tue, 20 Dec 2022 14:51:54 +0530, Naresh Kamboju
> > wrote:
> > > The qemu-x86_64 and qemu-arm64 boot failed with Linux next-20221220 tag.
&
On Tue, Dec 20, 2022 at 09:23:17AM +, Arseniy Krasnov wrote:
On 20.12.2022 11:33, Stefano Garzarella wrote:
On Tue, Dec 20, 2022 at 07:14:27AM +, Arseniy Krasnov wrote:
On 19.12.2022 18:41, Stefano Garzarella wrote:
Hello!
Hi Arseniy,
On Sat, Dec 17, 2022 at 8:42 PM Arseniy Krasnov
On Tue, Dec 20, 2022 at 07:16:38AM +, Arseniy Krasnov wrote:
Patchset consists of two parts:
1) Kernel patch
One patch from Bobby Eshleman. I took single patch from Bobby:
https://lore.kernel.org/lkml/d81818b868216c774613dd03641fcfe63cc55a45
.1660362668.git.bobby.eshle...@bytedance.com/ and
On Tue, Dec 20, 2022 at 07:23:46AM +, Arseniy Krasnov wrote:
This adds utility to check vsock rx/tx performance.
Usage as sender:
./vsock_perf --sender --port --bytes
Usage as receiver:
./vsock_perf --port --rcvlowat
Signed-off-by: Arseniy Krasnov
---
tools/testing/vsock/Makefile
On Tue, 20 Dec 2022 14:51:54 +0530, Naresh Kamboju
wrote:
> The qemu-x86_64 and qemu-arm64 boot failed with Linux next-20221220 tag.
> It is always reproducible with gcc-11/ gcc-12 and clang tool chains.
>
> Reported-by: Linux Kernel Functional Testing
>
> <6>[
On Tue, Dec 20, 2022 at 07:18:48AM +, Arseniy Krasnov wrote:
This removes behaviour, where error code returned from any transport
was always switched to ENOMEM. For example when user tries to send too
big message via SEQPACKET socket, transport layers return EMSGSIZE, but
this error code was
On Tue, Dec 20, 2022 at 10:54:17AM +0100, Ricardo Cañuelo wrote:
> Hi Bagas,
>
> Thanks for the review, some comments below:
>
> On 20/12/22 10:12, Bagas Sanjaya wrote:> On Tue, Dec 20, 2022 at 08:37:09AM
> +0100, Ricardo Cañuelo wrote:
> > Describe the steps needed to fix both warnings above.
On 20/12/22 10:48, AngeloGioacchino Del Regno wrote:
To avoid getting the same warning in the future (developer mistake and/or other
reasons), what about dropping this instance of "Note:" entirely?
I think that something like...
the dev->feature bits if it wants. Note that despite the
Fixes two warning messages when building htmldocs:
warning: duplicate section name 'Note'
warning: expecting prototype for virtio_config_ops().
Prototype was for vq_callback_t() instead
Link:
https://lore.kernel.org/linux-next/20221220105956.47868...@canb.auug.org.au/
Hi Bagas,
Thanks for the review, some comments below:
On 20/12/22 10:12, Bagas Sanjaya wrote:> On Tue, Dec 20, 2022 at 08:37:09AM
+0100, Ricardo Cañuelo wrote:
Describe the steps needed to fix both warnings above. I see in the diff that:
* move vq_callback_t() declaration above;
*
On Tue, Dec 20, 2022 at 02:51:54PM +0530, Naresh Kamboju wrote:
> The qemu-x86_64 and qemu-arm64 boot failed with Linux next-20221220 tag.
> It is always reproducible with gcc-11/ gcc-12 and clang tool chains.
>
> Reported-by: Linux Kernel Functional Testing
>
> <6>[
Add a comment in Kconfig explaining the
"depends on .. && (HWMON || HWMON=n)" part.
This patch should be applied on top of the following patch:
virtio: vdpa: new SolidNET DPU driver,
by Alvaro Karsz alvaro.ka...@solid-run.com
Signed-off-by: Alvaro Karsz
---
drivers/vdpa/Kconfig | 8
On Tue, Dec 20, 2022 at 3:26 PM Alvaro Karsz wrote:
>
> Hi Jason,
>
> > So I think we actually don't need to depend on HWMON here?
> >
> > hwmon.c is only complied when HWMON is enabled and we use IS_ENABLED to
> > exclude the hwmon specific does.
>
> We are not really depending on HWMON with
On Tue, Dec 20, 2022 at 07:14:27AM +, Arseniy Krasnov wrote:
On 19.12.2022 18:41, Stefano Garzarella wrote:
Hello!
Hi Arseniy,
On Sat, Dec 17, 2022 at 8:42 PM Arseniy Krasnov
wrote:
Hello,
seems I found strange thing(may be a bug) where sender('tx' later) and
receiver('rx' later)
51 matches
Mail list logo
