Re: [PATCH v2 05/13] vdpa: rewind at get_base, not set_base

2023-02-20 Thread Jason Wang
在 2023/2/8 17:42, Eugenio Pérez 写道: At this moment it is only possible to migrate to a vdpa device running with x-svq=on. As a protective measure, the rewind of the inflight descriptors was done at the destination. That way if the source sent a virtqueue with inuse descriptors they are always di

Re: [PATCH v2 04/13] vdpa: move vhost reset after get vring base

2023-02-20 Thread Jason Wang
在 2023/2/8 17:42, Eugenio Pérez 写道: The function vhost.c:vhost_dev_stop calls vhost operation vhost_dev_start(false). In the case of vdpa it totally reset and wipes the device, making the fetching of the vring base (virtqueue state) totally useless. The kernel backend does not use vhost_dev_sta

Re: [PATCH v2 03/13] vdpa: add vhost_vdpa_suspend

2023-02-20 Thread Jason Wang
在 2023/2/21 13:27, Jason Wang 写道: 在 2023/2/8 17:42, Eugenio Pérez 写道: The function vhost.c:vhost_dev_stop fetches the vring base so the vq state can be migrated to other devices.  However, this is unreliable in vdpa, since we didn't signal the device to suspend the queues, making the value fet

Re: [PATCH v2 03/13] vdpa: add vhost_vdpa_suspend

2023-02-20 Thread Jason Wang
在 2023/2/8 17:42, Eugenio Pérez 写道: The function vhost.c:vhost_dev_stop fetches the vring base so the vq state can be migrated to other devices. However, this is unreliable in vdpa, since we didn't signal the device to suspend the queues, making the value fetched useless. Suspend the device if

Re: [patch net-next] net: virtio_net: implement exact header length guest feature

2023-02-20 Thread Jason Wang
在 2023/2/20 21:56, Jiri Pirko 写道: Mon, Feb 20, 2023 at 01:55:33PM CET, m...@redhat.com wrote: On Mon, Feb 20, 2023 at 09:35:00AM +0100, Jiri Pirko wrote: Fri, Feb 17, 2023 at 02:47:36PM CET, m...@redhat.com wrote: On Fri, Feb 17, 2023 at 01:53:55PM +0100, Jiri Pirko wrote: Fri, Feb 17, 2023

Re: [patch net-next] net: virtio_net: implement exact header length guest feature

2023-02-20 Thread Jason Wang
On Mon, Feb 20, 2023 at 8:55 PM Michael S. Tsirkin wrote: > > On Mon, Feb 20, 2023 at 09:35:00AM +0100, Jiri Pirko wrote: > > Fri, Feb 17, 2023 at 02:47:36PM CET, m...@redhat.com wrote: > > >On Fri, Feb 17, 2023 at 01:53:55PM +0100, Jiri Pirko wrote: > > >> Fri, Feb 17, 2023 at 01:22:01PM CET, m..

Re: [PATCH vhost 08/10] virtio_ring: introduce dma sync api for virtio

2023-02-20 Thread Jason Wang
On Mon, Feb 20, 2023 at 3:05 PM Xuan Zhuo wrote: > > On Mon, 20 Feb 2023 13:38:20 +0800, Jason Wang wrote: > > On Tue, Feb 14, 2023 at 3:27 PM Xuan Zhuo > > wrote: > > > > > > These API has been introduced: > > > > > > * virtio_dma_need_sync > > > * virtio_dma_sync_single_range_for_cpu > > > *

Re: [PATCH vhost 10/10] virtio_ring: introduce virtqueue_reset()

2023-02-20 Thread Jason Wang
On Mon, Feb 20, 2023 at 3:04 PM Xuan Zhuo wrote: > > On Mon, 20 Feb 2023 13:38:30 +0800, Jason Wang wrote: > > On Tue, Feb 14, 2023 at 3:27 PM Xuan Zhuo > > wrote: > > > > > > Introduce virtqueue_reset() to release all buffer inside vq. > > > > > > Signed-off-by: Xuan Zhuo > > > --- > > > dri

Re: [PATCH vhost 07/10] virtio_ring: add api virtio_dma_map() for advance dma

2023-02-20 Thread Jason Wang
On Mon, Feb 20, 2023 at 3:02 PM Xuan Zhuo wrote: > > On Mon, 20 Feb 2023 13:38:24 +0800, Jason Wang wrote: > > On Tue, Feb 14, 2023 at 3:27 PM Xuan Zhuo > > wrote: > > > > > > Added virtio_dma_map() to map DMA addresses for virtual memory in > > > advance. The purpose is to keep memory mapped a

Re: [PATCH vhost 04/10] virtio_ring: split: introduce virtqueue_add_split_premapped()

2023-02-20 Thread Jason Wang
On Mon, Feb 20, 2023 at 2:56 PM Xuan Zhuo wrote: > > On Mon, 20 Feb 2023 13:38:13 +0800, Jason Wang wrote: > > On Tue, Feb 14, 2023 at 3:27 PM Xuan Zhuo > > wrote: > > > > > > virtqueue_add_split() only supports virtual addresses, dma is completed > > > in virtqueue_add_split(). > > > > > > In

[GIT PULL] virtio,vhost,vdpa: features, fixes

2023-02-20 Thread Michael S. Tsirkin
The following changes since commit ceaa837f96adb69c0df0397937cd74991d5d821a: Linux 6.2-rc8 (2023-02-12 14:10:17 -0800) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to deeacf35c922da579637f5db

Re: [patch net-next] net: virtio_net: implement exact header length guest feature

2023-02-20 Thread Michael S. Tsirkin
On Mon, Feb 20, 2023 at 02:56:08PM +0100, Jiri Pirko wrote: > Mon, Feb 20, 2023 at 01:55:33PM CET, m...@redhat.com wrote: > >On Mon, Feb 20, 2023 at 09:35:00AM +0100, Jiri Pirko wrote: > >> Fri, Feb 17, 2023 at 02:47:36PM CET, m...@redhat.com wrote: > >> >On Fri, Feb 17, 2023 at 01:53:55PM +0100, J

[linux-next:master] BUILD REGRESSION d2af0fa4bfa4ec29d03b449ccd43fee39501112d

2023-02-20 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: d2af0fa4bfa4ec29d03b449ccd43fee39501112d Add linux-next specific files for 20230220 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202302062224.byzetxh1-...@intel.com https

Re: [PATCH 17/17] drm/cirrus: Use VGA macro constants to unblank

2023-02-20 Thread Gerd Hoffmann
On Mon, Feb 20, 2023 at 03:22:03PM +0100, Thomas Zimmermann wrote: > Hi > > Am 16.02.23 um 12:33 schrieb Gerd Hoffmann: > > On Wed, Feb 15, 2023 at 05:15:17PM +0100, Thomas Zimmermann wrote: > > > Set the VGA bit for unblanking with macro constants instead of magic > > > values. No functional chan

Re: [PATCH v2] vhost/vdpa: Add MSI translation tables to iommu for software-managed MSI

2023-02-20 Thread Michael S. Tsirkin
On Mon, Feb 20, 2023 at 10:36:27AM +0800, Jason Wang wrote: > On Fri, Feb 17, 2023 at 6:11 PM Michael S. Tsirkin wrote: > > > > On Fri, Feb 17, 2023 at 01:35:59PM +0800, Jason Wang wrote: > > > On Fri, Feb 17, 2023 at 8:15 AM Jason Gunthorpe wrote: > > > > > > > > On Tue, Feb 07, 2023 at 08:08:43

Re: [PATCH 17/17] drm/cirrus: Use VGA macro constants to unblank

2023-02-20 Thread Thomas Zimmermann
Hi Am 16.02.23 um 12:33 schrieb Gerd Hoffmann: On Wed, Feb 15, 2023 at 05:15:17PM +0100, Thomas Zimmermann wrote: Set the VGA bit for unblanking with macro constants instead of magic values. No functional changes. blank/unblank should work simliar to bochs (see commit 250e743915d4), that is m

Re: [patch net-next] net: virtio_net: implement exact header length guest feature

2023-02-20 Thread Jiri Pirko
Mon, Feb 20, 2023 at 01:55:33PM CET, m...@redhat.com wrote: >On Mon, Feb 20, 2023 at 09:35:00AM +0100, Jiri Pirko wrote: >> Fri, Feb 17, 2023 at 02:47:36PM CET, m...@redhat.com wrote: >> >On Fri, Feb 17, 2023 at 01:53:55PM +0100, Jiri Pirko wrote: >> >> Fri, Feb 17, 2023 at 01:22:01PM CET, m...@red

Re: [patch net-next] net: virtio_net: implement exact header length guest feature

2023-02-20 Thread Michael S. Tsirkin
On Mon, Feb 20, 2023 at 09:35:00AM +0100, Jiri Pirko wrote: > Fri, Feb 17, 2023 at 02:47:36PM CET, m...@redhat.com wrote: > >On Fri, Feb 17, 2023 at 01:53:55PM +0100, Jiri Pirko wrote: > >> Fri, Feb 17, 2023 at 01:22:01PM CET, m...@redhat.com wrote: > >> >On Fri, Feb 17, 2023 at 01:15:47PM +0100, J

Re: [PATCH vhost 01/10] virtio_ring: split: refactor virtqueue_add_split() for premapped

2023-02-20 Thread Michael S. Tsirkin
On Mon, Feb 20, 2023 at 01:37:37PM +0800, Jason Wang wrote: > On Tue, Feb 14, 2023 at 3:27 PM Xuan Zhuo wrote: > > > > DMA-related logic is separated from the virtqueue_add_split to prepare > > for subsequent support for premapped. > > The patch seems to do more than what is described here. > >

Re: [PATCH] drm/gem: Expose the buffer object handle to userspace last

2023-02-20 Thread Christian König
Am 20.02.23 um 10:55 schrieb Tvrtko Ursulin: Hi, On 14/02/2023 13:59, Christian König wrote: Am 14.02.23 um 13:50 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Currently drm_gem_handle_create_tail exposes the handle to userspace before the buffer object constructions is complete. This allowi

Re: [patch net-next] net: virtio_net: implement exact header length guest feature

2023-02-20 Thread Jiri Pirko
Fri, Feb 17, 2023 at 02:47:36PM CET, m...@redhat.com wrote: >On Fri, Feb 17, 2023 at 01:53:55PM +0100, Jiri Pirko wrote: >> Fri, Feb 17, 2023 at 01:22:01PM CET, m...@redhat.com wrote: >> >On Fri, Feb 17, 2023 at 01:15:47PM +0100, Jiri Pirko wrote: >> >> From: Jiri Pirko >> >> >> >> virtio_net_hdr