Re: [PATCH 0/5] vDPA/ifcvf: implement immediate initialization mechanism

2023-04-02 Thread Jason Wang
On Fri, Mar 31, 2023 at 8:49 PM Zhu Lingshan wrote: > > Formerly, ifcvf driver has implemented a lazy-initialization mechanism > for the virtqueues and other config space contents, > it would store all configurations that passed down from the userspace, > then load them to the device config space

Re: [PATCH resend 1/2] vdpa/snet: support getting and setting VQ state

2023-04-02 Thread Jason Wang
On Sun, Apr 2, 2023 at 8:52 PM Alvaro Karsz wrote: > > This patch adds the get_vq_state and set_vq_state vDPA callbacks. > > In order to get the VQ state, the state needs to be read from the DPU. > In order to allow that, the old messaging mechanism is replaced with a new, > flexible control mecha

Re: [Patch v3] vdpa/mlx5: Avoid losing link state updates

2023-04-02 Thread Jason Wang
On Sun, Apr 2, 2023 at 10:15 PM Eli Cohen wrote: > > Current code ignores link state updates if VIRTIO_NET_F_STATUS was not > negotiated. However, link state updates could be received before feature > negotiation was completed , therefore causing link state events to be > lost, possibly leaving th

Re: [PATCH net-next 6/8] virtio_net: auto release xdp shinfo

2023-04-02 Thread Xuan Zhuo
On Mon, 3 Apr 2023 11:18:02 +0800, Jason Wang wrote: > > 在 2023/3/28 20:04, Xuan Zhuo 写道: > > virtnet_build_xdp_buff_mrg() and virtnet_xdp_handler() auto > > > I think you meant virtnet_xdp_handler() actually? > > > > release xdp shinfo then the caller no need to careful the xdp shinfo. > > > > Si

Re: [PATCH net-next 3/8] virtio_net: introduce virtnet_xdp_handler() to seprate the logic of run xdp

2023-04-02 Thread Xuan Zhuo
On Mon, 3 Apr 2023 10:43:03 +0800, Jason Wang wrote: > On Tue, Mar 28, 2023 at 8:04 PM Xuan Zhuo wrote: > > > > At present, we have two similar logic to perform the XDP prog. > > > > Therefore, this PATCH separates the code of executing XDP, which is > > conducive to later maintenance. > > > > Si

Re: [PATCH net-next 2/8] virtio_net: mergeable xdp: introduce mergeable_xdp_prepare

2023-04-02 Thread Xuan Zhuo
On Fri, 31 Mar 2023 17:14:33 +0800, Jason Wang wrote: > > 在 2023/3/28 20:04, Xuan Zhuo 写道: > > Separating the logic of preparation for xdp from receive_mergeable. > > > > The purpose of this is to simplify the logic of execution of XDP. > > > > The main logic here is that when headroom is insuffic

Re: [PATCH net-next 1/8] virtio_net: mergeable xdp: put old page immediately

2023-04-02 Thread Xuan Zhuo
On Fri, 31 Mar 2023 17:01:54 +0800, Jason Wang wrote: > On Tue, Mar 28, 2023 at 8:04 PM Xuan Zhuo wrote: > > > > In the xdp implementation of virtio-net mergeable, it always checks > > whether two page is used and a page is selected to release. This is > > complicated for the processing of action

Re: [PATCH net-next 6/8] virtio_net: auto release xdp shinfo

2023-04-02 Thread Jason Wang
在 2023/3/28 20:04, Xuan Zhuo 写道: virtnet_build_xdp_buff_mrg() and virtnet_xdp_handler() auto I think you meant virtnet_xdp_handler() actually? release xdp shinfo then the caller no need to careful the xdp shinfo. Signed-off-by: Xuan Zhuo --- drivers/net/virtio_net.c | 29 ++

Re: [PATCH net-next 5/8] virtio_net: separate the logic of freeing the rest mergeable buf

2023-04-02 Thread Jason Wang
On Tue, Mar 28, 2023 at 8:04 PM Xuan Zhuo wrote: > > This patch introduce a new function that frees the rest mergeable buf. > The subsequent patch will reuse this function. > > Signed-off-by: Xuan Zhuo Acked-by: Jason Wang Thanks > --- > drivers/net/virtio_net.c | 36

Re: [PATCH net-next 4/8] virtio_net: separate the logic of freeing xdp shinfo

2023-04-02 Thread Jason Wang
On Tue, Mar 28, 2023 at 8:04 PM Xuan Zhuo wrote: > > This patch introduce a new function that releases the > xdp shinfo. The subsequent patch will reuse this function. > > Signed-off-by: Xuan Zhuo Acked-by: Jason Wang Thanks > --- > drivers/net/virtio_net.c | 27 --- >

Re: [PATCH net-next 3/8] virtio_net: introduce virtnet_xdp_handler() to seprate the logic of run xdp

2023-04-02 Thread Jason Wang
On Tue, Mar 28, 2023 at 8:04 PM Xuan Zhuo wrote: > > At present, we have two similar logic to perform the XDP prog. > > Therefore, this PATCH separates the code of executing XDP, which is > conducive to later maintenance. > > Signed-off-by: Xuan Zhuo > --- > drivers/net/virtio_net.c | 142 ++

[PATCH resend 1/2] vdpa/snet: support getting and setting VQ state

2023-04-02 Thread Alvaro Karsz
This patch adds the get_vq_state and set_vq_state vDPA callbacks. In order to get the VQ state, the state needs to be read from the DPU. In order to allow that, the old messaging mechanism is replaced with a new, flexible control mechanism. This mechanism allows to read data from the DPU. The mec

[PATCH resend 2/2] vdpa/snet: support the suspend vDPA callback

2023-04-02 Thread Alvaro Karsz
When suspend is called, the driver sends a suspend command to the DPU through the control mechanism. Signed-off-by: Alvaro Karsz --- drivers/vdpa/solidrun/snet_ctrl.c | 6 ++ drivers/vdpa/solidrun/snet_main.c | 15 +++ drivers/vdpa/solidrun/snet_vdpa.h | 1 + 3 files changed, 2

[PATCH resend 0/2] vdpa/snet: support [s/g]et_vq_state and suspend

2023-04-02 Thread Alvaro Karsz
Add more vDPA callbacks. [s/g]et_vq_state is added in patch 1, including a new control mechanism to read data from the DPU. suspend is added in patch 2. Alvaro Karsz (2): vdpa/snet: support getting and setting VQ state vdpa/snet: support the suspend vDPA callback drivers/vdpa/solidrun/Make

Re: [PATCH 0/2] vdpa/snet: support [s/g]et_vq_state and suspend

2023-04-02 Thread Michael S. Tsirkin
On Sun, Apr 02, 2023 at 08:36:20AM +, Alvaro Karsz wrote: > > tagged. in the future pls CC everyone on the cover letter too. > > Ok, thanks. > > I'm not getting responses, should I resend it? Hmm maybe. Remember to add "PATCH resend" in the subject. git format-patch has a --subject-prefix f

Re: [PATCH 0/2] vdpa/snet: support [s/g]et_vq_state and suspend

2023-04-02 Thread Alvaro Karsz
> tagged. in the future pls CC everyone on the cover letter too. Ok, thanks. I'm not getting responses, should I resend it? ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virt

Re: [PATCH v6] virtio: add VIRTIO_F_NOTIFICATION_DATA feature support

2023-04-02 Thread Alvaro Karsz
Hi Viktor, > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > index 4c3bb0ddeb9b..f9c6604352b4 100644 > --- a/drivers/virtio/virtio_ring.c > +++ b/drivers/virtio/virtio_ring.c > @@ -2752,6 +2752,23 @@ void vring_del_virtqueue(struct virtqueue *_vq) > } > EXPORT_SYMBOL_G

[PATCH] virtio-vdpa: add VIRTIO_F_NOTIFICATION_DATA feature support

2023-04-02 Thread Alvaro Karsz
Add VIRTIO_F_NOTIFICATION_DATA support for vDPA transport. If this feature is negotiated, the driver passes extra data when kicking a virtqueue. A device that offers this feature needs to implement the kick_vq_with_data callback. kick_vq_with_data receives the vDPA device and data. data includes