Re: [PATCH] virtio-vdpa: Fix unchecked call to NULL set_vq_affinity

2023-05-12 Thread Shannon Nelson via Virtualization
On 5/12/23 6:30 AM, Michael S. Tsirkin wrote: On Fri, May 12, 2023 at 12:51:21PM +, Dragos Tatulea wrote: On Thu, 2023-05-04 at 14:51 -0400, Michael S. Tsirkin wrote: On Thu, May 04, 2023 at 01:08:54PM -0400, Feng Liu wrote: On 2023-05-04 a.m.9:50, Dragos Tatulea wrote: External email:

Re: [PATCH v6 0/3] Add sync object UAPI support to VirtIO-GPU driver

2023-05-12 Thread Gurchetan Singh
On Thu, May 11, 2023 at 7:33 PM Dmitry Osipenko < dmitry.osipe...@collabora.com> wrote: > On 5/12/23 03:17, Gurchetan Singh wrote: > ... > > Can we get one of the Mesa MRs reviewed first? There's currently no > > virtio-intel MR AFAICT, and the amdgpu one is marked as "Draft:". > > > > Even for t

[PATCH 1/3] MAINTAINERS: Update maintainers for paravirt-ops

2023-05-12 Thread Srivatsa S. Bhat
From: "Srivatsa S. Bhat (VMware)" I have decided to change employers and I'm not sure if I'll be able to spend as much time on the paravirt-ops subsystem going forward. So, I would like to remove myself from the maintainer role for paravirt-ops. Remove Srivatsa from the maintainers entry and add

[PATCH net 3/3] MAINTAINERS: Update maintainers for VMware virtual PTP clock driver

2023-05-12 Thread Srivatsa S. Bhat
From: "Srivatsa S. Bhat (VMware)" I have decided to change employers, so I would like to remove myself from the maintainer role for VMware-supported subsystems. Remove Srivatsa from the maintainers entry for VMware virtual PTP clock driver (ptp_vmw) and add Ajay Kaher as an additional reviewer.

[PATCH 2/3] MAINTAINERS: Update maintainers for VMware hypervisor interface

2023-05-12 Thread Srivatsa S. Bhat
From: "Srivatsa S. Bhat (VMware)" I have decided to change employers, so I would like to remove myself from the maintainer role for VMware-supported subsystems. Remove Srivatsa from the maintainers entry for VMware hypervisor interface and add Ajay Kaher as a co-maintainer. Also, update CREDITS

[PATCH] vdpa: consume device_features parameter

2023-05-12 Thread Shannon Nelson
From: Allen Hubbe Consume the parameter to device_features when parsing command line options. Otherwise the parameter may be used again as an option name. # vdpa dev add ... device_features 0xdeadbeef mac 00:11:22:33:44:55 Unknown option "0xdeadbeef" Fixes: a4442ce58ebb ("vdpa: allow provisi

Re: [PATCH 1/2] virtio: abstract virtqueue related methods

2023-05-12 Thread kernel test robot
Hi zhenwei, kernel test robot noticed the following build errors: [auto build test ERROR on mst-vhost/linux-next] [also build test ERROR on linus/master v6.4-rc1 next-20230512] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH net v6] virtio_net: Fix error unwinding of XDP initialization

2023-05-12 Thread Michael S. Tsirkin
On Fri, May 12, 2023 at 11:18:12AM -0400, Feng Liu wrote: > When initializing XDP in virtnet_open(), some rq xdp initialization > may hit an error causing net device open failed. However, previous > rqs have already initialized XDP and enabled NAPI, which is not the > expected behavior. Need to rol

[PATCH net v6] virtio_net: Fix error unwinding of XDP initialization

2023-05-12 Thread Feng Liu via Virtualization
When initializing XDP in virtnet_open(), some rq xdp initialization may hit an error causing net device open failed. However, previous rqs have already initialized XDP and enabled NAPI, which is not the expected behavior. Need to roll back the previous rq initialization to avoid leaks in error unwi

Re: [PATCH vhost v8 01/12] virtio_ring: split: separate dma codes

2023-05-12 Thread Christoph Hellwig
As said before, please don't try to do weird runtime checks based on the scatterlist. What you have works for now, but there are plans to repalce the page + offset tuple in the scatterlist with just a phys_addr_t. And with that your "clever" scheme will break instantly. __

Re: [PATCH] virtio-vdpa: Fix unchecked call to NULL set_vq_affinity

2023-05-12 Thread Michael S. Tsirkin
On Fri, May 12, 2023 at 12:51:21PM +, Dragos Tatulea wrote: > On Thu, 2023-05-04 at 14:51 -0400, Michael S. Tsirkin wrote: > > On Thu, May 04, 2023 at 01:08:54PM -0400, Feng Liu wrote: > > > > > > > > > On 2023-05-04 a.m.9:50, Dragos Tatulea wrote: > > > > External email: Use caution opening

Re: [PATCH] virtio-vdpa: Fix unchecked call to NULL set_vq_affinity

2023-05-12 Thread Dragos Tatulea
On Thu, 2023-05-04 at 14:51 -0400, Michael S. Tsirkin wrote: > On Thu, May 04, 2023 at 01:08:54PM -0400, Feng Liu wrote: > > > > > > On 2023-05-04 a.m.9:50, Dragos Tatulea wrote: > > > External email: Use caution opening links or attachments > > > > > > > > > The referenced patch calls set_vq_a

Re: Re: Re: [PATCH 1/2] virtio: abstract virtqueue related methods

2023-05-12 Thread zhenwei pi via Virtualization
On 5/12/23 19:35, Michael S. Tsirkin wrote: On Fri, May 12, 2023 at 07:09:40PM +0800, zhenwei pi wrote: On 5/12/23 18:46, Michael S. Tsirkin wrote: On Fri, May 12, 2023 at 05:46:17PM +0800, zhenwei pi wrote: There is already a virtqueue abstract structure in virtio subsystem (see struct virtqu

Re: Re: [PATCH 1/2] virtio: abstract virtqueue related methods

2023-05-12 Thread Michael S. Tsirkin
On Fri, May 12, 2023 at 07:09:40PM +0800, zhenwei pi wrote: > On 5/12/23 18:46, Michael S. Tsirkin wrote: > > On Fri, May 12, 2023 at 05:46:17PM +0800, zhenwei pi wrote: > > > There is already a virtqueue abstract structure in virtio subsystem > > > (see struct virtqueue in include/linux/virtio.h),

Re: Re: [PATCH 1/2] virtio: abstract virtqueue related methods

2023-05-12 Thread zhenwei pi via Virtualization
On 5/12/23 18:46, Michael S. Tsirkin wrote: On Fri, May 12, 2023 at 05:46:17PM +0800, zhenwei pi wrote: There is already a virtqueue abstract structure in virtio subsystem (see struct virtqueue in include/linux/virtio.h), however the vring based virtqueue is used only in the past years, the virt

Re: [PATCH 2/2] tools/virtio: implement virtqueue in test

2023-05-12 Thread Michael S. Tsirkin
On Fri, May 12, 2023 at 05:46:18PM +0800, zhenwei pi wrote: > virtqueue related functions has been removed from virtio_ring.c since > commit("virtio: abstract virtqueue related methods"), rather than > compiling with drivers/virtio/virtio.c, implement virtqueue functions > here. > > Signed-off-by:

Re: [PATCH 1/2] virtio: abstract virtqueue related methods

2023-05-12 Thread Michael S. Tsirkin
On Fri, May 12, 2023 at 05:46:17PM +0800, zhenwei pi wrote: > There is already a virtqueue abstract structure in virtio subsystem > (see struct virtqueue in include/linux/virtio.h), however the vring > based virtqueue is used only in the past years, the virtqueue related > methods mix much with vri

[PATCH 2/2] tools/virtio: implement virtqueue in test

2023-05-12 Thread zhenwei pi via Virtualization
virtqueue related functions has been removed from virtio_ring.c since commit("virtio: abstract virtqueue related methods"), rather than compiling with drivers/virtio/virtio.c, implement virtqueue functions here. Signed-off-by: zhenwei pi --- tools/virtio/Makefile | 4 +- tools/virtio/lin

[PATCH 1/2] virtio: abstract virtqueue related methods

2023-05-12 Thread zhenwei pi via Virtualization
There is already a virtqueue abstract structure in virtio subsystem (see struct virtqueue in include/linux/virtio.h), however the vring based virtqueue is used only in the past years, the virtqueue related methods mix much with vring(just look like the codes, virtqueue_xxx functions are implemented

[PATCH 0/2] virtio: abstract virtqueue related methods

2023-05-12 Thread zhenwei pi via Virtualization
Hi, 3 weeks ago, I posted a proposal 'Virtio Over Fabrics': https://lists.oasis-open.org/archives/virtio-comment/202304/msg00442.html Jason and Stefan pointed out that a non-vring based virtqueue has a chance to overwrite virtqueue instead of using vring virtqueue. Then I try to abstract virtque