Re: [PATCH] virtio_ring: validate used buffer length

2023-05-31 Thread Michael S. Tsirkin
On Thu, Jun 01, 2023 at 09:27:08AM +0800, Jason Wang wrote: > On Wed, May 31, 2023 at 6:25 PM Michael S. Tsirkin wrote: > > > > On Wed, May 31, 2023 at 04:26:38PM +0800, Jason Wang wrote: > > > On Wed, May 31, 2023 at 3:36 PM Jason Wang wrote: > > > > > > > > On Wed, May 31, 2023 at 1:50 PM

Re: [PATCH] virtio_ring: validate used buffer length

2023-05-31 Thread Michael S. Tsirkin
On Thu, Jun 01, 2023 at 09:12:53AM +0800, Jason Wang wrote: > On Wed, May 31, 2023 at 5:55 PM Michael S. Tsirkin wrote: > > > > On Wed, May 31, 2023 at 03:36:51PM +0800, Jason Wang wrote: > > > On Wed, May 31, 2023 at 1:50 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Wed, May 31, 2023

Re: [PATCH 3/3] fork, vhost: Use CLONE_THREAD to fix freezer/ps regression

2023-05-31 Thread Jason Wang
On Wed, May 31, 2023 at 5:14 PM Oleg Nesterov wrote: > > On 05/31, Jason Wang wrote: > > > > On Wed, May 31, 2023 at 3:25 PM Oleg Nesterov wrote: > > > > > > On 05/31, Jason Wang wrote: > > > > > > > > 在 2023/5/23 20:15, Oleg Nesterov 写道: > > > > > > > > > > /* make sure flag is seen

Re: [PATCH] virtio_ring: validate used buffer length

2023-05-31 Thread Jason Wang
On Wed, May 31, 2023 at 6:25 PM Michael S. Tsirkin wrote: > > On Wed, May 31, 2023 at 04:26:38PM +0800, Jason Wang wrote: > > On Wed, May 31, 2023 at 3:36 PM Jason Wang wrote: > > > > > > On Wed, May 31, 2023 at 1:50 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Wed, May 31, 2023 at

Re: [PATCH] virtio_ring: validate used buffer length

2023-05-31 Thread Jason Wang
On Wed, May 31, 2023 at 5:55 PM Michael S. Tsirkin wrote: > > On Wed, May 31, 2023 at 03:36:51PM +0800, Jason Wang wrote: > > On Wed, May 31, 2023 at 1:50 PM Michael S. Tsirkin wrote: > > > > > > On Wed, May 31, 2023 at 09:05:00AM +0800, Jason Wang wrote: > > > > On Mon, May 29, 2023 at 6:03 PM

Re: [PATCH V2] virtio-fs: Improved request latencies when Virtio queue is full

2023-05-31 Thread Vivek Goyal
On Wed, May 31, 2023 at 10:34:15PM +0200, Peter-Jan Gootzen wrote: > On 31/05/2023 21:18, Vivek Goyal wrote: > > On Wed, May 31, 2023 at 07:10:32PM +0200, Peter-Jan Gootzen wrote: > >> When the Virtio queue is full, a work item is scheduled > >> to execute in 1ms that retries adding the request to

Re: [PATCH V2] virtio-fs: Improved request latencies when Virtio queue is full

2023-05-31 Thread Peter-Jan Gootzen via Virtualization
On 31/05/2023 21:18, Vivek Goyal wrote: > On Wed, May 31, 2023 at 07:10:32PM +0200, Peter-Jan Gootzen wrote: >> When the Virtio queue is full, a work item is scheduled >> to execute in 1ms that retries adding the request to the queue. >> This is a large amount of time on the scale on which a >>

Re: [PATCH V2] virtio-fs: Improved request latencies when Virtio queue is full

2023-05-31 Thread Vivek Goyal
On Wed, May 31, 2023 at 07:10:32PM +0200, Peter-Jan Gootzen wrote: > When the Virtio queue is full, a work item is scheduled > to execute in 1ms that retries adding the request to the queue. > This is a large amount of time on the scale on which a > virtio-fs device can operate. When using a DPU

[PATCH V2] virtio-fs: Improved request latencies when Virtio queue is full

2023-05-31 Thread Peter-Jan Gootzen via Virtualization
When the Virtio queue is full, a work item is scheduled to execute in 1ms that retries adding the request to the queue. This is a large amount of time on the scale on which a virtio-fs device can operate. When using a DPU this is around 40us baseline without going to a remote server (4k, QD=1).

Re: [syzbot] [kvm?] [net?] [virt?] general protection fault in vhost_work_queue

2023-05-31 Thread Mike Christie
On 5/31/23 10:15 AM, Mike Christie wrote: >>> rcu would work for your case and for what Jason had requested. >> Yeah, so you already have some patches? >> >> Do you want to send it to solve this problem? >> > Yeah, I'll break them out and send them later today when I can retest > rebased patches.

Re: [PATCH] scsi: virtio_scsi: Remove a useless function call

2023-05-31 Thread Martin K. Petersen
Christophe, > 'inq_result' is known to be NULL. There is no point calling kfree(). Applied to 6.5/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering ___ Virtualization mailing list Virtualization@lists.linux-foundation.org

Re: [syzbot] [kvm?] [net?] [virt?] general protection fault in vhost_work_queue

2023-05-31 Thread Mike Christie
On 5/31/23 2:27 AM, Stefano Garzarella wrote: > On Tue, May 30, 2023 at 6:30 PM wrote: >> >> On 5/30/23 11:17 AM, Stefano Garzarella wrote: >>> On Tue, May 30, 2023 at 11:09:09AM -0500, Mike Christie wrote: On 5/30/23 11:00 AM, Stefano Garzarella wrote: > I think it is partially related

Re: [RFC PATCH v2 3/3] PCI: endpoint: Add EP function driver to provide virtio-console functionality

2023-05-31 Thread Shunsuke Mie
I'm sorry for late response. On 2023/05/19 11:01, Jason Wang wrote: On Thu, May 18, 2023 at 5:54 PM Shunsuke Mie wrote: Gentle ping ... Thanks, Shunsuke. On 2023/05/10 12:17, Shunsuke Mie wrote: Hi Json, 2023年5月8日(月) 13:03 Jason Wang : On Thu, Apr 27, 2023 at 6:44 PM Shunsuke Mie

Re: [PATCH] virtio_ring: validate used buffer length

2023-05-31 Thread Michael S. Tsirkin
On Wed, May 31, 2023 at 04:26:38PM +0800, Jason Wang wrote: > On Wed, May 31, 2023 at 3:36 PM Jason Wang wrote: > > > > On Wed, May 31, 2023 at 1:50 PM Michael S. Tsirkin wrote: > > > > > > On Wed, May 31, 2023 at 09:05:00AM +0800, Jason Wang wrote: > > > > On Mon, May 29, 2023 at 6:03 PM

Re: [PATCH] virtio_ring: validate used buffer length

2023-05-31 Thread Michael S. Tsirkin
On Wed, May 31, 2023 at 03:36:51PM +0800, Jason Wang wrote: > On Wed, May 31, 2023 at 1:50 PM Michael S. Tsirkin wrote: > > > > On Wed, May 31, 2023 at 09:05:00AM +0800, Jason Wang wrote: > > > On Mon, May 29, 2023 at 6:03 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Mon, May 29, 2023

Re: [PATCH 3/3] fork, vhost: Use CLONE_THREAD to fix freezer/ps regression

2023-05-31 Thread Oleg Nesterov
On 05/31, Jason Wang wrote: > > On Wed, May 31, 2023 at 3:25 PM Oleg Nesterov wrote: > > > > On 05/31, Jason Wang wrote: > > > > > > 在 2023/5/23 20:15, Oleg Nesterov 写道: > > > > > > > > /* make sure flag is seen after deletion */ > > > > smp_wmb(); > > > >

Re: [PATCH] virtio_ring: validate used buffer length

2023-05-31 Thread Jason Wang
On Wed, May 31, 2023 at 3:36 PM Jason Wang wrote: > > On Wed, May 31, 2023 at 1:50 PM Michael S. Tsirkin wrote: > > > > On Wed, May 31, 2023 at 09:05:00AM +0800, Jason Wang wrote: > > > On Mon, May 29, 2023 at 6:03 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Mon, May 29, 2023 at

Re: [PATCH 3/3] fork, vhost: Use CLONE_THREAD to fix freezer/ps regression

2023-05-31 Thread Jason Wang
On Wed, May 31, 2023 at 3:25 PM Oleg Nesterov wrote: > > On 05/31, Jason Wang wrote: > > > > 在 2023/5/23 20:15, Oleg Nesterov 写道: > > > > > > /* make sure flag is seen after deletion */ > > > smp_wmb(); > > > llist_for_each_entry_safe(work, work_next, node,

Re: [PATCH] virtio_ring: validate used buffer length

2023-05-31 Thread Jason Wang
On Wed, May 31, 2023 at 1:50 PM Michael S. Tsirkin wrote: > > On Wed, May 31, 2023 at 09:05:00AM +0800, Jason Wang wrote: > > On Mon, May 29, 2023 at 6:03 PM Michael S. Tsirkin wrote: > > > > > > On Mon, May 29, 2023 at 09:18:10AM +0800, Jason Wang wrote: > > > > On Sun, May 28, 2023 at 3:57 PM

Re: [syzbot] [kvm?] [net?] [virt?] general protection fault in vhost_work_queue

2023-05-31 Thread Stefano Garzarella
On Tue, May 30, 2023 at 6:30 PM wrote: > > On 5/30/23 11:17 AM, Stefano Garzarella wrote: > > On Tue, May 30, 2023 at 11:09:09AM -0500, Mike Christie wrote: > >> On 5/30/23 11:00 AM, Stefano Garzarella wrote: > >>> I think it is partially related to commit 6e890c5d5021 ("vhost: use > >>>

Re: [PATCH 3/3] fork, vhost: Use CLONE_THREAD to fix freezer/ps regression

2023-05-31 Thread Oleg Nesterov
On 05/31, Jason Wang wrote: > > 在 2023/5/23 20:15, Oleg Nesterov 写道: > > > > /* make sure flag is seen after deletion */ > > smp_wmb(); > > llist_for_each_entry_safe(work, work_next, node, node) { > > clear_bit(VHOST_WORK_QUEUED, >flags); > >