Re: [PATCH v2 0/2] vhost-scsi: Fix IO hangs when using windows

2023-07-11 Thread Mike Christie
On 7/11/23 1:34 PM, Stefan Hajnoczi wrote: > On Sun, Jul 09, 2023 at 03:28:57PM -0500, Mike Christie wrote: >> The following patches were made over Linus's tree and fix an issue >> where windows guests will send iovecs with offset/lengths that result >> in IOs that are not aligned to 512. The LIO l

Re: [PATCH v2 0/2] vhost-scsi: Fix IO hangs when using windows

2023-07-11 Thread Stefan Hajnoczi
On Sun, Jul 09, 2023 at 03:28:57PM -0500, Mike Christie wrote: > The following patches were made over Linus's tree and fix an issue > where windows guests will send iovecs with offset/lengths that result > in IOs that are not aligned to 512. The LIO layer will then send them > to Linux's FS/block l

Re: [PATCH] Revert "virtio-scsi: Send "REPORTED LUNS CHANGED" sense data upon disk hotplug events"

2023-07-11 Thread Mike Christie
What was the issue you are seeing? Was it something like you get the UA. We retry then on one of the retries the sense is not setup correctly, so the scsi error handler runs? That fails and the device goes offline? If you turn on scsi debugging you would see: [ 335.445922] sd 0:0:0:0: [sda] ta

Re: [PATCH] Revert "virtio-scsi: Send "REPORTED LUNS CHANGED" sense data upon disk hotplug events"

2023-07-11 Thread Stefan Hajnoczi
On Tue, 11 Jul 2023 at 13:06, Stefano Garzarella wrote: > > CCing `./scripts/get_maintainer.pl -f drivers/scsi/virtio_scsi.c`, > since I found a few things in the virtio-scsi driver... > > FYI we have seen that Linux has problems with a QEMU patch for the > virtio-scsi device (details at the botto

Re: [PATCH] Revert "virtio-scsi: Send "REPORTED LUNS CHANGED" sense data upon disk hotplug events"

2023-07-11 Thread Stefano Garzarella
CCing `./scripts/get_maintainer.pl -f drivers/scsi/virtio_scsi.c`, since I found a few things in the virtio-scsi driver... FYI we have seen that Linux has problems with a QEMU patch for the virtio-scsi device (details at the bottom of this email in the revert commit message and BZ). This is wha

Re: (subset) [PATCH v2 00/24] use vmalloc_array and vcalloc

2023-07-11 Thread Martin K. Petersen
On Tue, 27 Jun 2023 16:43:15 +0200, Julia Lawall wrote: > The functions vmalloc_array and vcalloc were introduced in > > commit a8749a35c399 ("mm: vmalloc: introduce array allocation functions") > > but are not used much yet. This series introduces uses of > these functions, to protect against

Re: [RFC 2/4] vduse: Add file operation for mmap

2023-07-11 Thread Maxime Coquelin
On 6/28/23 08:59, Cindy Lu wrote: From: Your Name Add the operation for mmap, The user space APP will use this function to map the pages to userspace Signed-off-by: Cindy Lu --- drivers/vdpa/vdpa_user/vduse_dev.c | 49 ++ 1 file changed, 49 insertions(+) dif

Re: [RFC 1/4] vduse: Add the struct to save the vq reconnect info

2023-07-11 Thread Maxime Coquelin
Hello Cindy, On 6/28/23 08:59, Cindy Lu wrote: From: Your Name this struct is to save the reconnect info struct, in this struct saved the page info that alloc to save the reconnect info Signed-off-by: Cindy Lu --- drivers/vdpa/vdpa_user/vduse_dev.c | 7 +++ 1 file changed, 7 insertion