Re: [PATCH v1] virtio-pci: Fix legacy device flag setting error in probe

2023-07-19 Thread Feng Liu via Virtualization
On 2023-07-19 p.m.10:27, Jason Wang wrote: External email: Use caution opening links or attachments On Wed, Jul 19, 2023 at 11:46 PM Feng Liu wrote: The 'is_legacy' flag is used to differentiate between legacy vs modern device. Currently, it is based on the value of vp_dev->ldev.ioaddr.

Re: [PATCH vhost v12 10/10] virtio_net: merge dma operations when filling mergeable buffers

2023-07-19 Thread Xuan Zhuo
] > > [cannot apply to mst-vhost/linux-next linus/master v6.5-rc2 v6.5-rc1 > > next-20230719] > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > And when submitting patch, we suggest to use '--base' as documented in > > https://git-scm.com

Re: [PATCH vhost v11 10/10] virtio_net: merge dma operation for one page

2023-07-19 Thread Xuan Zhuo
On Wed, 19 Jul 2023 05:51:50 -0400, "Michael S. Tsirkin" wrote: > On Wed, Jul 19, 2023 at 05:38:56PM +0800, Jason Wang wrote: > > On Wed, Jul 19, 2023 at 4:55 PM Michael S. Tsirkin wrote: > > > > > > On Wed, Jul 19, 2023 at 11:21:07AM +0800, Xuan Zhuo wrote: > > > > On Fri, 14 Jul 2023 06:37:10

Re: [PATCH v1] virtio-pci: Fix legacy device flag setting error in probe

2023-07-19 Thread Jason Wang
On Wed, Jul 19, 2023 at 11:46 PM Feng Liu wrote: > > The 'is_legacy' flag is used to differentiate between legacy vs modern > device. Currently, it is based on the value of vp_dev->ldev.ioaddr. > However, due to the shared memory of the union between struct > virtio_pci_legacy_device and struct

Re: [PATCH vhost v11 10/10] virtio_net: merge dma operation for one page

2023-07-19 Thread Xuan Zhuo
On Wed, 19 Jul 2023 04:55:04 -0400, "Michael S. Tsirkin" wrote: > On Wed, Jul 19, 2023 at 11:21:07AM +0800, Xuan Zhuo wrote: > > On Fri, 14 Jul 2023 06:37:10 -0400, "Michael S. Tsirkin" > > wrote: > > > On Wed, Jul 12, 2023 at 04:38:24PM +0800, Xuan Zhuo wrote: > > > > On Wed, 12 Jul 2023

Re: [PATCH] vdpa: reject F_ENABLE_AFTER_DRIVER_OK if backend does not support it

2023-07-19 Thread Si-Wei Liu
On 7/19/2023 3:26 PM, Michael S. Tsirkin wrote: On Wed, Jul 19, 2023 at 03:20:03PM -0700, Si-Wei Liu wrote: On 7/5/2023 11:07 PM, Michael S. Tsirkin wrote: On Wed, Jul 05, 2023 at 05:07:11PM -0700, Shannon Nelson wrote: On 7/5/23 11:27 AM, Eugenio Perez Martin wrote: On Wed, Jul 5, 2023

Re: [PATCH v1] virtio-pci: Fix legacy device flag setting error in probe

2023-07-19 Thread Xuan Zhuo
On Wed, 19 Jul 2023 11:45:50 -0400, Feng Liu wrote: > The 'is_legacy' flag is used to differentiate between legacy vs modern > device. Currently, it is based on the value of vp_dev->ldev.ioaddr. > However, due to the shared memory of the union between struct > virtio_pci_legacy_device and struct

Re: [PATCH] vpda: pds: fix building without debugfs

2023-07-19 Thread Shannon Nelson via Virtualization
On 7/19/23 12:40 PM, Arnd Bergmann wrote: From: Arnd Bergmann The new debugfs code still gets called when debugfs is disabled, resulting in a link failure: ERROR: modpost: "pds_vdpa_debugfs_del_vdpadev" [drivers/vdpa/pds/pds_vdpa.ko] undefined! ERROR: modpost: "pds_vdpa_debugfs_add_vdpadev"

Re: [PATCH] vdpa: reject F_ENABLE_AFTER_DRIVER_OK if backend does not support it

2023-07-19 Thread Si-Wei Liu
On 7/5/2023 11:07 PM, Michael S. Tsirkin wrote: On Wed, Jul 05, 2023 at 05:07:11PM -0700, Shannon Nelson wrote: On 7/5/23 11:27 AM, Eugenio Perez Martin wrote: On Wed, Jul 5, 2023 at 9:50 AM Jason Wang wrote: On Tue, Jul 4, 2023 at 11:45 PM Michael S. Tsirkin wrote: On Tue, Jul 04, 2023

Re: [PATCH] vdpa: reject F_ENABLE_AFTER_DRIVER_OK if backend does not support it

2023-07-19 Thread Michael S. Tsirkin
On Wed, Jul 19, 2023 at 03:20:03PM -0700, Si-Wei Liu wrote: > > > On 7/5/2023 11:07 PM, Michael S. Tsirkin wrote: > > On Wed, Jul 05, 2023 at 05:07:11PM -0700, Shannon Nelson wrote: > > > On 7/5/23 11:27 AM, Eugenio Perez Martin wrote: > > > > On Wed, Jul 5, 2023 at 9:50 AM Jason Wang wrote: >

[PATCH v1] virtio-pci: Fix legacy device flag setting error in probe

2023-07-19 Thread Feng Liu via Virtualization
The 'is_legacy' flag is used to differentiate between legacy vs modern device. Currently, it is based on the value of vp_dev->ldev.ioaddr. However, due to the shared memory of the union between struct virtio_pci_legacy_device and struct virtio_pci_modern_device, when virtio_pci_modern_probe

Re: [PATCH 1/1] MAINTAINERS: add vhost-scsi entry and myself as a co-maintainer

2023-07-19 Thread Stefan Hajnoczi
On Sat, Jul 15, 2023 at 09:20:27AM -0500, Mike Christie wrote: > I've been doing a lot of the development on vhost-scsi the last couple of > years, so per Michael T's suggestion this adds me as co-maintainer. > > Signed-off-by: Mike Christie > --- > MAINTAINERS | 11 ++- > 1 file

Re: [PATCH vhost v12 10/10] virtio_net: merge dma operations when filling mergeable buffers

2023-07-19 Thread Michael S. Tsirkin
On Wed, Jul 19, 2023 at 06:33:05PM +0800, kernel test robot wrote: > Hi Xuan, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on v6.4] > [cannot apply to mst-vhost/linux-next linus/master v6.5-rc2 v6.5-rc1 > next-20230719] > [

Re: [PATCH vhost v12 10/10] virtio_net: merge dma operations when filling mergeable buffers

2023-07-19 Thread kernel test robot
Hi Xuan, kernel test robot noticed the following build warnings: [auto build test WARNING on v6.4] [cannot apply to mst-vhost/linux-next linus/master v6.5-rc2 v6.5-rc1 next-20230719] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

Re: [PATCH vhost v11 10/10] virtio_net: merge dma operation for one page

2023-07-19 Thread Michael S. Tsirkin
On Wed, Jul 19, 2023 at 05:38:56PM +0800, Jason Wang wrote: > On Wed, Jul 19, 2023 at 4:55 PM Michael S. Tsirkin wrote: > > > > On Wed, Jul 19, 2023 at 11:21:07AM +0800, Xuan Zhuo wrote: > > > On Fri, 14 Jul 2023 06:37:10 -0400, "Michael S. Tsirkin" > > > wrote: > > > > On Wed, Jul 12, 2023 at

Re: [PATCH vhost v11 10/10] virtio_net: merge dma operation for one page

2023-07-19 Thread Jason Wang
On Wed, Jul 19, 2023 at 4:55 PM Michael S. Tsirkin wrote: > > On Wed, Jul 19, 2023 at 11:21:07AM +0800, Xuan Zhuo wrote: > > On Fri, 14 Jul 2023 06:37:10 -0400, "Michael S. Tsirkin" > > wrote: > > > On Wed, Jul 12, 2023 at 04:38:24PM +0800, Xuan Zhuo wrote: > > > > On Wed, 12 Jul 2023 16:37:43

Re: [PATCH vhost v11 10/10] virtio_net: merge dma operation for one page

2023-07-19 Thread Michael S. Tsirkin
On Wed, Jul 19, 2023 at 11:21:07AM +0800, Xuan Zhuo wrote: > On Fri, 14 Jul 2023 06:37:10 -0400, "Michael S. Tsirkin" > wrote: > > On Wed, Jul 12, 2023 at 04:38:24PM +0800, Xuan Zhuo wrote: > > > On Wed, 12 Jul 2023 16:37:43 +0800, Jason Wang > > > wrote: > > > > On Wed, Jul 12, 2023 at 4:33 

Re: [PATCH net-next v2 2/4] vsock/virtio: support to send non-linear skb

2023-07-19 Thread Stefano Garzarella
On Wed, Jul 19, 2023 at 07:46:05AM +0300, Arseniy Krasnov wrote: On 18.07.2023 23:27, Michael S. Tsirkin wrote: On Tue, Jul 18, 2023 at 09:02:35PM +0300, Arseniy Krasnov wrote: For non-linear skb use its pages from fragment array as buffers in virtio tx queue. These pages are already pinned