Re: [PATCH] vdpa/mlx5: Fix crash on shutdown for when no ndev exists

2023-07-31 Thread Jason Wang
On Mon, Jul 31, 2023 at 5:08 PM Michael S. Tsirkin wrote: > > On Mon, Jul 31, 2023 at 07:15:31AM +, Dragos Tatulea wrote: > > On Thu, 2023-07-27 at 12:28 -0400, Michael S. Tsirkin wrote: > > > On Thu, Jul 27, 2023 at 04:02:16PM +, Dragos Tatulea wrote: > > > > On Wed, 2023-07-26 at 15:26 -

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-07-31 Thread Xuan Zhuo
On Mon, 31 Jul 2023 19:36:06 -0700, Jakub Kicinski wrote: > On Tue, 1 Aug 2023 10:03:44 +0800 Xuan Zhuo wrote: > > > Virtio is either a SW > > > construct or offloaded to very capable HW, so either way cost of > > > creating an extra instance for DPDK or whatever else is very low. > > > > The extr

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-07-31 Thread Xuan Zhuo
On Mon, 31 Jul 2023 08:46:51 -0700, Jakub Kicinski wrote: > On Mon, 31 Jul 2023 09:23:29 +0800 Jason Wang wrote: > > > I'd step back and ask you why do you want to use AF_XDP with virtio. > > > Instead of bifurcating one virtio instance into different queues why > > > not create a separate virtio

Re: [PATCH] virtio: a new vcpu watchdog driver

2023-07-31 Thread Hannes Reinecke
On 7/31/23 04:30, Xuan Zhuo wrote: On Mon, 31 Jul 2023 09:25:12 +0800, "zhanghao1" wrote: A new virtio pci driver is added for listening to vcpus inside guest. Each vcpu creates a corresponding thread to periodically send data to qemu's back-end watchdog device. If a vCPU is in the stall state,

Re: [PATCH net-next] vsock: Remove unused function declarations

2023-07-31 Thread Stefano Garzarella
On Sat, Jul 29, 2023 at 08:20:36PM +0800, Yue Haibing wrote: These are never implemented since introduction in commit d021c344051a ("VSOCK: Introduce VM Sockets") Signed-off-by: Yue Haibing --- net/vmw_vsock/vmci_transport.h | 3 --- 1 file changed, 3 deletions(-) Good catch ;-) I'd used "vso

Re: [PATCH] vdpa/mlx5: Fix crash on shutdown for when no ndev exists

2023-07-31 Thread Michael S. Tsirkin
On Mon, Jul 31, 2023 at 07:15:31AM +, Dragos Tatulea wrote: > On Thu, 2023-07-27 at 12:28 -0400, Michael S. Tsirkin wrote: > > On Thu, Jul 27, 2023 at 04:02:16PM +, Dragos Tatulea wrote: > > > On Wed, 2023-07-26 at 15:26 -0400, Michael S. Tsirkin wrote: > > > > On Wed, Jul 26, 2023 at 10:07

Re: [PATCH] vdpa/mlx5: Fix crash on shutdown for when no ndev exists

2023-07-31 Thread Dragos Tatulea via Virtualization
On Thu, 2023-07-27 at 12:28 -0400, Michael S. Tsirkin wrote: > On Thu, Jul 27, 2023 at 04:02:16PM +, Dragos Tatulea wrote: > > On Wed, 2023-07-26 at 15:26 -0400, Michael S. Tsirkin wrote: > > > On Wed, Jul 26, 2023 at 10:07:38PM +0300, Dragos Tatulea wrote: > > > > The ndev was accessed on shut