Hi Greg,
You can't just say general GPL issues aside. Honestly, given your
company's prior actions in regards to Linux kernel drivers and the
licenses of them, I don't trust them at all. To help gain that trust
back, marking the exports in this manner will be a great improvement.
You
For many many years, you shipped closed source Linux kernel drivers
for
your products. Only recently has this changed.
and
all our Linux drivers, even if not all are upstream [yet], are GPL.
That's nice to hear, although without proof of that, we have to take
your word :)
The
Hi Chris,
Thanks a bunch for your really thorough review! I'll answer some of your
questions here. Shreyas can respond to your comments about some of the coding
style/comments/etc. in a separate mail.
INTx, MSI, MSI-X (25 vectors) interrupts
16 Rx queues, 8 Tx queues
Hi Arnd,
On Tuesday 29 September 2009, Chris Wright wrote:
+struct Vmxnet3_MiscConf {
+ struct Vmxnet3_DriverInfo driverInfo;
+ uint64_t uptFeatures;
+ uint64_t ddPA; /* driver data PA */
+ uint64_t queueDescPA;
Thanks a bunch for your really thorough review! I'll answer some of
your questions here. Shreyas can respond to your comments about some of
the coding style/comments/etc. in a separate mail.
The style is less important at this stage, but certainly eases review
to make it more consistent w/
