Re: [-next 0/5] Add the pci_is_vga() helper and use it

2023-10-06 Thread Bjorn Helgaas
On Wed, Aug 30, 2023 at 07:15:27PM +0800, Sui Jingfeng wrote: > From: Sui Jingfeng > > The PCI code and ID assignment specification defined four types of > display controllers for the display base class(03h), and the devices > with 0x00h sub-class code are VGA devices. VGA devices with

Re: [-next 1/5] PCI: Add the pci_is_vga() helper

2023-10-05 Thread Bjorn Helgaas
On Wed, Aug 30, 2023 at 07:15:28PM +0800, Sui Jingfeng wrote: > From: Sui Jingfeng > > The PCI code and ID assignment specification defined four types of > display controllers for the display base class(03h), and the devices > with 0x00h sub-class code are VGA devices. VGA devices with

Re: [-next 4/5] drm/virgpu: Switch to pci_is_vga()

2023-10-05 Thread Bjorn Helgaas
On Thu, Oct 05, 2023 at 04:57:14PM -0500, Bjorn Helgaas wrote: > In subject: "drm/virtio" to match previous history. > > On Wed, Aug 30, 2023 at 07:15:31PM +0800, Sui Jingfeng wrote: > > From: Sui Jingfeng > > > > Should be no functional change, just fo

Re: [-next 4/5] drm/virgpu: Switch to pci_is_vga()

2023-10-05 Thread Bjorn Helgaas
In subject: "drm/virtio" to match previous history. On Wed, Aug 30, 2023 at 07:15:31PM +0800, Sui Jingfeng wrote: > From: Sui Jingfeng > > Should be no functional change, just for cleanup purpose. > > Cc: David Airlie > Cc: Gerd Hoffmann > Cc: Gurchetan Singh > Cc: Chia-I Wu > Cc: Daniel

Re: [RFC PATCH v2 1/3] PCI: endpoint: introduce a helper to implement pci ep virtio function

2023-04-27 Thread Bjorn Helgaas
Simple typos, don't repost until there's more substantive feedback. On Thu, Apr 27, 2023 at 07:44:26PM +0900, Shunsuke Mie wrote: > The Linux PCIe Endpoint framework supports to implement PCIe endpoint > functions using a PCIe controller operating in endpoint mode. > It is possble to realize the

Re: [RFC PATCH v2 3/3] PCI: endpoint: Add EP function driver to provide virtio-console functionality

2023-04-27 Thread Bjorn Helgaas
Random typos and trivial things. No need to repost until somebody does a more substantive review. On Thu, Apr 27, 2023 at 07:44:28PM +0900, Shunsuke Mie wrote: > Add a new PCIe endpoint function driver that works as a pci virtio-console > device. The console connect to endpoint side console. It

Re: [RFC PATCH v2 0/3] Introduce a PCIe endpoint virtio console

2023-04-27 Thread Bjorn Helgaas
On Thu, Apr 27, 2023 at 07:44:25PM +0900, Shunsuke Mie wrote: > ... > PCI: endpoint: introduce a helper to implement pci ep virtio function > virtio_pci: add a definition of queue flag in ISR > PCI: endpoint: Add EP function driver to provide virtio-console > functionality Capitalize

Re: [PATCH v9 0/3] virtio: vdpa: new SolidNET DPU driver

2023-01-10 Thread Bjorn Helgaas
On Tue, Jan 10, 2023 at 06:56:35PM +0200, Alvaro Karsz wrote: > This series adds a vDPA driver for SolidNET DPU. > ... > v9: > - Indent PCI id in pci_ids.h with tabs - Patch 1. > - Wrap patch comment log to fill 75 columns - Patch 1 + 2. Beautiful, nice threading, thanks! :)

Re: [PATCH v8 1/3] PCI: Add SolidRun vendor ID

2023-01-10 Thread Bjorn Helgaas
On Tue, Jan 10, 2023 at 05:46:37PM +0200, Alvaro Karsz wrote: > > This should be indented with tabs instead of spaces so it matches the > > rest of the file. > > Michael, sorry about all the versions.. > Do you want me to fix it in a new version? > I could fix it with a patch directly to the pci

Re: [PATCH v8 1/3] PCI: Add SolidRun vendor ID

2023-01-10 Thread Bjorn Helgaas
On Mon, Jan 09, 2023 at 10:04:53AM +0200, Alvaro Karsz wrote: > Add SolidRun vendor ID to pci_ids.h > > The vendor ID is used in 2 different source files, > the SNET vDPA driver and PCI quirks. Nits: wrap to fill 75 columns. > Signed-off-by: Alvaro Karsz > Acked

Re: [RESEND PATCH 1/3] Add SolidRun vendor id

2022-12-29 Thread Bjorn Helgaas
# both in subject and commit log > > s/differrent/different/ > > s/vdpa/vDPA/ # seems to be the conventional style > > s/pci/PCI/ > > > > Make the commit log say what this patch does. > > > > > Signed-off-by: Alvaro Karsz

Re: [RESEND PATCH 1/3] Add SolidRun vendor id

2022-12-29 Thread Bjorn Helgaas
seems to be the conventional style s/pci/PCI/ Make the commit log say what this patch does. > Signed-off-by: Alvaro Karsz With the above and the sorting fix below: Acked-by: Bjorn Helgaas > --- > include/linux/pci_ids.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/i

Re: [RESEND PATCH 2/3] New PCI quirk for SolidRun SNET DPU.

2022-12-29 Thread Bjorn Helgaas
o, update the commit log so it says what this patch does, instead of simply describing the current situation. https://chris.beams.io/posts/git-commit/ is a good reference. With the above changes, Acked-by: Bjorn Helgaas > Signed-off-by: Alvaro Karsz > --- > drivers/pci/quirks.c | 8 &

Re: [PATCH 1/1] virtio_pci: use common helper to configure SR-IOV

2022-10-12 Thread Bjorn Helgaas via Virtualization
On Wed, Oct 12, 2022 at 5:01 AM Max Gurtovoy wrote: > > > On 10/12/2022 11:42 AM, Max Gurtovoy wrote: > > > > On 10/12/2022 8:02 AM, Michael S. Tsirkin wrote: > >> On Thu, Sep 29, 2022 at 02:40:08AM +0300, Max Gurtovoy wrote: > >>> This is instead of re-writing the same logic in virtio driver. >

Re: [PATCH v2] jailhouse: Hold reference returned from of_find_xxx API

2022-09-19 Thread Bjorn Helgaas
On Fri, Sep 16, 2022 at 10:25:31PM -0700, Srivatsa S. Bhat wrote: > [ Adding author and reviewers of commit 63338a38db95 again ] > > On 9/16/22 2:00 AM, Liang He wrote: > > In jailhouse_paravirt(), we should hold the reference returned from > > of_find_compatible_node() which has increased the

Re: [PATCH net-next v2 0/2] sfc: Add EF100 BAR config support

2022-07-11 Thread Bjorn Helgaas
On Mon, Jul 11, 2022 at 02:38:54PM +0100, Martin Habets wrote: > On Thu, Jul 07, 2022 at 10:55:00AM -0500, Bjorn Helgaas wrote: > > On Thu, Jul 07, 2022 at 02:07:07PM +0100, Martin Habets wrote: > > > The EF100 NICs allow for different register layouts of a PCI memory BAR.

Re: [PATCH net-next v2 0/2] sfc: Add EF100 BAR config support

2022-07-07 Thread Bjorn Helgaas
On Thu, Jul 07, 2022 at 02:07:07PM +0100, Martin Habets wrote: > The EF100 NICs allow for different register layouts of a PCI memory BAR. > This series provides the framework to switch this layout at runtime. > > Subsequent patch series will use this to add support for vDPA. Normally drivers

Re: [PATCH RESEND v5 1/4] PCI: Clean up pci_scan_slot()

2022-05-13 Thread Bjorn Helgaas
On Thu, May 12, 2022 at 04:56:42PM +0200, Niklas Schnelle wrote: > On Thu, 2022-05-05 at 10:38 +0200, Niklas Schnelle wrote: > > While determining the next PCI function is factored out of > > pci_scan_slot() into next_fn() the former still handles the first > > function as a special case. This

Re: [PATCH v3 1/4] PCI: Clean up pci_scan_slot()

2022-04-21 Thread Bjorn Helgaas
On Thu, Apr 21, 2022 at 11:27:42AM +0200, Niklas Schnelle wrote: > On Wed, 2022-04-20 at 21:14 -0500, Bjorn Helgaas wrote: > > On Tue, Apr 19, 2022 at 12:28:00PM +0200, Niklas Schnelle wrote: > > > While determining the next PCI function is factored out of > > > p

Re: [PATCH v3 1/4] PCI: Clean up pci_scan_slot()

2022-04-20 Thread Bjorn Helgaas
Hi Niklas, I'm sure this makes good sense, but I need a little more hand-holding. Sorry this is long and rambling. On Tue, Apr 19, 2022 at 12:28:00PM +0200, Niklas Schnelle wrote: > While determining the next PCI function is factored out of > pci_scan_slot() into next_fn() the former still

Re: [PATCH v3 05/11] PCI: Use driver_set_override() instead of open-coding

2022-02-28 Thread Bjorn Helgaas
/ or even better, s/for seting/to set/ > Signed-off-by: Krzysztof Kozlowski Acked-by: Bjorn Helgaas > - char*driver_override; /* Driver name to force a match */ > + /* > + * Driver name to force a match. > + * Do not set directly, because core

Re: [PATCH v3 01/11] driver: platform: Add helper for safer setting of driver_override

2022-02-28 Thread Bjorn Helgaas
On Sun, Feb 27, 2022 at 02:52:04PM +0100, Krzysztof Kozlowski wrote: > Several core drivers and buses expect that driver_override is a > dynamically allocated memory thus later they can kfree() it. > +int driver_set_override(struct device *dev, const char **override, > + const

Re: [PATCH v2 05/11] pci: use helper for safer setting of driver_override

2022-02-25 Thread Bjorn Helgaas
On Fri, Feb 25, 2022 at 10:36:20AM +0100, Krzysztof Kozlowski wrote: > On 25/02/2022 00:52, Bjorn Helgaas wrote: > > On Thu, Feb 24, 2022 at 08:49:15AM +0100, Krzysztof Kozlowski wrote: > >> On 23/02/2022 22:51, Bjorn Helgaas wrote: > >>> In subject, to match drivers

Re: [PATCH v2 05/11] pci: use helper for safer setting of driver_override

2022-02-24 Thread Bjorn Helgaas
On Thu, Feb 24, 2022 at 08:49:15AM +0100, Krzysztof Kozlowski wrote: > On 23/02/2022 22:51, Bjorn Helgaas wrote: > > In subject, to match drivers/pci/ convention, do something like: > > > > PCI: Use driver_set_override() instead of open-coding > > > > On Wed,

Re: [PATCH v2 01/11] driver: platform: add and use helper for safer setting of driver_override

2022-02-23 Thread Bjorn Helgaas
On Wed, Feb 23, 2022 at 08:13:00PM +0100, Krzysztof Kozlowski wrote: > Several core drivers and buses expect that driver_override is a > dynamically allocated memory thus later they can kfree() it. > ... > + * set_driver_override() - Helper to set or clear driver override. Doesn't match actual

Re: [PATCH v2 05/11] pci: use helper for safer setting of driver_override

2022-02-23 Thread Bjorn Helgaas
In subject, to match drivers/pci/ convention, do something like: PCI: Use driver_set_override() instead of open-coding On Wed, Feb 23, 2022 at 08:13:04PM +0100, Krzysztof Kozlowski wrote: > Use a helper for seting driver_override to reduce amount of duplicated > code. s/seting/setting/ >

Re: [PATCH v4 11/15] pci: Add pci_iomap_shared{,_range}

2021-08-25 Thread Bjorn Helgaas
On Tue, Aug 24, 2021 at 01:50:00PM -0700, Andi Kleen wrote: > > On 8/24/2021 1:31 PM, Bjorn Helgaas wrote: > > On Tue, Aug 24, 2021 at 01:14:02PM -0700, Andi Kleen wrote: > > > On 8/24/2021 11:55 AM, Bjorn Helgaas wrote: > > > > [+cc Rajat; I still don't know what

Re: [PATCH v4 11/15] pci: Add pci_iomap_shared{,_range}

2021-08-24 Thread Bjorn Helgaas
On Tue, Aug 24, 2021 at 01:14:02PM -0700, Andi Kleen wrote: > > On 8/24/2021 11:55 AM, Bjorn Helgaas wrote: > > [+cc Rajat; I still don't know what "shared memory with a hypervisor > > in a confidential guest" means, > > A confidential guest is a guest which

Re: [PATCH v4 11/15] pci: Add pci_iomap_shared{,_range}

2021-08-24 Thread Bjorn Helgaas
[+cc Rajat; I still don't know what "shared memory with a hypervisor in a confidential guest" means, but now we're talking about hardened drivers and allow lists, which Rajat is interested in] On Tue, Aug 24, 2021 at 10:20:44AM -0700, Andi Kleen wrote: > > > I see. Hmm. It's a bit of a random

Re: [PATCH v4 10/15] asm/io.h: Add ioremap_shared fallback

2021-08-12 Thread Bjorn Helgaas
On Wed, Aug 04, 2021 at 05:52:13PM -0700, Kuppuswamy Sathyanarayanan wrote: > From: Andi Kleen > > This function is for declaring memory that should be shared with > a hypervisor in a confidential guest. If the architecture doesn't > implement it it's just ioremap. I would assume

Re: [PATCH v4 09/15] pci: Consolidate pci_iomap* and pci_iomap*wc

2021-08-12 Thread Bjorn Helgaas
Is there a branch with all of this applied? I was going to apply this to help take a look at it, but it doesn't apply to v5.14-rc1. I know you listed some prereqs in the cover letter, but it's a fair amount of work to sort all that out. On Wed, Aug 04, 2021 at 05:52:12PM -0700, Kuppuswamy

Re: [PATCH] Fix "ordering" comment typos

2021-01-29 Thread Bjorn Helgaas
On Tue, Jan 26, 2021 at 01:50:42PM -0600, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > Fix comment typos in "ordering". > > Signed-off-by: Bjorn Helgaas > --- > arch/s390/include/asm/facility.h | 2 +- > drivers/gpu/drm/qxl/qxl_drv.c

[PATCH] Fix "ordering" comment typos

2021-01-26 Thread Bjorn Helgaas
From: Bjorn Helgaas Fix comment typos in "ordering". Signed-off-by: Bjorn Helgaas --- arch/s390/include/asm/facility.h | 2 +- drivers/gpu/drm/qxl/qxl_drv.c| 2 +- drivers/net/wireless/intel/iwlwifi/fw/file.h | 2 +- 3 files changed, 3 insertions(+), 3

Re: [PATCH v3 5/6] iommu/virtio: Support topology description in config space

2020-09-25 Thread Bjorn Helgaas
On Fri, Sep 25, 2020 at 10:12:43AM +0200, Jean-Philippe Brucker wrote: > On Thu, Sep 24, 2020 at 10:22:03AM -0500, Bjorn Helgaas wrote: > > On Fri, Aug 21, 2020 at 03:15:39PM +0200, Jean-Philippe Brucker wrote: > > > + /* Perform the init sequence before we can read the con

Re: [PATCH v3 5/6] iommu/virtio: Support topology description in config space

2020-09-24 Thread Bjorn Helgaas
On Fri, Aug 21, 2020 at 03:15:39PM +0200, Jean-Philippe Brucker wrote: > Platforms without device-tree nor ACPI can provide a topology > description embedded into the virtio config space. Parse it. > > Use PCI FIXUP to probe the config space early, because we need to > discover the topology

Re: [PATCH 2/2] virtio-mmio: Reject invalid IRQ 0 command line argument

2020-07-21 Thread Bjorn Helgaas
On Thu, Jul 02, 2020 at 11:06:11AM +0800, Jason Wang wrote: > On 2020/7/2 上午6:10, Bjorn Helgaas wrote: > > From: Bjorn Helgaas > > > > The "virtio_mmio.device=" command line argument allows a user to specify > > the size, address, and IRQ of a virtio device.

[PATCH 2/2] virtio-mmio: Reject invalid IRQ 0 command line argument

2020-07-01 Thread Bjorn Helgaas
From: Bjorn Helgaas The "virtio_mmio.device=" command line argument allows a user to specify the size, address, and IRQ of a virtio device. Previously the only requirement for the IRQ was that it be an unsigned integer. Zero is an unsigned integer but an invalid IRQ number,

Re: [PATCH v2 2/3] PCI: Add DMA configuration for virtual platforms

2020-03-18 Thread Bjorn Helgaas
is consistent, platforms can provide both a > device-tree and a built-in topology, and the IOMMU infrastructure is > able to deal with multiple DMA configuration methods. > > Signed-off-by: Jean-Philippe Brucker Acked-by: Bjorn Helgaas > --- > drivers/pci/pci-driver.c | 5 + >

Re: [PATCH v7] pci: quirk to skip msi disable on shutdown

2015-09-22 Thread Bjorn Helgaas via Virtualization
On Tue, Sep 22, 2015 at 02:29:03PM +0300, Michael S. Tsirkin wrote: > On Mon, Sep 21, 2015 at 05:10:43PM -0500, Bjorn Helgaas wrote: > > On Mon, Sep 21, 2015 at 10:42:13PM +0300, Michael S. Tsirkin wrote: > > > On Mon, Sep 21, 2015 at 01:21:47PM -0500, Bjorn Helgaas wrote: >

Re: [PATCH v7] pci: quirk to skip msi disable on shutdown

2015-09-22 Thread Bjorn Helgaas via Virtualization
On Tue, Sep 22, 2015 at 05:07:19PM +0300, Michael S. Tsirkin wrote: > On Tue, Sep 22, 2015 at 07:36:40AM -0500, Bjorn Helgaas wrote: > > On Tue, Sep 22, 2015 at 02:29:03PM +0300, Michael S. Tsirkin wrote: > > > On Mon, Sep 21, 2015 at 05:10:43PM -0500, Bjorn Helgaas wrote

Re: [PATCH v7] pci: quirk to skip msi disable on shutdown

2015-09-21 Thread Bjorn Helgaas via Virtualization
On Mon, Sep 21, 2015 at 10:42:13PM +0300, Michael S. Tsirkin wrote: > On Mon, Sep 21, 2015 at 01:21:47PM -0500, Bjorn Helgaas wrote: > > On Sun, Sep 06, 2015 at 06:32:35PM +0300, Michael S. Tsirkin wrote: > > > On some hypervisors, virtio devices tend to generate spurious int

Re: [PATCH v7] pci: quirk to skip msi disable on shutdown

2015-09-21 Thread Bjorn Helgaas via Virtualization
On Sun, Sep 06, 2015 at 06:32:35PM +0300, Michael S. Tsirkin wrote: > On some hypervisors, virtio devices tend to generate spurious interrupts > when switching between MSI and non-MSI mode. Normally, either MSI or > non-MSI is used and all is well, but during shutdown, linux disables MSI > which

Re: [PATCH v7] pci: quirk to skip msi disable on shutdown

2015-09-17 Thread Bjorn Helgaas via Virtualization
at wish to skip disabling msi on > shutdown, relying on bus master instead. > > We set this quirk in virtio core. > > Reported-by: Fam Zheng <f...@redhat.com> > Cc: Bjorn Helgaas <bhelg...@google.com> > Cc: Yinghai Lu <yhlu.kernel.s...@gmail.com> > Cc: Ul

Re: [PATCH v3 08/16] mn10300: drop dead code

2015-01-23 Thread Bjorn Helgaas
from an old kernel. It's not really needed: the generic pci_iomap does the right thing here. The new file isn't compiled so it's safe to drop. Cc: Bjorn Helgaas bhelg...@google.com Cc: linux-...@vger.kernel.org Cc: triv...@kernel.org Cc: David Howells dhowe...@redhat.com Signed-off

Re: [PATCH v3 09/16] pci: add pci_iomap_range

2015-01-23 Thread Bjorn Helgaas
On Wed, Jan 14, 2015 at 07:27:54PM +0200, Michael S. Tsirkin wrote: Virtio drivers should map the part of the BAR they need, not necessarily all of it. Cc: Bjorn Helgaas bhelg...@google.com Cc: linux-...@vger.kernel.org Acked-by: Arnd Bergmann a...@arndb.de Signed-off-by: Michael S

Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-21 Thread Bjorn Helgaas
[+cc Jingoo] On Fri, Jul 18, 2014 at 12:50 PM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Fri, 2014-07-18 at 11:17 -0700, Greg KH wrote: On Fri, Jul 18, 2014 at 09:54:32AM -0700, James Bottomley wrote: On Fri, 2014-07-18 at 09:43 -0700, Greg KH wrote: On Fri, Jul 18,

Re: [PATCH] virtio-blk: make the queue depth configurable

2014-03-19 Thread Bjorn Helgaas
drivers/pci/slot.c. Suggested-by: Joe Perches j...@perches.com Cc: Bjorn Helgaas bhelg...@google.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Signed-off-by: Rusty Russell ru...@rustcorp.com.au Acked-by: Bjorn Helgaas bhelg...@google.com for drivers/pci/slot.c It looks like fs/ocfs2/cluster

Re: [PATCH 16/16 v6] PCI: document the new PCI boot parameters

2008-10-22 Thread Bjorn Helgaas
On Wednesday 22 October 2008 02:45:31 am Yu Zhao wrote: Document the new PCI[x86] boot parameters. Cc: Alex Chiang [EMAIL PROTECTED] Cc: Grant Grundler [EMAIL PROTECTED] Cc: Greg KH [EMAIL PROTECTED] Cc: Ingo Molnar [EMAIL PROTECTED] Cc: Jesse Barnes [EMAIL PROTECTED] Cc: Matthew Wilcox

Re: [PATCH 8/16 v6] PCI: add boot options to reassign resources

2008-10-22 Thread Bjorn Helgaas
On Wednesday 22 October 2008 02:43:03 am Yu Zhao wrote: This patch adds boot options so user can reassign device resources of all devices under a bus. The boot options can be used as: pci=assign-mmio=:01,assign-pio=:02 '[:]bb' is the domain and bus number. I think this

Re: [PATCH 9/16 v6] PCI: add boot option to align MMIO resources

2008-10-22 Thread Bjorn Helgaas
On Wednesday 22 October 2008 02:43:24 am Yu Zhao wrote: This patch adds boot option to align MMIO resource for a device. The alignment is a bigger value between the PAGE_SIZE and the resource size. It looks like this forces alignment on PAGE_SIZE, not a bigger value between the PAGE_SIZE and

Re: [PATCH 2/16 v6] PCI: define PCI resource names in an 'enum'

2008-10-22 Thread Bjorn Helgaas
On Wednesday 22 October 2008 08:44:24 am Yu Zhao wrote: Bjorn Helgaas wrote: On Wednesday 22 October 2008 02:40:41 am Yu Zhao wrote: This patch moves all definitions of the PCI resource names to an 'enum', and also replaces some hard-coded resource variables with symbol names. This change