Re: [PATCH] virtio-net: add schedule check to napi_enable call in refill_work

2011-02-09 Thread Bruce Rogers
>>> On 2/9/2011 at 06:31 PM, Rusty Russell wrote: > On Thu, 10 Feb 2011 06:59:25 am Ken Stailey wrote: >> Justification: >> >> Impact: Under heavy network I/O load virtio-net driver crashes making VM > guest unusable. > > Hmm, this went badly wrong. I acked this patch, and it was mailed to >

Re: [PATCH] virtio_net: indicate oom when addbuf returns failure

2010-06-10 Thread Bruce Rogers
onsider for the 2.6.32 and 2.6.33 stable trees. >> >> If the add_buf operation fails, indicate failure to the caller. >> >> Signed-off-by: Bruce Rogers >> Signed-off-by: Rusty Russell > > Actually this code looks strange: > Note that add_buf inicates out of me

[PATCH 2/3][STABLE] KVM: indicate oom if add_buf fails

2010-06-08 Thread Bruce Rogers
This patch is a subset of an already upstream patch, but this portion is useful in earlier releases. Please consider for the 2.6.32 and 2.6.33 stable trees. If the add_buf operation fails, indicate failure to the caller. Signed-off-by: Bruce Rogers --- a/drivers/net/virtio_net.c +++ b

[PATCH 1/3][STABLE] KVM: fix delayed refill checking

2010-06-08 Thread Bruce Rogers
Please consider this for the 2.6.32 stable tree: commit 39d321577405e8e269fd238b278aaf2425fa788a Author: Herbert Xu Date: Mon Jan 25 15:51:01 2010 -0800 virtio_net: Make delayed refill more reliable I have seen RX stalls on a machine that experienced a suspected OOM. After the st

[PATCH 3/3][STABLE] KVM: add schedule check to napi_enable call

2010-06-08 Thread Bruce Rogers
stop receiving packets. With this patch applied we no longer see any problems in the driver while performing these tests for extended periods of time. Make sure napi is scheduled subsequent to each napi_enable. Signed-off-by: Bruce Rogers Signed-off-by: Olaf Kirch --- a/driver

[PATCH 0/3][STABLE] KVM: Various issues in virtio_net

2010-06-08 Thread Bruce Rogers
trees. (I assume this last problem also exists in more recent kernels than 2.6.32, but I haven't validated that.) With these 3 patches applied we no longer see any issues with virito networking using our certification test suite. Signed-off-by: Bruce R