Re: [PATCH] virtiofs: Enable multiple request queues

2021-05-11 Thread Connor Kuehl
On 5/11/21 5:23 AM, Stefan Hajnoczi wrote: > On Fri, May 07, 2021 at 05:15:27PM -0500, Connor Kuehl wrote: >> @@ -1245,7 +1262,8 @@ __releases(fiq->lock) >> req->in.h.nodeid, req->in.h.len, >> fuse_len_args(req->args-

Re: [PATCH] virtiofs: Enable multiple request queues

2021-05-10 Thread Connor Kuehl
On 5/10/21 10:25 AM, Vivek Goyal wrote: > On Fri, May 07, 2021 at 03:15:27PM -0700, Connor Kuehl wrote: >> Distribute requests across the multiqueue complex automatically based >> on the IRQ affinity. > > Hi Connor, > > Thanks for the patch. I will look into it and als

Re: [PATCH] virtiofs: Enable multiple request queues

2021-05-08 Thread Connor Kuehl
On 5/7/21 5:15 PM, Connor Kuehl wrote: > Distribute requests across the multiqueue complex automatically based > on the IRQ affinity. > > Suggested-by: Stefan Hajnoczi > Signed-off-by: Connor Kuehl > --- > fs/fuse/virtio_fs.c | 30 -- > 1 fil

[PATCH] virtiofs: Enable multiple request queues

2021-05-07 Thread Connor Kuehl
Distribute requests across the multiqueue complex automatically based on the IRQ affinity. Suggested-by: Stefan Hajnoczi Signed-off-by: Connor Kuehl --- fs/fuse/virtio_fs.c | 30 -- 1 file changed, 24 insertions(+), 6 deletions(-) diff --git a/fs/fuse/virtio_fs.c b

Re: [PATCH 2/3] virtiofs: split requests that exceed virtqueue size

2021-03-24 Thread Connor Kuehl
On 3/24/21 10:30 AM, Miklos Szeredi wrote: On Wed, Mar 24, 2021 at 4:09 PM Connor Kuehl wrote: On 3/18/21 10:17 AM, Miklos Szeredi wrote: I removed the conditional compilation and renamed the limit. Also made virtio_fs_get_tree() bail out if it hit the WARN_ON(). Updated patch below. Hi

Re: [PATCH 2/3] virtiofs: split requests that exceed virtqueue size

2021-03-24 Thread Connor Kuehl
On 3/18/21 10:17 AM, Miklos Szeredi wrote: I removed the conditional compilation and renamed the limit. Also made virtio_fs_get_tree() bail out if it hit the WARN_ON(). Updated patch below. Hi Miklos, Has this patch been queued? Connor --- From: Connor Kuehl Subject: virtiofs: split

Re: [PATCH] fs/fuse/virtio_fs: Fix a potential memory allocation failure

2021-03-24 Thread Connor Kuehl
On 3/24/21 7:38 AM, zhouchuangao wrote: Allocate memory for struct fuse_conn may fail, we should not jump to out_err to kfree(fc). Why not? If fc's allocation fails then it is NULL and calling kfree() on a NULL pointer is a noop[1]. Connor [1]

Re: [PATCH] fuse: Fix a potential double free in virtio_fs_get_tree

2021-03-23 Thread Connor Kuehl
On 3/23/21 12:18 AM, Lv Yunlong wrote: In virtio_fs_get_tree, fm is allocated by kzalloc() and assigned to fsc->s_fs_info by fsc->s_fs_info=fm statement. If the kzalloc() failed, it will goto err directly, so that Right, I follow this so far. fsc->s_fs_info must be non-NULL and fm will be

Re: [PATCH 2/3] virtiofs: split requests that exceed virtqueue size

2021-03-19 Thread Connor Kuehl
On 3/19/21 8:49 AM, Vivek Goyal wrote: On Thu, Mar 18, 2021 at 08:52:22AM -0500, Connor Kuehl wrote: If an incoming FUSE request can't fit on the virtqueue, the request is placed onto a workqueue so a worker can try to resubmit it later where there will (hopefully) be space for it next time